From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB448C10F14 for ; Tue, 16 Apr 2019 14:29:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78F9C205F4 for ; Tue, 16 Apr 2019 14:29:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tvp7/WL3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="nlVTCHWB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78F9C205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LzuexdaWapJ5UPt85hdE/gjIuvpTvVVUjm1a6xf1N78=; b=tvp7/WL3eYnj07DxZf3LcNmIS nWlWedVdIzFVe0EDXWE1oKiTSf68kR8PIKIfJbSbjf0i21PYE7WEmQSXdcjNbl19jeAGYC6kPqHYk F6TIOm94cQ3iyyyo2RmGNcNAeBU7CWu5+BT56HRqEy1qYdjMYbI+C7ZiSL9qPxR09k1dVVPs0HLNF g2f+CzI0m6p71zX7tj5hFm0aG7C0CpfXoXIv7Xp6JMmq9k93jgU7UaRGlbEYQGGghL4ncf2HTyQkn gRUG5o0malzfqNekZo/l4SLmP/RPI/aelur3LjJBjYxrULy9oiq9nCsEpc/7cVAUmlrF0WeTF5xJA bZPqdq56g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGP5S-0001Tf-IH; Tue, 16 Apr 2019 14:29:26 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGP5N-0001Sg-MG for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 14:29:25 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 16 Apr 2019 07:29:01 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 16 Apr 2019 07:29:20 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 16 Apr 2019 07:29:20 -0700 Received: from [10.24.45.163] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 16 Apr 2019 14:29:15 +0000 Subject: Re: [PATCH V2 07/16] dt-bindings: PCI: designware: Add binding for CDM register check To: Thierry Reding References: <1554407683-31580-1-git-send-email-vidyas@nvidia.com> <1554407683-31580-8-git-send-email-vidyas@nvidia.com> <20190415145402.GF29254@ulmo> From: Vidya Sagar X-Nvconfidentiality: public Message-ID: Date: Tue, 16 Apr 2019 19:59:12 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190415145402.GF29254@ulmo> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1555424941; bh=x/YYQavugb0lHToFlit4CGFSE2dbDGusuJFCHXPDElo=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=nlVTCHWBzDqD41kTZrK9VxxndL8GHARMzKr2KR/Rn6UNtPCw4FG73uOjlUmapYBzF cW3hLn5UPBOnSUkLmXkKg1H36sxDY4hsz7Kzi9u11w7h0/miNUN73yMwAhHxUizmmb 1V79gmwbbNrzG7Liuooj/iRC0DLqZJ2OzmewnCWmsDyYqLkj/Zrnu20Vb50Xbic3eI lF60/XOMXzGCkBahMtN7Rd2ZUR5yzre14NluUNGziW6paz07/XaCT3pg7kBbSmndEk STBHx7loy56SZvz2BWUvxwp+Y5vhWXT3OClMns23yy+huyYUEQQaPLlLbRkQvYxWAu 82uLge+toY/zQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_072921_734388_0AAB43B3 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kthota@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/15/2019 8:24 PM, Thierry Reding wrote: > On Fri, Apr 05, 2019 at 01:24:34AM +0530, Vidya Sagar wrote: >> Add support to enable CDM (Configuration Dependent Module) registers check >> for any data corruption. CDM registers include standard PCIe configuration >> space registers, Port Logic registers and iATU and DMA registers. >> Refer Section S.4 of Synopsys DesignWare Cores PCI Express Controller Databook >> Version 4.90a >> >> Signed-off-by: Vidya Sagar >> --- >> Changes since [v1]: >> * This is a new patch in v2 series >> >> Documentation/devicetree/bindings/pci/designware-pcie.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> index c124f9bc11f3..728281b5bcd5 100644 >> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt >> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> @@ -31,6 +31,10 @@ Optional properties: >> - clock-names: Must include the following entries: >> - "pcie" >> - "pcie_bus" >> +- cdm-check: This is a boolean property and if present enables automatic >> + checking of CDM (Configuration Dependent Module) registers for data >> + corruption. CDM registers include configuration space registers and iATU >> + (internal Address Translation Unit) registers. > > By comparison the commit message also lists "Port Logic" and "DMA" > registers as being part of the CDM registers. Shouldn't they be part of > the bindings document as well? Ok. I'll add them in V3 patch series. > > Perhaps it'd also be a good idea to rename this property to something > more imperative, like "enable-cdm" or similar. Ok. I'll go with "enable-cdm-check". I hope that should be fine. > > Thierry > >> RC mode: >> - num-viewport: number of view ports configured in hardware. If a platform >> does not specify it, the driver assumes 2. >> -- >> 2.7.4 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel