From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29596C433EF for ; Fri, 7 Jan 2022 02:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=DPy6K1mcbspjyj/BsilfSJn751a2PeregnTsE7bh5tI=; b=1uMsuFK7GOSWmc0gaQQ/csAIqo 9Rr4k0UPvyQcrBEiU9VtpJLbEp8LhG0h38OEirdsnsvDSfeerJcOSCUw+I9O+2vmEeUj9NSIEX8o+ qSNYsb52135aRPOh2vul1fCyNLfQbXuPw+q86OwTGMaNPyP84jA4aK2PdHdJHAocDdbt+uUbfmEsT 0JB2ehrLp+Qrl6Qw9x5/utuYNqt60YbjZkRxr0OTG4JqPByjn6L5spzKxKhpQaROE9DhXQo+JGKtq 83vpFxEKd2N/BTAkvtE7TaETGRCZkyb2VouFtyZPEASjCUXoIqAFmlXejP3uAFHezChIknsUeatCe 7Kg3VWDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5emD-001u0W-8G; Fri, 07 Jan 2022 02:14:45 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5em8-001tzT-VS for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 02:14:42 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 976C45C01E3; Thu, 6 Jan 2022 21:14:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 06 Jan 2022 21:14:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=0 6eURL9b8QeWOTMaAa7Dof41LMk/Y1Gb6IHAND03JRw=; b=HftiO69yZZY4arPMz WBF0B4i1Qh7gAp4zVu0X+aI1rhpNIoUcoo7iVR5SHsdLeNvy+okSTpeFz03kzj1+ pqb74wSy4LI/pp7ZzzSbXpJxx1L33zzEubEEyocvDAWvKg7PA0dKodxPUFHSMBTN 90sH+ulaaiwT2GHMWTi5OY/B3awiPsEv4Wgqpkoe4hK+0gLiIgktFU/4nSvYp61v pCKHjdmR1symGXxxL6I+ZNm+4sOvHdXGkcCioHxu/dDIKx1gEvFwJpqq9dMs+pDy UlDAxTJ3ioC4vOnvHEOYmBjdKfRoiIiTUd2UTCI5LrL9ZcHtyWu4C8zRUI3Ylobs gUX4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=06eURL9b8QeWOTMaAa7Dof41LMk/Y1Gb6IHAND03J Rw=; b=ln0SRtZA4JvvS/vBJX7IpAddxZJ8SpbpviGFPRuEcyIusQQ904a2pE03n FHih54D7BPghuQulNd8fCGoD71hbDsmGa785Zj13RqwmQUT4Iv0PqhWCMGFdQBsc GIYFpyJDDh1EzX3deQkzPmKl8H0EK5Z9mPpQe2OgSJgF5nIqqHpDHfU5nGJ7haxa a5nTkKiq2toHTDCKKjfrdXOysTDc9keIBFwpNW2UfUY2pzUnQe+t7WKi+2EqDeFY S5qi5RMRMLOJGCNe4kJTCO76dbKvwXHfDqjIecCpO1DFdhW1Qa/cnzgByhKJVZTY EsbEBOG69ZVlGcAl6nmKv6LCn67ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudegtddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepgfevffetleehffejueekvdekvdeitdehveegfeekheeuieeiueet uefgtedtgeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Jan 2022 21:14:34 -0500 (EST) Subject: Re: [PATCH] pinctrl: sunxi: Fix H616 I2S3 pin data To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Linus Walleij Cc: Jernej Skrabec , SASANO Takayoshi , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20220105172952.23347-1-andre.przywara@arm.com> From: Samuel Holland Message-ID: Date: Thu, 6 Jan 2022 20:14:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20220105172952.23347-1-andre.przywara@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_181441_216869_5CC7B48C X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/5/22 11:29 AM, Andre Przywara wrote: > Two bugs have sneaked in the H616 pinctrl data: > - PH9 uses the mux value of 0x3 twice (one should be 0x5 instead) > - PH8 and PH9 use the "i2s3" function name twice in each pin > > For the double pin name we use the same trick we pulled for i2s0: append > the pin function to the group name to designate the special function. > > Fixes: 25adc29407fb ("pinctrl: sunxi: Add support for the Allwinner H616 pin controller") > Reported-by: SASANO Takayoshi > Signed-off-by: Andre Przywara Reviewed-by: Samuel Holland Verified against the manual, which ironically also has the function numbers wrong: it lists two function 4's (and no function 5) for each pin in port H. > --- > drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c b/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c > index ce1917e230f4..152b71226a80 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c > @@ -363,16 +363,16 @@ static const struct sunxi_desc_pin h616_pins[] = { > SUNXI_FUNCTION(0x0, "gpio_in"), > SUNXI_FUNCTION(0x1, "gpio_out"), > SUNXI_FUNCTION(0x2, "uart2"), /* CTS */ > - SUNXI_FUNCTION(0x3, "i2s3"), /* DO0 */ > + SUNXI_FUNCTION(0x3, "i2s3_dout0"), /* DO0 */ > SUNXI_FUNCTION(0x4, "spi1"), /* MISO */ > - SUNXI_FUNCTION(0x5, "i2s3"), /* DI1 */ > + SUNXI_FUNCTION(0x5, "i2s3_din1"), /* DI1 */ > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 8)), /* PH_EINT8 */ > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 9), > SUNXI_FUNCTION(0x0, "gpio_in"), > SUNXI_FUNCTION(0x1, "gpio_out"), > - SUNXI_FUNCTION(0x3, "i2s3"), /* DI0 */ > + SUNXI_FUNCTION(0x3, "i2s3_din0"), /* DI0 */ > SUNXI_FUNCTION(0x4, "spi1"), /* CS1 */ > - SUNXI_FUNCTION(0x3, "i2s3"), /* DO1 */ > + SUNXI_FUNCTION(0x5, "i2s3_dout1"), /* DO1 */ > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 9)), /* PH_EINT9 */ > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 10), > SUNXI_FUNCTION(0x0, "gpio_in"), > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel