From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AD9C2D0A8 for ; Tue, 29 Sep 2020 03:12:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5359216C4 for ; Tue, 29 Sep 2020 03:12:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yvPb+ubf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5359216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JtwdUH4kLMkKMT+/MyxQsuqOQf33QxPoqeBUj4blK7k=; b=yvPb+ubfGW3h/T1CAa0VTGeLQ Nl4FCiXRU1GpKCU0fC3yqb1uk8bEYjaGne9ygO3UmY7qZbHXYtu/cTpklqIBYtcjk8hyxr+djaEfp 2DqN9TOOgCD9qbIezVeq5mOtqKAGrKlpzJ7xdPSEYetzXBWE77w+cbeF2QEHtqmcTkqGZDEpty3Lc pdx0GF7gJSl2jCm2D/oHQbvu6o87UYQsyXtekUI/UJRcGbC/Bw3ZbpgUfoJDNfLlFFdvvzz31oQ3s dYtM8px/tUVTouJ6uqPcxUs+nXgymcCDu3Ggv7GBt3cvaqSIhSMly62M6gIIrvjQBz4AmLWXc3ukm z9qWnu67A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN635-0001L1-57; Tue, 29 Sep 2020 03:11:27 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN631-0001Jp-W2 for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 03:11:25 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id ACA9D3CB6BA51EF0EAE4; Tue, 29 Sep 2020 11:11:21 +0800 (CST) Received: from [127.0.0.1] (10.174.177.253) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Tue, 29 Sep 2020 11:11:12 +0800 Subject: Re: [PATCH v4 20/20] dt-bindings: arm: hisilicon: convert LPC controller bindings to json-schema To: Rob Herring References: <20200928151324.2134-1-thunder.leizhen@huawei.com> <20200928151324.2134-21-thunder.leizhen@huawei.com> <20200928191635.GB3099266@bogus> From: "Leizhen (ThunderTown)" Message-ID: Date: Tue, 29 Sep 2020 11:11:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20200928191635.GB3099266@bogus> Content-Language: en-US X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_231124_306267_48FBE75B X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Kefeng Wang , linux-kernel , Wei Xu , Libin , Jonathan Cameron , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/9/29 3:16, Rob Herring wrote: > On Mon, Sep 28, 2020 at 11:13:24PM +0800, Zhen Lei wrote: >> Convert the Hisilicon Hip06 SoCs implement a Low Pin Count (LPC) >> controller binding to DT schema format using json-schema. >> >> Signed-off-by: Zhen Lei >> --- >> .../arm/hisilicon/hisilicon-low-pin-count.txt | 33 ------------ >> .../arm/hisilicon/hisilicon-low-pin-count.yaml | 61 ++++++++++++++++++++++ >> 2 files changed, 61 insertions(+), 33 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.txt >> create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.txt >> deleted file mode 100644 >> index 10bd35f9207f2ee..000000000000000 >> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.txt >> +++ /dev/null >> @@ -1,33 +0,0 @@ >> -Hisilicon Hip06 Low Pin Count device >> - Hisilicon Hip06 SoCs implement a Low Pin Count (LPC) controller, which >> - provides I/O access to some legacy ISA devices. >> - Hip06 is based on arm64 architecture where there is no I/O space. So, the >> - I/O ports here are not CPU addresses, and there is no 'ranges' property in >> - LPC device node. >> - >> -Required properties: >> -- compatible: value should be as follows: >> - (a) "hisilicon,hip06-lpc" >> - (b) "hisilicon,hip07-lpc" >> -- #address-cells: must be 2 which stick to the ISA/EISA binding doc. >> -- #size-cells: must be 1 which stick to the ISA/EISA binding doc. >> -- reg: base memory range where the LPC register set is mapped. >> - >> -Note: >> - The node name before '@' must be "isa" to represent the binding stick to the >> - ISA/EISA binding specification. >> - >> -Example: >> - >> -isa@a01b0000 { >> - compatible = "hisilicon,hip06-lpc"; >> - #address-cells = <2>; >> - #size-cells = <1>; >> - reg = <0x0 0xa01b0000 0x0 0x1000>; >> - >> - ipmi0: bt@e4 { >> - compatible = "ipmi-bt"; >> - device_type = "ipmi"; >> - reg = <0x01 0xe4 0x04>; >> - }; >> -}; >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.yaml b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.yaml >> new file mode 100644 >> index 000000000000000..83ca10adce71b62 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/hisilicon/hisilicon-low-pin-count.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hisilicon Hip06 Low Pin Count device >> + >> +maintainers: >> + - Wei Xu >> + >> +description: | >> + Hisilicon Hip06 SoCs implement a Low Pin Count (LPC) controller, which >> + provides I/O access to some legacy ISA devices. >> + Hip06 is based on arm64 architecture where there is no I/O space. So, the >> + I/O ports here are not CPU addresses, and there is no 'ranges' property in >> + LPC device node. >> + >> +properties: >> + $nodename: >> + pattern: '^isa@[0-9a-f]+$' >> + description: | >> + The node name before '@' must be "isa" to represent the binding stick >> + to the ISA/EISA binding specification. >> + >> + compatible: >> + enum: >> + - hisilicon,hip06-lpc >> + - hisilicon,hip07-lpc >> + >> + reg: >> + description: base memory range where the LPC register set is mapped. > > Drop description. OK > >> + maxItems: 1 >> + >> + '#address-cells': >> + description: must be 2 which stick to the ISA/EISA binding doc. > > Drop. OK > >> + const: 2 >> + >> + '#size-cells': >> + description: must be 1 which stick to the ISA/EISA binding doc. > > Drop. OK > >> + const: 1 >> + >> +required: >> + - compatible >> + - reg > > additionalProperties: > type: object OK, I will add it. > >> + >> +examples: >> + - | >> + isa@a01b0000 { >> + compatible = "hisilicon,hip06-lpc"; >> + #address-cells = <2>; >> + #size-cells = <1>; >> + reg = <0xa01b0000 0x1000>; >> + >> + ipmi0: bt@e4 { >> + compatible = "ipmi-bt"; >> + device_type = "ipmi"; >> + reg = <0x01 0xe4 0x04>; >> + }; >> + }; >> +... >> -- >> 1.8.3 >> >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel