From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D849EC28D13 for ; Mon, 22 Aug 2022 09:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NMpUUx4twVpcq0pX8XAUhqsGw+abyuxjNLsLO5Xlbs4=; b=CgiDS/fLqllzDW CX5sSU/Y/zHSXXLPqKTB9xaeJ+SYuF6xEmBamec821JujL7clJafcHWpHfuPg8rjL9sDaWruay1Cn jeb+p4K1aajOiUfNQLgnCQ9BD4UBPnIYgvFpanej3U1iEWxImGOutwCIyfCNnyPfoNpNGWINnqxLj wtJKNaZcNq82f52uIMG7bQoR6v+h0AfR2fmZjTqR5DXAjryVTLV7bUBmVlNCS9hnphf/v8utp2Eq7 +n2yM4iuw5dg+Nrtyet9THzMkCCX1KQaszOoc9IX+DgDuX96qBSkKf1MJPUUaN5arzGKUQY6zOFwz XEaNz0tagOFlWGhipalQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ3mt-0074IO-HH; Mon, 22 Aug 2022 09:32:03 +0000 Received: from mail-bn8nam12on2058.outbound.protection.outlook.com ([40.107.237.58] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ3mp-0074Dd-O8 for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 09:32:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JqYOf2/5Fy0TqeSzk1snmKWN+W/3S3nppt80G7oR0IDEBd7mIn2c6/GD2NElffu9jFy2/Nj7rKUvc0+TZJ5N2uB1Jk57RVplDsgbz8wSLhzmginZF1ThxHTb7MAc1F3FLtXzw9p9FHE+JceDhJNueLkl1YeGue5Z0DDeynT7JUy8amOaylySW3VsCkmlwZgcjlEViYjgZ7MLwp0ROzzc8UaGM667SJOJtAT+jJUH/loDIHnoEAyNA64HptuZSHYYuGnXFyIa4GEG3mtQ9w82Cqo1RR4FByz+iGrZTJ9XcDJvckwT3aW3FxUPe6e+UV3e1iHki3m0W4Jh+aW1R/gRng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jXbCPNXNWdOsVsDuwZCI6LVbpYEJncVKQOWRB6zE9os=; b=cYE0QtB2RdwFpYIjp+UjO5+rrtXTgKCgl9hfm8X6wQtik0+mAoOHOaT/TH6qLyXXxVq2Zas0bl82Sx6eEwvSpVTqmyW1vPnqLDUncKiQbYMLeeNWHh6KeqSK92TfmzPeugbQufNQfKfP7x6gF/vO5pb1+rNttUdzJQLru8tQeOdO137ZFCtfzjB0Y217ojq6mkF0tYd3NcFZadzy3qvsD1eGs8G5R6mLC9OaHgMVv8LxJjNMKdKxuFR+eyiLXuLVD/DBerMDenq8VFvSc0+eoD2NHsS5KHiD2lukpG5Lqw5iR8qjn+hn2qubRWHi/omo7BFlCySqLNQPreV5BohLNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jXbCPNXNWdOsVsDuwZCI6LVbpYEJncVKQOWRB6zE9os=; b=Hb8zZxCVjmAI0szs8hwSQEC4qun3/Jr55ZbLbiyHsBq1nVwhLH1SlnHm6Om3oawBEPAlcWTMLvnNDRBNtpNtFhEgc61GJBGKEhsIvoebz7fLlyay2x36MjlDqGMzMUyO3QOGJIMcEI0HcabxFBK98gJz64YfQAOkDqrF+rQootEMMDMtbiUYk+y5lAEl8xQ4FnMpAbzZKC2Zq/AmZo+Y+H9ZcAI9j+T9pY+91WqH/4rCK7CtM/FmoQGng7v7q8tBJp6i7TAxzxnZw0Npm/rexR172DK9x5P1gSDvN1LPy936T35n6ydg0WzpDqagEzMrPF/UcXywDO30K/V/6JQSIA== Received: from BN1PR10CA0029.namprd10.prod.outlook.com (2603:10b6:408:e0::34) by MWHPR12MB1326.namprd12.prod.outlook.com (2603:10b6:300:10::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Mon, 22 Aug 2022 09:31:52 +0000 Received: from BN8NAM11FT053.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e0:cafe::6c) by BN1PR10CA0029.outlook.office365.com (2603:10b6:408:e0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22 via Frontend Transport; Mon, 22 Aug 2022 09:31:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.236) by BN8NAM11FT053.mail.protection.outlook.com (10.13.177.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5546.15 via Frontend Transport; Mon, 22 Aug 2022 09:31:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Mon, 22 Aug 2022 09:31:50 +0000 Received: from [10.41.21.79] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 22 Aug 2022 02:31:46 -0700 Message-ID: Date: Mon, 22 Aug 2022 15:01:43 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [GIT PULL 1/7] soc/tegra: Changes for v5.20-rc1 Content-Language: en-US To: Arnd Bergmann , Thierry Reding CC: Borislav Petkov , arm-soc , SoC Team , Jon Hunter , "open list:TEGRA ARCHITECTURE SUPPORT" , Linux ARM , , "Mauro Carvalho Chehab" , Tony Luck , "James Morse" , Robert Richter , , Vikram Sethi , Sumit Gupta References: <20220708185608.676474-1-thierry.reding@gmail.com> <20220708185608.676474-2-thierry.reding@gmail.com> <8dd2310d-cf1d-600e-0bd3-7b16c7b4ac18@nvidia.com> From: Sumit Gupta In-Reply-To: X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 828cd0b6-41e4-468f-7ca7-08da84212527 X-MS-TrafficTypeDiagnostic: MWHPR12MB1326:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sp05VsyK/GVtwragXNJPvz1siLcZ5uH64RL7tFGtUCYWEUz2ng9ITdgSbgP1XDIrVPMctM/jAQXCZ9P/NJn99pO8NCnb6Iy6G9QfgMYjFdLJDaBgz+J2VetJRKE/VLCtN8h+IwstZUWM5ew8OGzdBC6YICLOpgzYamE5xA8UrigbTLiI/BJZ0tbpGnU1BDilLEQoYS9ZYvWto3I5lCXeJ5r/ZaIV3PHuILAkb8iJVoMcXlQmNxyS8xN0gJDlH8+m//zaf2f16M1agQWX0vOvjuSjKezWoNasomLFozFDe0ySZNyr40EZcUJeajIpldvdGI+Jhk595La7TDiBSZqHkcw4JHzVb80fcIY8mD2q+QtChWcJIZfmcBiZbDSxh58Pn2hkQccqWyMrw2IlOKJgqo206c15okHIbThdKdleu1CfHD3V9w8x6P/+FVnusQYOuxuMZvBhV2KVMnGLpoRpGaCMAqMbF+01tADZ9kuWfaR8bucrTyqL+qocshVn4a7bSIhjKESp0tevEev6vd2ul8dEdE5G8xlG92Jomrq9EoMjfbRNKvifm7tY9nGVqBrGalhC/IJJ03cT9K7Eke2DzMEXR8yxGoBiEQaoXzxKXOogNoDykZTrws01YOOOfvslKTPTxyZ6O90W01eOtAFXGls+JOWGCVta48QTB4X+PXii5N7mz26wUOYAYpfCfhAGHsqfhy2R8FFeOBVlBLHWUjTYNKqyHkAUR7T/xMor0Wba50A5edweIdkpdh64cYhTSGpDrj9NgWhuLI+/I3aMo4noAIDSUqKkGt6V5/nr0/hLKir6tZmBOb6B5g6bdUQ6Aw67N/ezCL4X8FAN0CQr2A== X-Forefront-Antispam-Report: CIP:12.22.5.236;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(136003)(376002)(40470700004)(36840700001)(46966006)(5660300002)(36860700001)(70586007)(8676002)(70206006)(4326008)(356005)(82740400003)(478600001)(316002)(81166007)(6666004)(41300700001)(26005)(47076005)(7416002)(8936002)(40460700003)(16576012)(2906002)(54906003)(31696002)(40480700001)(83380400001)(2616005)(107886003)(16526019)(186003)(110136005)(336012)(426003)(82310400005)(36756003)(86362001)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 09:31:51.6603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 828cd0b6-41e4-468f-7ca7-08da84212527 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.236];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1326 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_023200_103986_84FFB56B X-CRM114-Status: GOOD ( 22.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Fri, Jul 15, 2022 at 01:36:16PM +0530, Sumit Gupta wrote: >> Hi Arnd, Boris, >> >> Thank you for your inputs. >> >>>> I think this is just a reflection of what other hardware can do: >>>> most machines only detect memory errors, but the EDAC subsystem >>>> can work with any type in principle. There are also a lot of >>>> conditions elsewhere that can be detected but not corrected. >>> Just a couple of thoughts from looking at this: >>> >>> So the EDAC thing reports*hardware* errors by using the RAS >>> capabilities built into an IP block. So it started with memory >>> controllers but it is getting extended to other blocks. AMD are looking >>> at how to integrate GPU hw errors reporting into it, for example. >>> >>> Looking at that CBB thing, it looks like it is supposed to report not >>> so much hardware errors but operational errors. Some of the hw errors >>> reported by RAS hw are also operation-related but not the majority. >>> >> CBB driver reports errors due to bad MMIO accesses within software. >> The vast majority of the CBB errors tend to be programming errors in setting >> up address windows leading to decode errors. >> >>> Then, EDAC has this counters exposed in: >>> >>> $ grep -r ./sys/devices/system/edac/ >>> /sys/devices/system/edac/power/runtime_active_time:0 >>> /sys/devices/system/edac/power/runtime_status:unsupported >>> /sys/devices/system/edac/power/runtime_suspended_time:0 >>> /sys/devices/system/edac/power/control:auto >>> /sys/devices/system/edac/pci/edac_pci_log_pe:1 >>> /sys/devices/system/edac/pci/pci0/pe_count:0 >>> /sys/devices/system/edac/pci/pci0/npe_count:0 >>> /sys/devices/system/edac/pci/pci_parity_count:0 >>> /sys/devices/system/edac/pci/pci_nonparity_count:0 >>> /sys/devices/system/edac/pci/edac_pci_log_npe:1 >>> /sys/devices/system/edac/pci/edac_pci_panic_on_pe:0 >>> /sys/devices/system/edac/pci/check_pci_errors:0 >>> /sys/devices/system/edac/mc/power/runtime_active_time:0 >>> /sys/devices/system/edac/mc/power/runtime_status:unsupported >>> ... >>> >>> with the respective hierarchy: memory controllers, PCI errors, etc. >>> >>> So the main question is, does it make sense for you to fit this into the >>> EDAC hierarchy and what would even be the advantage of making it part of >>> EDAC? >>> >> I also think this doesn't seem to fit with the errors reported by EDAC which >> are mainly hardware errors as Boris explained. >> Please share your thoughts and if we can merge the patches as it is. > Arnd, > > any more thoughts on this? Looks like there is no consensus on where > this should go. If it's okay for this to go in via ARM SoC after all, > I could prepare another pull request including only the CBB changes > along with some of the reference count fixes. I could possibly also > rework the DMADEVICES dependency patch as discussed, or we could defer > it if it's too risky at this point. > > Thierry Hi Arnd, Thierry, Gentle ping. If we are OK with the reasoning then can we please queue the patch series for '6.1'. Thank you, Sumit _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel