From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 340F9C77B7A for ; Thu, 18 May 2023 14:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mk0Wp8r0UrhUHu8drfvT+OvX6Iw6rU7uFPy4qIZC4Dw=; b=KMdjg+pDimcf4I at+wKhpmDhapzcEVpB+umFTmLS2SDU0WbIc2iN5Rav3OMTgta0foaMcjtDsK/RBqiukAfhbS2DJp/ NeAlEz324N3CrZUwk2ui8omvNBl6Z19uMivZlnSGDTW7ZAL9AiL4XwdCQ8uOcAVXC+DL1znXpS3Fw VWtCUpraSNwCsc7m55FAlkFibWafFkLzRcjnPE3mZaz2gcnaG3JwiV6DurKMWfWlRKE8/8uwAcaOK 1UqrA+UqeyiwMXcgGIXxisKrIp6Gnp/E787cL6MkvOcYlZlFZI7h4MGmnP1ha2G8NonlhD2kJFvbH l4h9PNrU6r6t226Fxueg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzeJb-00D9mA-0I; Thu, 18 May 2023 14:09:11 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzeJX-00D9l3-1n for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 14:09:09 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-965b5f3b9ffso249842966b.0 for ; Thu, 18 May 2023 07:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684418944; x=1687010944; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ynI1F9GRlorpTQ3//tjzRjm9oO2VDWxwaEiCp14cw+8=; b=l/uqrQwhsN91ktGXDLHSeOnK04VqjMfjApJem9V22gmlQ2PMPpJ6PIkXIknZORpOo9 13oiHJvgawnfSmhP1Ekes3Z0PPfLCy7iq9Iq3J7xclj9g9fC3oevOOr7p1GcLJiVBKJc G0+K2R6js7q7WGM8H9bHuIMwtHp2MUfnLiny7Yhi8cLh+m5yxXb5L3HTgJXkaR29N/Sw gWEvPp3eVirnwoR3WyUu9ewAt76N+QSUvYWIK+1F2B1Jp9H0B/+1vGRP4/jwHj2GvYae Fr7Cl3+lRz91r81XjP8byuGztLkI1zQZucjp41lch/kdQwYOxjFdcXyPq06pSBjTUxux B2lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684418944; x=1687010944; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ynI1F9GRlorpTQ3//tjzRjm9oO2VDWxwaEiCp14cw+8=; b=D84ZXfR971PHhh3V5d1GFjcfUHBXSP6ZUBCz1JkgnjDnZdXsSK+HiUgOMOIHXNE6hy XCAGFOoHzTlg1HeZDEi5YMhS3zA3fkg9cB21hVQ2FCqKNkcy+c3bbvlR6vwZ8a0wlZvG +TNSJiNw6XANyV6Cu5h3nugxF52j46EWEdDMN2O118aoiMNpcOikaLWcMQvaV1V0V3mb mGbnotTibyPdTxmDvGiOPJGZqT7uw856gw3dn20nKq9bdCaNemk2+6k9fp2dxzsnBuVC JjDjbV+Fh+L+eWif8vjc78bujX2A6g9oJQY/wXleao3dNN9+zwLanNe0JtVxB8uEXSX1 3ZkA== X-Gm-Message-State: AC+VfDzCGSa+HJl3pnHqj3OBo9wODm4bhjzdhis63I803mD5oZkaxWdf NI3EzhoOoU1nF4262E049qvFaA== X-Google-Smtp-Source: ACHHUZ7AWtaKIYmvs/UYoBsfo7y1w1zvObfFUtKx8gAePaPSKP9wKSev0O+652RoyHlDI7I/+hlO1w== X-Received: by 2002:a17:907:7f18:b0:96b:1606:f015 with SMTP id qf24-20020a1709077f1800b0096b1606f015mr5350697ejc.18.1684418943709; Thu, 18 May 2023 07:09:03 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7e24:6d1b:6bf:4249? ([2a02:810d:15c0:828:7e24:6d1b:6bf:4249]) by smtp.gmail.com with ESMTPSA id c7-20020a17090654c700b0096f4389714csm441423ejp.55.2023.05.18.07.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 07:09:02 -0700 (PDT) Message-ID: Date: Thu, 18 May 2023 16:09:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] dt-bindings: clock: Add binding documentation for TI Audio REFCLK Content-Language: en-US To: Conor Dooley , Jai Luthra , Andrew Davis Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Santosh Shilimkar , Vignesh Raghavendra , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230515-refclk-v1-0-5e89f01d6733@ti.com> <20230515-refclk-v1-1-5e89f01d6733@ti.com> <20230517-reprise-unroll-e2223cab3846@spud> From: Krzysztof Kozlowski In-Reply-To: <20230517-reprise-unroll-e2223cab3846@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_070907_600307_D3C0718B X-CRM114-Status: GOOD ( 16.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2023 19:15, Conor Dooley wrote: > On Wed, May 17, 2023 at 01:04:05PM +0530, Jai Luthra wrote: >> Add DT bindings for TI's audio reference clocks (REFCLK) present on AM62 >> SoC. > > This seems fine to me. Perhaps Krzysztof will differ... > Reviewed-by: Conor Dooley > >> >> Signed-off-by: Jai Luthra >> --- >> .../bindings/clock/ti,am62-audio-refclk.yaml | 44 ++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml b/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml >> new file mode 100644 >> index 000000000000..7c4cf7abe007 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml >> @@ -0,0 +1,44 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/ti,am62-audio-refclk.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI Audio Reference Clock >> + >> +maintainers: >> + - Jai Luthra >> + >> +properties: >> + compatible: >> + items: >> + - const: ti,am62-audio-refclk >> + - const: syscon I just don't get why this is syscon? There are no references to it, no DTS change and nothing in the driver suggesting it has to be syscon (creating regmap for internal use does not count). Andrew, Is this the pattern we discussed and wanted to remove? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel