From: Florian Fainelli <f.fainelli@gmail.com>
To: Scott Branden <scott.branden@broadcom.com>,
Bjorn Helgaas <helgaas@kernel.org>,
cgel.zte@gmail.com
Cc: lpieralisi@kernel.org, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
ye xingchen <ye.xingchen@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable
Date: Tue, 6 Sep 2022 14:37:47 -0700 [thread overview]
Message-ID: <cd65ca29-1e24-1064-ccd4-160dbd041036@gmail.com> (raw)
In-Reply-To: <5cbe247d-f9a3-4770-1ca7-5ba5097451ba@broadcom.com>
On 9/6/2022 2:27 PM, Scott Branden wrote:
>
>
> On 2022-09-06 14:25, Bjorn Helgaas wrote:
>> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@gmail.com wrote:
>>> From: ye xingchen <ye.xingchen@zte.com.cn>
>>>
>>> Return the value iproc_pcie_setup_ib() directly instead of storing it in
>>> another redundant variable.
>>>
>>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>>> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
>>
>> This patch itself is fine,
> Does the patch serve any real use though?
Not really though if we don't accept it, then someone else will submit a
similar patch later, since it is obviously correct, might as well accept it?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-06 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 7:16 [PATCH linux-next] PCI: iproc: Remove the unneeded result variable cgel.zte
2022-09-06 16:54 ` Florian Fainelli
2022-09-06 21:25 ` Bjorn Helgaas
2022-09-06 21:27 ` Scott Branden
2022-09-06 21:37 ` Florian Fainelli [this message]
2022-09-07 3:10 ` [PATCH linux-next] cgel.zte
2022-09-27 12:07 ` [PATCH linux-next] PCI: iproc: Remove the unneeded result variable Lorenzo Pieralisi
2022-09-27 12:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd65ca29-1e24-1064-ccd4-160dbd041036@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=cgel.zte@gmail.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=ye.xingchen@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).