From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8571CC6FA86 for ; Tue, 6 Sep 2022 21:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1d+u9b87A9auOb7IZ2WZT9+xX3vU5sbJoI6fyZN85t4=; b=BxUSVFkZwdAb5P lTHedL8eMRDRJP8GQRC6AxFsIatw2B21MhrQIb9/DLt9bXdVzCD5jCRJr5kBBzhOHE83G6SjOQBp+ bn9HE7wniql2eNpU4ANpy0jAuUQ/b0vZ2qHrkyCAmfzp4zATVP0Xn3SPHw5iBm9Aa1cO1Ojxh2LFg RBDdfFaFqa5ripHNhV7NailF9uX9A4DlYVWP8zdAN0DoNViTLyVRsEAQGn0Be4ei2xFykWr382uYB SLlhLQQxLfyDZLfN8swOaSOtsoAce+1183D8DGPYHmJ3FF2ogL4zf9V5yHtnyCzin+8Chl8gKGDTp 85QZC7Vnya71hy6NQ6tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVgGe-00HYsH-Sd; Tue, 06 Sep 2022 21:38:01 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVgGX-00HYp4-Qb for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 21:37:58 +0000 Received: by mail-qk1-x72f.google.com with SMTP id i9so3272019qka.0 for ; Tue, 06 Sep 2022 14:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=DHX1HSLOHo9Z/nGtQGSoEFCNbitNhP6bU01rtWegVaM=; b=nZO42iFp+TVsIXrFMoRJ6RcOkMgzUk5royDEvAP9gzp7J46eVh8Q1tn0P3wqXsn2ZY mqDs5av6WDG9g/rGHO1TeWTlq0rshWusz+AcYhDyc7iazYi/kUI8DAGafUHtk/pjYpcl b8FvoMremNvg3JII+4DiZzcr4WiMMbTQC38xQec4jbYFYIZz86MnI20VdblnXDevLBJe eWUQ0Jnz+vmbMFYcLo+paHRPyp0ycAFMzX4NZCidys1jfhJ3seVNz45eiozl2W6dvZIT GtekMScqm+Bs8Ff0MjNmRTXalSf85hFwMs7+V1CEC5pTTZUpJO7mBCQaQZ9k4xbyUtBr 6WWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=DHX1HSLOHo9Z/nGtQGSoEFCNbitNhP6bU01rtWegVaM=; b=4xPwfWOo6PYXxPOux5NXEfSl7NqBQIS/pKBGgILd2xeujU/Q3Ru8IegpajKQit5IqW 13p05CIjiHGOyM4pi9RD0fIU2LoWsxLoROvMcCjpfCN2HCXfbhz1jH/SmErhsOUdLLbe FFeYWDxpYXOt8TKhaqyb0TQQFlq64xjAG3cnXiRX89oekf4Dz65xhoKyfh430Kh9Y0EM YXkeVK1/o/d8QXRP0XkZhBsEDZKhrp+GEJWIGzY+h3kUlVDomBHno3AB9mfekHKE/zDa 9zbMnS9N5k8JWZOID0hFivA3smikyxyS2d4jjVBXrbDfxojpVZnmWbjF2tuPpHpU49rg sgAg== X-Gm-Message-State: ACgBeo39/FAUj7f14/gj4IQ6ylUkEG7fyUG/MBsYfpvFSSKKMHsK6fp1 4YnIfXNuA82rv8WkBogmBuI= X-Google-Smtp-Source: AA6agR63LhMW7qT4SeyFeq6A1YKRxkQWyEEerUaLVY8XEbSiDWeqHx0DWtvJa/J9Q4FQhTEGRBn3Wg== X-Received: by 2002:a05:620a:c4b:b0:6b6:5a6d:6d2d with SMTP id u11-20020a05620a0c4b00b006b65a6d6d2dmr508196qki.441.1662500271791; Tue, 06 Sep 2022 14:37:51 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id w15-20020a05620a424f00b006bbdcb3fff7sm13005923qko.69.2022.09.06.14.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 14:37:51 -0700 (PDT) Message-ID: Date: Tue, 6 Sep 2022 14:37:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable Content-Language: en-US To: Scott Branden , Bjorn Helgaas , cgel.zte@gmail.com Cc: lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot References: <20220906212520.GA45166@bhelgaas> <5cbe247d-f9a3-4770-1ca7-5ba5097451ba@broadcom.com> From: Florian Fainelli In-Reply-To: <5cbe247d-f9a3-4770-1ca7-5ba5097451ba@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_143756_859982_30EDFE69 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/6/2022 2:27 PM, Scott Branden wrote: > > > On 2022-09-06 14:25, Bjorn Helgaas wrote: >> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@gmail.com wrote: >>> From: ye xingchen >>> >>> Return the value iproc_pcie_setup_ib() directly instead of storing it in >>> another redundant variable. >>> >>> Reported-by: Zeal Robot >>> Signed-off-by: ye xingchen >> >> This patch itself is fine, > Does the patch serve any real use though? Not really though if we don't accept it, then someone else will submit a similar patch later, since it is obviously correct, might as well accept it? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel