From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 681B3C433F5 for ; Wed, 2 Mar 2022 20:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eARaPGjSQlWR8QoIzbG+V26BRuwuhr5MCHuYHaXEQcA=; b=ypUk7vo9swiNh1 i6g7/UN+V8DmZCzgCAD4h7qLi2avtbOuvaINk3foPc41g3oUy2ZYFSQI4+RKfBcDs8vTk29swNalS gAMONuhfXVdrG0Vz8q2q36nddcXmUsb4p2FZaNJ67tlFwa6KEJ8N8RXb3ToipMTalp/bKsP+uT0bG kSwor7PdtNv6TYHmJ3buAO2DPm4wvs395xSAZ8FfjnBCIUcbQ5d+r9A/XuGlweIvTTF6C5Jc+Rc4J x4z3eVcb/tqIver69B+KeZfJKjebrPFn3yP16zNxQETYxItmlUR1a0SJWkf4+AYziYlfo9uMfM10f dyHmX5taQfp9iPyDUHvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPVn9-00478v-Bm; Wed, 02 Mar 2022 20:41:47 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPVn5-004784-MY for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 20:41:45 +0000 Received: from [192.168.4.54] (cpe-70-95-196-11.san.res.rr.com [70.95.196.11]) by linux.microsoft.com (Postfix) with ESMTPSA id D826220B7178; Wed, 2 Mar 2022 12:41:41 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D826220B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1646253702; bh=nGnrN6wZvEIMXigwO2qniJwHemfc6PMUGGJtDX7QpyY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dAFrxi7X3t+esiOuFgK3Tzk+rFkAf/KzrW80FE0S6od4CLcVjt8fIFLXrWsqVIvoD 1FwuoMUnCbXzzT5sFHrS8IJ06B3+EjMmsyLwJHJ+b4Lnqq+Bqmuti1kv7BnSdbpmY2 nSpmnX/8MenODANPuc4P/GUOSnd/IBCfHGjKLm/g= Message-ID: Date: Wed, 2 Mar 2022 12:41:42 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v3] arm64: Do not defer reserve_crashkernel() for platforms with no DMA memory zones Content-Language: en-US To: Pasha Tatashin , Catalin Marinas , Will Deacon Cc: Nicolas Saenz Julienne , Anshuman Khandual , Mike Rapoport , Ard Biesheuvel , LKML , Linux ARM References: <1646242689-20744-1-git-send-email-vijayb@linux.microsoft.com> From: Vijay Balakrishna In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_124143_859284_5F0357B1 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks Pasha. Catalin, Will, I can generate a new version with suggested change from Pasha. I'm fine if you modify. Thanks, Vijay On 3/2/2022 10:15 AM, Pasha Tatashin wrote: > Hi Vijay, > > The patch looks good to me, just one nit below. > >> -phys_addr_t arm64_dma_phys_limit __ro_after_init; >> +#if IS_ENABLED(CONFIG_ZONE_DMA) || IS_ENABLED(CONFIG_ZONE_DMA32) >> +phys_addr_t __ro_after_init arm64_dma_phys_limit; >> +#else >> +phys_addr_t __ro_after_init arm64_dma_phys_limit = PHYS_MASK + 1; > > Since in this case arm64_dma_phys_limit is initialized during > declaration, it would make sense to use const instead of > __ro_after_init. Consider changing the above to this: > const phys_addr_t arm64_dma_phys_limit = PHYS_MASK + 1; > > Reviewed-by: Pasha Tatashin > > Thank you, > Pasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel