From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A414EB64DD for ; Mon, 7 Aug 2023 05:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pPIf9TWEoAfnG/fluhHmwnmJaWEhJFGeQHh0qZ65sQw=; b=JESpPnwGSw+NG2 AVcYBnI9sYD5wV/aILR0d11Md6IuFQodwu+AuOx8/y97caqb+asf6P8hsZ8J9czqbwovnnUg6xshm VX+pAef2W9phj52gQNwMwa+KLdVtYwuh0s+AGbvJuVPNYZzObMCjoBX1pHJSOLVFqhZuiXdwS/F+e ztVCLR2TCOnFcQNq1z2TFnKxcC+O4ibOv2Q0FXxJl8vLig8R/hvJUVXQ5NNIxc5/9P7lKbwmiQXw+ tccZlm3MN9zCSY55e738i0u/I6NXUYPvXz5lSEYvIh8Wck6h+N1kzaXPawnYj7URxlyYHVlAChH0S Xoiew51B4UCikfNTL6oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSt9X-00GD0S-0j; Mon, 07 Aug 2023 05:51:39 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSt9T-00GCzf-1h for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 05:51:36 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3775pURT113852; Mon, 7 Aug 2023 00:51:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691387490; bh=VVvXG4usFMA56iZDBBDrmBYaECLOyytzA7J6NLmibwA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=aoNGwu1224OEQj1EoXPoY/I5Dwqcn99QbcXaGH/WsV0JYE3erCz2MccZ/8lssQ3Oq 232a4Gsvr7ssTFVORVVgmKzd8PVdOgJczKmcH0i7T+nH25hvx4ieV2gtNou6FgYLl1 osL4TEIeQsbddhRHHFUIc/emytlv3X9MJ6zECjbY= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3775pUjK015377 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Aug 2023 00:51:30 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 7 Aug 2023 00:51:30 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 7 Aug 2023 00:51:30 -0500 Received: from [172.24.227.68] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3775pQ4q023895; Mon, 7 Aug 2023 00:51:27 -0500 Message-ID: Date: Mon, 7 Aug 2023 11:21:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 12/13] arm64: dts: ti: k3-am65: Enable TSCADC nodes at the board level Content-Language: en-US To: Andrew Davis , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , CC: , References: <20230802205309.257392-1-afd@ti.com> <20230802205309.257392-13-afd@ti.com> From: Dhruva Gole In-Reply-To: <20230802205309.257392-13-afd@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230806_225135_669724_A510DF09 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andrew, On 03/08/23 02:23, Andrew Davis wrote: > TSCADC nodes defined in the top-level AM65 SoC dtsi files are incomplete > and may not be functional unless they are extended with pinmux and/or > device information. > > Disable the TSCADC nodes in the dtsi files and only enable the ones that > are actually pinned out on a given board. > > Signed-off-by: Andrew Davis > --- > arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 5 +---- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 2 ++ > arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 ++ > 3 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi > index 6041862d5aa75..ba1c14a54acf4 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi > @@ -582,11 +582,8 @@ &mcu_spi0 { > ti,pindir-d0-out-d1-in; > }; > > -&tscadc0 { > - status = "disabled"; > -}; > - > &tscadc1 { > + status = "okay"; The commit body says, "Disable the TSCADC nodes in the dtsi files" Please can we also provide some explanation on why tscadc1 was left as okay here in a dtsi file? > adc { > ti,adc-channels = <0 1 2 3 4 5>; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 2c9c20a9d9179..4defde540fe0b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -112,6 +112,7 @@ tscadc0: tscadc@40200000 { > dmas = <&mcu_udmap 0x7100>, > <&mcu_udmap 0x7101 >; > dma-names = "fifo0", "fifo1"; > + status = "disabled"; > > adc { > #io-channel-cells = <1>; > @@ -130,6 +131,7 @@ tscadc1: tscadc@40210000 { > dmas = <&mcu_udmap 0x7102>, > <&mcu_udmap 0x7103>; > dma-names = "fifo0", "fifo1"; > + status = "disabled"; > > adc { > #io-channel-cells = <1>; > diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > index 43de7c132d343..17f45a9f7b146 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > @@ -478,12 +478,14 @@ &usb0_phy { > }; > > &tscadc0 { > + status = "okay"; > adc { > ti,adc-channels = <0 1 2 3 4 5 6 7>; > }; > }; > > &tscadc1 { > + status = "okay"; > adc { > ti,adc-channels = <0 1 2 3 4 5 6 7>; > }; -- Thanks and Regards, Dhruva Gole _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel