From: Krzysztof Kozlowski <krzk@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: patches@lists.linux.dev, Ben Dooks <ben-linux@fluff.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, patches@armlinux.org.uk
Subject: Re: [PATCH] ARM: JIVE: fix return value of __setup handler
Date: Thu, 17 Mar 2022 08:32:34 +0100 [thread overview]
Message-ID: <cdba580f-097e-da4d-bfb4-63a7cb64ec95@kernel.org> (raw)
In-Reply-To: <20220312063609.19362-1-rdunlap@infradead.org>
On 12/03/2022 07:36, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from jive_mtdset().
>
> Fixes: 9db829f485c5 ("[ARM] JIVE: Initial machine support for Logitech Jive")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: patches@armlinux.org.uk
> ---
> KernelVersion: v5.17-rc7
>
> arch/arm/mach-s3c/mach-jive.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
It's too late for upcoming cycle, so I will pick it up after merge window.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-03-17 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 6:36 [PATCH] ARM: JIVE: fix return value of __setup handler Randy Dunlap
2022-03-17 7:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdba580f-097e-da4d-bfb4-63a7cb64ec95@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=patches@armlinux.org.uk \
--cc=patches@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).