From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C84AC433F5 for ; Thu, 17 Mar 2022 07:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wHPvVfX2mLjQz3PojSIvhsJ4Wg+0Lmp+mPA717KthbI=; b=j+32yX8vCguKOc nsZygmP+uoVPbdpy7w8Iwes3T61/I4UrxhVJBW5t3/DZZb12vi2AGVcc7hQr3+HAtDDRexap67bdk roGnOLAaCb+qk56/Xf6FcozeWp4bNKrLElKlhcHUOUOIfusUjlWEBd9QtcBZi/6E6e38hYbfhwhLz v/CXIK9F/8laE3L9q8VPcW6TH2vKK35oG3Is1LOL00nVZX+IDfqhWZv5Zj9YISDFa5GEXZsiEII8r ygZ6wDononBq0QPbZKk5QY9YW76lQwXbn7Xrh0LhOQIzEH5VaqAkta9UOmExFc+HgYZzAcDlNBgeG P7zDMS9b+oIOpQJ+ljCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUkcl-00FAnU-EQ; Thu, 17 Mar 2022 07:32:43 +0000 Received: from mail-wr1-f47.google.com ([209.85.221.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUkch-00FAlx-OS for linux-arm-kernel@lists.infradead.org; Thu, 17 Mar 2022 07:32:41 +0000 Received: by mail-wr1-f47.google.com with SMTP id h15so6082546wrc.6 for ; Thu, 17 Mar 2022 00:32:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=14b+YRMPF+XicziyqyS1A1J9PGyx9cOE69X038CMxDg=; b=0J5lfJGoflwQn06hdra+ycdBn7VWe1SJMCs+tvo8vdVNxseay8JR/Z8wXqJjDoZqsd lv3cLo9CVBa0cbn/kfO/BhPCrwRR0MLR+jo5ZZcNqMAiuIhA0NJ1U18Z+qK7cTJYyE2Z Jqeumk6gRihQAmkbasM7i5KW+Es0u4pGhC66ZYtLrsl++Hi9w5PjDRRNBfgMwmYYeQZ+ mPXAmYB+zZzH/jL6ZJMlIgsDBCDq3WOA671ArUoUJCnBnar3On2fXpfM0rD8XXsenwrA 3I5XfsAn+euHqagAG0MbtPVdQ8GC5sHSFkY4cJFyl4TfVMOj1CWGR86OvQaDXnzbWvBJ PbTQ== X-Gm-Message-State: AOAM532nvbXsG4DVl5+f18PhIXnqKAqagjAmJlnfKpO5JgBKJ7eB0JB3 EqxvL5Ycer1szYpjfRlxSkM= X-Google-Smtp-Source: ABdhPJwozSkjDXV+DHyksKvHyKhiL5fDQ63iPacCt1TMgZ6CfrYaft+8e49jYXsMOYkMY2oilEVhmA== X-Received: by 2002:a5d:498b:0:b0:203:e5d5:622c with SMTP id r11-20020a5d498b000000b00203e5d5622cmr2724473wrq.153.1647502356995; Thu, 17 Mar 2022 00:32:36 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id k17-20020a05600c1c9100b00386bb6e9c50sm10984171wms.45.2022.03.17.00.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 00:32:36 -0700 (PDT) Message-ID: Date: Thu, 17 Mar 2022 08:32:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: JIVE: fix return value of __setup handler Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: patches@lists.linux.dev, Ben Dooks , Alim Akhtar , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@armlinux.org.uk References: <20220312063609.19362-1-rdunlap@infradead.org> In-Reply-To: <20220312063609.19362-1-rdunlap@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_003239_845176_180817F5 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/03/2022 07:36, Randy Dunlap wrote: > __setup() handlers should return 1 to obsolete_checksetup() in > init/main.c to indicate that the boot option has been handled. > A return of 0 causes the boot option/value to be listed as an Unknown > kernel parameter and added to init's (limited) argument or environment > strings. Also, error return codes don't mean anything to > obsolete_checksetup() -- only non-zero (usually 1) or zero. > So return 1 from jive_mtdset(). > > Fixes: 9db829f485c5 ("[ARM] JIVE: Initial machine support for Logitech Jive") > Signed-off-by: Randy Dunlap > Cc: Ben Dooks > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: patches@armlinux.org.uk > --- > KernelVersion: v5.17-rc7 > > arch/arm/mach-s3c/mach-jive.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > It's too late for upcoming cycle, so I will pick it up after merge window. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel