From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07B38CA101F for ; Wed, 10 Sep 2025 19:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GWRcWK/eFKZhkHxQA5DVWtkvWZI8afVnLk3NgipMAtM=; b=0mTEyE2pryTe9OIZ1VJXn7I+Ym T6muo8Xg9e0Lcw8QYxxmNTbdHZK8m408AVONh6bd/6baxVBdxWruTfGyhH8B5gIlMcyk2S3Fx2XAZ J7PnQJlWdLGPEyy7H3val7/vE7oM5KG8CzrHGxL6J/nBi2j3aYa3t+eGqz/wpe8dAdJUBRDfGMZnc ZMb80SZPF+FQGximiDLn+I4kRRjtPaICtN+b2nY76NyvjtCbB450RmkOjNCtIW/MyjVvlUVmvviwe rc0ew/2+hrQNZwUjlaJUFebvEfQG680si/qIX+hDiWPc0NtQD2SHTrXCuqzWpQITuPVVmQytNe5Z+ b7Yag7oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwQYm-0000000GJjR-3jw0; Wed, 10 Sep 2025 19:32:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwQYk-0000000GJj1-3OdT for linux-arm-kernel@lists.infradead.org; Wed, 10 Sep 2025 19:32:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6B1316F2; Wed, 10 Sep 2025 12:32:41 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE9E33F694; Wed, 10 Sep 2025 12:32:43 -0700 (PDT) Message-ID: Date: Wed, 10 Sep 2025 20:32:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/33] arm_mpam: Add the class and component structures for ris firmware described To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Cc: shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250822153048.2287-1-james.morse@arm.com> <20250822153048.2287-47-james.morse@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250910_123250_978512_AE37606E X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ben, On 29/08/2025 13:41, Ben Horgan wrote: > On 8/22/25 16:30, James Morse wrote: >> An MSC is a container of resources, each identified by their RIS index. >> Some RIS are described by firmware to provide their position in the system. >> Others are discovered when the driver probes the hardware. >> >> To configure a resource it needs to be found by its class, e.g. 'L2'. >> There are two kinds of grouping, a class is a set of components, which >> are visible to user-space as there are likely to be multiple instances >> of the L2 cache. (e.g. one per cluster or package) >> >> struct mpam_components are a set of struct mpam_vmsc. A vMSC groups the >> RIS in an MSC that control the same logical piece of hardware. (e.g. L2). >> This is to allow hardware implementations where two controls are presented >> as different RIS. Re-combining these RIS allows their feature bits to >> be or-ed. This structure is not visible outside mpam_devices.c >> >> struct mpam_vmsc are then a set of struct mpam_msc_ris, which are not >> visible as each L2 cache may be composed of individual slices which need >> to be configured the same as the hardware is not able to distribute the >> configuration. >> >> Add support for creating and destroying these structures. >> >> A gfp is passed as the structures may need creating when a new RIS entry >> is discovered when probing the MSC. >> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c >> index 71a1fb1a9c75..5baf2a8786fb 100644 >> --- a/drivers/resctrl/mpam_devices.c >> +++ b/drivers/resctrl/mpam_devices.c >> @@ -179,7 +650,10 @@ static int update_msc_accessibility(struct mpam_msc *msc) >> cpumask_copy(&msc->accessibility, cpu_possible_mask); >> err = 0; >> } else { >> - if (of_device_is_compatible(parent, "memory")) { >> + if (of_device_is_compatible(parent, "cache")) { >> + err = get_cpumask_from_cache(parent, >> + &msc->accessibility); >> + } else if (of_device_is_compatible(parent, "memory")) { > The determination of the accessibility for the h/w msc doesn't fit with > the subject of this patch. Could this hunk and the supporting functions > be split into a precursor patch? I've moved this bit into the previous patches. Thanks, James