From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D76FEC48BF6 for ; Mon, 26 Feb 2024 23:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xivROR+ppn9gfKLNbstz7kIZ1xX1J+LDPBkVNEP+Ouo=; b=TMsDzTyWy/LaXK x7UnigXtQGAhnb/haSLDlveXzs2tZ75WhnGY/A3RAPkb95/sJ5VR5w5FOfXyzx865Xej8e9HoT2nZ GySqnteJmKNvQV31QdEkWVTXm/Crewf0LHJgc+exuXqnvPx2bKQD1V23LkSQx7iLizVvEw+3fNSvp Ms//aSP0EZ0GtpPU4SmVfzP2WJDNJw6iNyBnU6x0NG4dHLeUQBsw8HBOAGUMZdpLKFWzZqIbqbOds ocNLHN1okZAm6RIqzuiuZlLjQ7PldwDhpr0IVUu6scEfzvhJfCNkdlRar09lLhBpgoO2R44jrZLe1 lbN6K0HHnDz3zb7GWtwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rekiJ-000000031Ie-3o9I; Mon, 26 Feb 2024 23:48:51 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rekiG-000000031Hu-2ppI for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 23:48:50 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1dc0d11d1b7so29084975ad.2 for ; Mon, 26 Feb 2024 15:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708991326; x=1709596126; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=SagLQ4XBLMTETOCPFMWWuB4VsNBtkMPNCTNl4Vlg8BI=; b=W3tC249016lYQK7A58SksTk7WYUU6iNe45QYr+lG8Rl0Si3zsJPIFjdqTk3NTbyUv1 /pFpOplrHms/05J+KyqF9rjLD+LSIAZpbpVTIqTsF7napxQqeipBHFWPcAVK0Lnr6ZmQ I5YHTZfiJwCGWD5vx2ipXsU6+h+4z8zmR8zCJbnZl/hT/vus2QY3VOeX2AdZ3Ggc68Eb QdKnTRHOkdHO39sNcCbM96+JdG8h5K/XQsqUE0NVM1EqhGXCpryh7Tv+DE8VZJS3/eLc 0DMO979CqIG4Uv3Bjyo9T3SRyIPLbOcjnRg4n3yiSKOcI1gIvw8brLEqs62CeoZGwVVx 1OjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708991326; x=1709596126; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SagLQ4XBLMTETOCPFMWWuB4VsNBtkMPNCTNl4Vlg8BI=; b=JGH4DEevgdrBl+VKOLkF+Cao4MCQkA16cpensoNMZFvZZV2lIupyDsaVulUg3bZs6p +t31WdJu1vsy3LuChr21eY1vvIPW9nCGNo6RFaRn74zBUeb+h7bpd2fSWauwrhADBf0u jmKHl0Be6fa0ag3cPGQNxoGgEH1NE/wMWspeYwOuIrNUZ+Y7z+iNTP4eRFw6W5UKLj7S a0fCO1axjBRcy/DtiSHSpQhaIasqAkI/OL2/9TMHdtZ6tmZuDbenytmeehUaDvTFTq71 IcZb9gg9xUnX3ByQ69JP9/U85tnOJK5ORlovQFUDoTcOXNA54mjvyYAYcu6P0AQBk9kx rYRQ== X-Forwarded-Encrypted: i=1; AJvYcCWZVmqAI4zEctTjs8Qjz9a7fTwdrbci2II9lnHDwMfZzLtfycmOds+kVDPnvQ2FJYlwUYgGutuyT3pymGMR00W3pj1xaSsLNXp75rXgNPM36t3MY5s= X-Gm-Message-State: AOJu0YwodFDZ6yW/JtBF6hGLV3Un4xacOTaqLijbSGZR4Yx9QADjqFbE Sq86aZc9bMruJVuRwz3AN7WueKHuRVR22rjwaOwEgIggqMeCMxWZ X-Google-Smtp-Source: AGHT+IEd4JtteGdpz7ZGNlzJpYV8Sd55DLhxeLdzfOyOHpbhNvT8jNk7iGVOOXKUH7CSzEuWaDgQXw== X-Received: by 2002:a17:902:dac1:b0:1dc:af70:8c44 with SMTP id q1-20020a170902dac100b001dcaf708c44mr2799124plx.17.1708991325974; Mon, 26 Feb 2024 15:48:45 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id lc13-20020a170902fa8d00b001d911dd145esm229448plb.219.2024.02.26.15.48.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 15:48:45 -0800 (PST) Message-ID: Date: Mon, 26 Feb 2024 15:48:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests Content-Language: en-US To: Charlie Jenkins , David Laight Cc: 'Russell King' , Christophe Leroy , Palmer Dabbelt , Andrew Morton , Helge Deller , "James E.J. Bottomley" , Parisc List , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Palmer Dabbelt , Linux ARM References: <20240223-fix_sparse_errors_checksum_tests-v10-1-b6a45914b7d8@rivosinc.com> <7ae930a7-3b10-4470-94ee-89cb650b3349@csgroup.eu> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_154848_880961_72CDFFF1 X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/26/24 15:17, Charlie Jenkins wrote: > On Mon, Feb 26, 2024 at 10:33:56PM +0000, David Laight wrote: >> ... >>> I think you misunderstand. "NET_IP_ALIGN offset is what the kernel >>> defines to be supported" is a gross misinterpretation. It is not >>> "defined to be supported" at all. It is the _preferred_ alignment >>> nothing more, nothing less. > > This distinction is arbitrary in practice, but I am open to being proven > wrong if you have data to back up this statement. If the driver chooses > to not follow this, then the driver might not work. ARM defines the > NET_IP_ALIGN to be 2 to pad out the header to be on the supported > alignment. If the driver chooses to pad with one byte instead of 2 > bytes, the driver may fail to work as the CPU may stall after the > misaligned access. > >> >> I'm sure I've seen code that would realign IP headers to a 4 byte >> boundary before processing them - but that might not have been in >> Linux. >> >> I'm also sure there are cpu which will fault double length misaligned >> memory transfers - which might be used to marginally speed up code. >> Assuming more than 4 byte alignment for the IP header is likely >> 'wishful thinking'. >> >> There is plenty of ethernet hardware that can only write frames >> to even boundaries and plenty of cpu that fault misaligned accesses. >> There are even cases of both on the same silicon die. >> >> You also pretty much never want a fault handler to fixup misaligned >> ethernet frames (or really anything else for that matter). >> It is always going to be better to check in the code itself. >> >> x86 has just made people 'sloppy' :-) >> >> David >> >> - >> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK >> Registration No: 1397386 (Wales) >> > > If somebody has a solution they deem to be better, I am happy to change > this test case. Otherwise, I would appreciate a maintainer resolving > this discussion and apply this fix. > Agreed. I do have a couple of patches which add explicit unaligned tests as well as corner case tests (which are intended to trigger as many carry overflows as possible). Once I get those working reliably, I'll be happy to submit them as additional tests. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel