From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F789C61DA4 for ; Tue, 7 Feb 2023 02:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L7ouAUk4wLgwueCozCrwjiPq9wXsd2wHjAYcI/jeRIQ=; b=3i+2EfjW0SYEQ8 KimtqyqNCDSRdaiBl74keHN2XVQmKXRDl2NVpFztoLLNaMaw9UeCCcU6mu2zjr6UclgIgodfjFy6p JbGJKTCSf50Rw0kW5iJa60fqMzUE8AGh4+zqy9PYyul+LvMrFHrBB3JETn18PY8YffsEd2CK9Swvx QANSOBmZPNzu3HNjbz+3FdXRlnvi9LsEk35tNXeJ0Oamrau6UI/TX4G9beGc435qvIUkwg47RAegO AFYINrhD8Qf8sGPNUwUh6n53rBwW4E4V5DvXt19O33wsYZLpLPGjw06gJtaVK1hf8mzARkLqTI2lL 4/B8CMJXaadObFiWPyUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPDGe-00ARHC-R8; Tue, 07 Feb 2023 01:59:33 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPDGa-00ARGE-FV; Tue, 07 Feb 2023 01:59:30 +0000 X-UUID: 0a7f9218a68b11eda08d4d6090ec5a5c-20230206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=EUwFgLpEqQmrs0H/FqJq+UKrZUqLXTUmhm5NeKNvt94=; b=QsMVbN7sjSyV6rY1fZBuQLN/iXj0t7E3lvnJzjqnlh3vydgjHH5gSG7iYbFrfjR1U/u9ZIITdEGbonvnDDzNK3tV+KF3ye8JIj6xFL+9OU+kWuU0EJ893bRwsEoUo1s9HfZeKHjGnTXqqQCCMNZ9RZ1UEnWZY60rMQLsxI4qliA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.19,REQID:a4f15ccb-6eb8-4fa8-bb65-3a5fb6bd82f6,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-INFO: VERSION:1.1.19,REQID:a4f15ccb-6eb8-4fa8-bb65-3a5fb6bd82f6,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:-5 X-CID-META: VersionHash:885ddb2,CLOUDID:e19e7f56-dd49-462e-a4be-2143a3ddc739,B ulkID:230207095849A1ZLQ8NW,BulkQuantity:3,Recheck:0,SF:17|19|102,TC:nil,Co ntent:0,EDM:-3,IP:nil,URL:1,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0,OSI:0,OS A:0,AV:0 X-CID-BVR: 0,NGT X-UUID: 0a7f9218a68b11eda08d4d6090ec5a5c-20230206 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 116687226; Mon, 06 Feb 2023 18:59:22 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Tue, 7 Feb 2023 09:58:45 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 7 Feb 2023 09:58:45 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lget8qBeTcSLL5M8HfY5F+8b0cy9DdNdYEoPVQluc8VXC4kGsAVdYGuvWcpGyxdZj7FGTUgOTpuxaAQlzaxvKkn5rbwa4m2t97nhJP9tMYjFNK5pQ8Y5hOoy4RV2Mv6QfCC3wIfqUzMqqQBWvWGK36+OJ4e0J879wyPhiCkj6IEuO+WORSTe3k9d0Xo9y/4zD3tcdhAUQaoX0uWA43EGEceXr3vuZvUnW0JmTzTz80MD5peAaHhvVPQL/W/UScpWcpwnBGPJT+gPIuvNyuxCtKQ63/iLT056hct1KpszNKmIUOdCgg3h86uBQ1iZDn8iYn62TPJndQPmLLKteVmXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EUwFgLpEqQmrs0H/FqJq+UKrZUqLXTUmhm5NeKNvt94=; b=NWfWsSNUZVEyfzKdQsjubni+vsqpwDXPcrTr+L1X5xXPQC5voIaBRqtX1SBaLtX3rBJrlfKA27qedkP7NxiWvPjLMavOfhFSNDR6PI+yzAHvCAwUmIox1xS4kTVVg56ZSmpmjNSeBnMvcgx92bmsZhmaxjB2N9APOfWqhnkJEFMKV/Irj7bTq0iI0IEMiwYrFtLWVStWKHIKOMjD2Bluz4LsOH4veyk2riO8DmOj5VzchJPl5h5s0YTZEAgt/mYJ3I29k9GQoFLzKUBE9aFrsZC2L95Cxg2msjKfCu5O7RCJ5q0TyyQqP1oSjDCHuyLsEcGRdQlhxR7iEBAZeOyKTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EUwFgLpEqQmrs0H/FqJq+UKrZUqLXTUmhm5NeKNvt94=; b=McsR5gXImHFMsKW0xhfhM5KNdSLwsPiBuT1l/OEHU/0yoWJcXfbmwY9zsTBSCVfY+CVhJuir1s7AFdXbk8wrByocQ5xYEOpYnuPGXg+Bli+ikC5nJBpgSPTvBbrkGH+r86168cRe9ItKUfWWOLaZkMngZrsnv5hE7W/m5kjqxJs= Received: from TY0PR03MB6356.apcprd03.prod.outlook.com (2603:1096:400:14c::9) by SEZPR03MB6812.apcprd03.prod.outlook.com (2603:1096:101:67::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Tue, 7 Feb 2023 01:58:42 +0000 Received: from TY0PR03MB6356.apcprd03.prod.outlook.com ([fe80::ba47:a392:dffd:355f]) by TY0PR03MB6356.apcprd03.prod.outlook.com ([fe80::ba47:a392:dffd:355f%7]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 01:58:42 +0000 From: =?utf-8?B?TW91ZHkgSG8gKOS9leWul+WOnyk=?= To: "wenst@chromium.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mturquette@baylibre.com" , "devicetree@vger.kernel.org" , "sboyd@kernel.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v6 3/4] clk: mediatek: remove MT8195 vppsys/0/1 simple_probe Thread-Topic: [PATCH v6 3/4] clk: mediatek: remove MT8195 vppsys/0/1 simple_probe Thread-Index: AQHZKussAIBNhMuL60+kgFdojuoEW664XPSAgAp8nIA= Date: Tue, 7 Feb 2023 01:58:42 +0000 Message-ID: References: <20230118031509.29834-1-moudy.ho@mediatek.com> <20230118031509.29834-4-moudy.ho@mediatek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY0PR03MB6356:EE_|SEZPR03MB6812:EE_ x-ms-office365-filtering-correlation-id: f59efe7a-f656-4fea-1877-08db08aed708 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XQvSUv79HKX9QzRsPVCPPKfIPlytrsnxRbbdomIS0Ycmaj2aP7+s+pVbsIDxQWQv97OVAqKbT7wSBjasLFk/GPgmo93q5Z8c/gZrU3tbMBaqduobp8ikFckXaKRxaXTfYE8QcCCWkncKUTQDVZMsBkQp4zXuJZ9l5Q/71zaaHo5P77VaLxUVIb574wFarm1LzfyO/g/VLpjNrWyvCDzwkAk5hXWJExZ2gSO7mzMTFg4yBRok1Iipw6menwcXQtnTNvD23IDgNNrSCDJADqn0pG4szicWSGxj5hTA+hCeKec15C4zBbQ09w71+zt8imWBpo4RPLmtDYRUrLWCtYqGLDcaBR54XOTK2g11OvAZ86pEqhqLUTL5MfwOAkxxF79UQ9ywjuk6thi/45TkeBOculnq/zlKrFF0SAJ+PSbh9UMRW7mvQMeJTOhq09z9hPS7cBaCVl9WpGtKGeh2dWpWMxUXnFu1pPKskRqPNfok2E81EbnqqsIl33kUEW6FtuaDR0orRSf0r/D/N0ailzjWHXBI8kAcap370tebaQr1hifXDRDX2zP+f3VA/ikyDOZP1RFz11478lKK7Txytn+OZI89I2r5Wx+3S3Cp1H69mHLE1uwc6+SfKo7gAk9i2NkIO5F9P4jOoL9jU95NspR5YVlhjCh+c7/PF6vYDW9H5ipzPKkYDVRoWRilmaUdVPSK0igyUKCxUxzcYi/1+UnLYOChMb+Fv2ggjnQ51cCFiXiZ7CgOp1IpLFKKf7NpYhObOPrNtm8sriu2Imuo9BRjn33VvGBe6VQUQrt+NbD6IBsajP9CEReiVz02y8Z3i9oH x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY0PR03MB6356.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(451199018)(8676002)(4326008)(66556008)(6916009)(66446008)(76116006)(8936002)(41300700001)(64756008)(54906003)(122000001)(85182001)(38070700005)(36756003)(316002)(86362001)(38100700002)(26005)(6506007)(6512007)(186003)(66476007)(6486002)(966005)(53546011)(5660300002)(66946007)(478600001)(7416002)(71200400001)(2906002)(83380400001)(2616005)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T0licFNDb2pNVkxxMnF5blVhaDVUVi8zaytWMzdtQm4zWWN5Sm4rODRCVkJz?= =?utf-8?B?dzBqdDVPek9uV1dxQU9yWTFMdjZxNGhYeVJ1ZFhqMVV3ZHBuZFFBR2d0alQz?= =?utf-8?B?SmJrVDFsOWh0QTcwV2dyRmxJdFRGckJuZjRCM1lnWVpEY29wSU41Yi9OdWZ2?= =?utf-8?B?OWNDdUJtaG9BTEJzdnJLZVphU1Z3ZEdKQ2tTd1ZabmpqU3hpSjM4WXpLc0Yr?= =?utf-8?B?RXh3ZWV1dHliZzlyRitPTEV1RXRlOXV2OXpjM2FadVZNWXE3MlUvUDNoMEFB?= =?utf-8?B?VnZLb0h4UjhnZ3VNZm9LU28vQkNqS1JsNHZNT1RCZ1phQlFSZzByWnZZVGVh?= =?utf-8?B?K3lmaFFTSHFyc0d4MjVhV0d6T1NkMXhaV0orVFhJRFplRlgyczFoTHl6d0NJ?= =?utf-8?B?S0dmbGhibkZQNlBEMnZ3ZTZ4bndXdjFNWmw1SUpOd0pLdXNwQm1sM0FFV0xG?= =?utf-8?B?SDFjNURmL2ljSzd3NmFhSHZGcmtuRjMvd0xsNG1RRWMvQjgyeld6bDI5OGxa?= =?utf-8?B?Qyt1SFRReG9xc0ZtakM1bkZ2dDRHOTlLNmJCczVNckVOaXRZVGdUM1pSVlFv?= =?utf-8?B?aFhzbE9uQjJYRHQ1dHdjY1FTMzEzWGRnaE8xbmJ0b2V3ZWNPV3c2c1ZxVmlD?= =?utf-8?B?VEl1aksxbUdKRUlsc2s3cDI5RUJCZDZxZ0ZvSFcyRFA3by95blUyMVFqcUZO?= =?utf-8?B?alE5V2k5N21yc2VSZVJmSWJtWHJJdmw2STV1cGt0c3c1RXhOQUxkTUlhUjQ4?= =?utf-8?B?SFltcmJEUG1VRmR5Nk5UaktSSUZDZEcxNXR5N1Rpakkrc0pkRjlSTWMyRksx?= =?utf-8?B?TTh2QTdweHNxMWE5cUxlZjNEOTFUVjBmNWtYdE05OUU3N1pNaUNYRkdJK1d1?= =?utf-8?B?cUMvMDU3ekVlNk5jVWdVdEM3UTNQTUhRdE8wdXJYME8xRit5alRRV0p0cXU3?= =?utf-8?B?QW5BN0ozSlFoQXRRVlQreURhbnhXWXJEbHhoTU9WMkgvdVhaSUlBMGNXL1FG?= =?utf-8?B?RW1DM3VHaUpEMkU3bXBCbkxxeExqRkxhZ0lYSFR3NUg1cWUyaVBobEQyUmFG?= =?utf-8?B?c1c3aU1LNDZKTGdxdU9ZT2lxMnJFTEtMSUU0REFidi92Sk0zUUIwam9PTDNo?= =?utf-8?B?U3dZWjRXaDVyaFFYeTE2U0tOREVodS9GamFOR3BBalFCUjlmT01JTUN3Y1RB?= =?utf-8?B?WngzaGloeTNFdzQrSm1kN3R2aTNSd2JuK0xmdkRDMC8ycWh5T1F5dDdkZHlU?= =?utf-8?B?VytvbUhBL0tIMHpuYm9ubnBuRG9FODVhTXlEa3pXL0IxQTNXUXJDSE9LQU8x?= =?utf-8?B?cHNTYjlLZWthdGdzbXhwWndlTURXMkt6aHhrUy9ycUFzRjRxTFQ0bEJJcCtR?= =?utf-8?B?Q0F1cFZQZUptNjhHQ2VCazJOdC9Ib1RwTk1CdXRneENhbENSYlNaTjN2VU0w?= =?utf-8?B?UDdnZ002V29QQ29VUkFmaGUyZXJTYWZuNGJkL2IxWjZXUCsyNFk5TGxSdHBY?= =?utf-8?B?MnpiN3ozbkcvci95QnY4WFphcHpERFVRcWlZOUJCWWMxczRGb1N6L3ZKdXhV?= =?utf-8?B?QjdYc1VEQU9Xa2lMQTBpdmpGTWlOTGdxYWFJcTIwcFQ2NElRYjEwYUFGRkRw?= =?utf-8?B?K0ZUR2N3cjE2VHFSM0k3M2l4VFhTQ01yUEw5ZGVOVTlMd0pTSUJBL3hIcVlR?= =?utf-8?B?aEk1VWluZ2hqam83SFlvL1pETTNiSDFBUFh1UGFMeTF0dlZkWENrLzg0a3J6?= =?utf-8?B?UXpZanlDVVpZckdOUWFMQ1JncVViMCsxUEc3b2VLSHZ2TERGbVVYUUVyaXhO?= =?utf-8?B?czVocUQ4djB3b3BNU2JQeUxPVTRFcUlFQVhpY3IxQWtUZWRRM05jbjdkY0Zj?= =?utf-8?B?UGovZ3d0UG5GdFdOcmNiTWpodERicjB6eHNKVTN1NDFVRHhyWi91SGs4NFhI?= =?utf-8?B?NDZjbzJvSnRQbnlBTjBmemtpQjF1V2FhdTlIcElIUEtGTGhWUHRxL0EzcGRo?= =?utf-8?B?NUdiVkIyd2IzT3VPdGtXeGo1OThOaGlEazZNa3ZVbUxKN2k3UDlXSjQ5alpo?= =?utf-8?B?RCttMEZVTm4zc2Y1TUtqQlJ6dENZQ3h0aTFIUnVBaGNOZlZzQzVOUldsU1VU?= =?utf-8?B?SExMVHRtZ3haSGx0RDcrd0xIY090YVp2Ym53aDU1MjJ2d1dNRjZ3aGwzdTdG?= =?utf-8?B?OGc9PQ==?= Content-ID: <71F28F171B1C3741ACCFA6928D64D1DE@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY0PR03MB6356.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f59efe7a-f656-4fea-1877-08db08aed708 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 01:58:42.7864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mcbk8au9s2ibsLUJa2qPupBhIsIvwMF7P5FXGQHkShzesU55FhKsHu7UNE+l4plO6niKmTtxM1M87vVepeaWfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB6812 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_175928_552545_F90C9D37 X-CRM114-Status: GOOD ( 23.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2023-01-31 at 17:50 +0800, Chen-Yu Tsai wrote: > On Wed, Jan 18, 2023 at 11:16 AM Moudy Ho > wrote: > > > > MT8195 VPPSYS0/1 will be probed by the compatible name in > > the mtk-mmsys driver and then probe its own clock driver as > > a platform driver. > > > > Signed-off-by: Moudy Ho > > --- > > drivers/clk/mediatek/clk-mt8195-vpp0.c | 58 +++++++++++++++++++--- > > ---- > > drivers/clk/mediatek/clk-mt8195-vpp1.c | 58 +++++++++++++++++++--- > > ---- > > 2 files changed, 86 insertions(+), 30 deletions(-) > > > > diff --git a/drivers/clk/mediatek/clk-mt8195-vpp0.c > > b/drivers/clk/mediatek/clk-mt8195-vpp0.c > > index bf2939c3a023..6d5800f69f6c 100644 > > --- a/drivers/clk/mediatek/clk-mt8195-vpp0.c > > +++ b/drivers/clk/mediatek/clk-mt8195-vpp0.c > > @@ -86,26 +86,54 @@ static const struct mtk_gate vpp0_clks[] = { > > GATE_VPP0_2(CLK_VPP0_WARP1_MDP_DL_ASYNC, > > "vpp0_warp1_mdp_dl_async", "top_wpe_vpp", 3), > > }; > > > > -static const struct mtk_clk_desc vpp0_desc = { > > - .clks = vpp0_clks, > > - .num_clks = ARRAY_SIZE(vpp0_clks), > > -}; > > +static int clk_mt8195_vpp0_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *node = dev->parent->of_node; > > + struct clk_onecell_data *clk_data; > > mtk_alloc_clk_data() API changed a couple releases back. So: > > struct clk_hw_onecell_data > > > + int r; > > > > -static const struct of_device_id of_match_clk_mt8195_vpp0[] = { > > - { > > - .compatible = "mediatek,mt8195-vppsys0", > > - .data = &vpp0_desc, > > - }, { > > - /* sentinel */ > > - } > > -}; > > + clk_data = mtk_alloc_clk_data(CLK_VPP0_NR_CLK); > > + if (!clk_data) > > + return -ENOMEM; > > + > > + r = mtk_clk_register_gates(node, vpp0_clks, > > ARRAY_SIZE(vpp0_clks), clk_data); > > API changed. > > > + if (r) > > + goto free_vpp0_data; > > + > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, > > clk_data); > > of_clk_add_provider(node, of_clk_hw_onecell_get, > clk_data); > > Same for the other driver. > > > ChenYu > Hi ChenYu, Thanks for taking the time, could you please take a look at the v7? https://lore.kernel.org/lkml/20230207014800.7619-1-moudy.ho@mediatek.com/ Regards, Moudy > > + if (r) > > + goto unregister_gates; > > + > > + platform_set_drvdata(pdev, clk_data); > > + > > + return r; > > + > > +unregister_gates: > > + mtk_clk_unregister_gates(vpp0_clks, ARRAY_SIZE(vpp0_clks), > > clk_data); > > +free_vpp0_data: > > + mtk_free_clk_data(clk_data); > > + return r; > > +} > > + > > +static int clk_mt8195_vpp0_remove(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *node = dev->parent->of_node; > > + struct clk_hw_onecell_data *clk_data = > > platform_get_drvdata(pdev); > > + > > + of_clk_del_provider(node); > > + mtk_clk_unregister_gates(vpp0_clks, ARRAY_SIZE(vpp0_clks), > > clk_data); > > + mtk_free_clk_data(clk_data); > > + > > + return 0; > > +} > > > > static struct platform_driver clk_mt8195_vpp0_drv = { > > - .probe = mtk_clk_simple_probe, > > - .remove = mtk_clk_simple_remove, > > + .probe = clk_mt8195_vpp0_probe, > > + .remove = clk_mt8195_vpp0_remove, > > .driver = { > > .name = "clk-mt8195-vpp0", > > - .of_match_table = of_match_clk_mt8195_vpp0, > > }, > > }; > > builtin_platform_driver(clk_mt8195_vpp0_drv); > > diff --git a/drivers/clk/mediatek/clk-mt8195-vpp1.c > > b/drivers/clk/mediatek/clk-mt8195-vpp1.c > > index ffd52c762890..3b88c69e96c9 100644 > > --- a/drivers/clk/mediatek/clk-mt8195-vpp1.c > > +++ b/drivers/clk/mediatek/clk-mt8195-vpp1.c > > @@ -84,26 +84,54 @@ static const struct mtk_gate vpp1_clks[] = { > > GATE_VPP1_1(CLK_VPP1_VPP_SPLIT_26M, "vpp1_vpp_split_26m", > > "clk26m", 26), > > }; > > > > -static const struct mtk_clk_desc vpp1_desc = { > > - .clks = vpp1_clks, > > - .num_clks = ARRAY_SIZE(vpp1_clks), > > -}; > > +static int clk_mt8195_vpp1_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *node = dev->parent->of_node; > > + struct clk_onecell_data *clk_data; > > + int r; > > > > -static const struct of_device_id of_match_clk_mt8195_vpp1[] = { > > - { > > - .compatible = "mediatek,mt8195-vppsys1", > > - .data = &vpp1_desc, > > - }, { > > - /* sentinel */ > > - } > > -}; > > + clk_data = mtk_alloc_clk_data(CLK_VPP1_NR_CLK); > > + if (!clk_data) > > + return -ENOMEM; > > + > > + r = mtk_clk_register_gates(node, vpp1_clks, > > ARRAY_SIZE(vpp1_clks), clk_data); > > + if (r) > > + goto free_vpp1_data; > > + > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, > > clk_data); > > + if (r) > > + goto unregister_gates; > > + > > + platform_set_drvdata(pdev, clk_data); > > + > > + return r; > > + > > +unregister_gates: > > + mtk_clk_unregister_gates(vpp1_clks, ARRAY_SIZE(vpp1_clks), > > clk_data); > > +free_vpp1_data: > > + mtk_free_clk_data(clk_data); > > + return r; > > +} > > + > > +static int clk_mt8195_vpp1_remove(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *node = dev->parent->of_node; > > + struct clk_hw_onecell_data *clk_data = > > platform_get_drvdata(pdev); > > + > > + of_clk_del_provider(node); > > + mtk_clk_unregister_gates(vpp1_clks, ARRAY_SIZE(vpp1_clks), > > clk_data); > > + mtk_free_clk_data(clk_data); > > + > > + return 0; > > +} > > > > static struct platform_driver clk_mt8195_vpp1_drv = { > > - .probe = mtk_clk_simple_probe, > > - .remove = mtk_clk_simple_remove, > > + .probe = clk_mt8195_vpp1_probe, > > + .remove = clk_mt8195_vpp1_remove, > > .driver = { > > .name = "clk-mt8195-vpp1", > > - .of_match_table = of_match_clk_mt8195_vpp1, > > }, > > }; > > builtin_platform_driver(clk_mt8195_vpp1_drv); > > -- > > 2.18.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel