From mboxrd@z Thu Jan 1 00:00:00 1970 From: bhuvanchandra.dv@toradex.com (Bhhuvanchandra DV) Date: Tue, 14 Jun 2016 00:18:19 +0000 Subject: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume In-Reply-To: <20160611140341.GT20243@tiger> References: <20160609151039.20817-1-bhuvanchandra.dv@toradex.com> <20160609151039.20817-3-bhuvanchandra.dv@toradex.com> <20160611140341.GT20243@tiger> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Shawn, On 06/11/2016 02:03 PM, Shawn Guo wrote: > On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote: >> From: Stefan Agner >> >> In order to allow wake support in STOP sleep mode, clocks are >> needed. Use imx_clk_gate2_cgr to disable automatic clock gating >> in low power mode STOP. This allows to enable wake by UART using: >> echo enabled > /sys/class/tty/ttyLP0/power/wakeup >> >> However, if wake is not enabled, the driver should disable the >> clocks explicitly to save power. >> >> Signed-off-by: Stefan Agner >> --- >> drivers/clk/imx/clk-vf610.c | 12 ++++++------ > Please send clock driver changes in a separate patch. How about splitting this patchset to two? few patches are having minor fixes and the few patches might need some review and discussions. May be some thing like DMA fixes and the other minor fixes. -- Bhuvan > > Shawn > >> drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++-- >> 2 files changed, 20 insertions(+), 8 deletions(-)