[PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Uwe Kleine-König]

My earlier commit reworking how driver data is tracked added a new
member to struct samsung_pwm_chip but failed to add matching
documentation. Make up leeway.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310130404.uQ33q5Dk-lkp@intel.com/
Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-samsung.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index c437fab7ded8..42f8587087fb 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -77,6 +77,7 @@ struct samsung_pwm_channel {
  * @base_clk:		base clock used to drive the timers
  * @tclk0:		external clock 0 (can be ERR_PTR if not present)
  * @tclk1:		external clock 1 (can be ERR_PTR if not present)
+ * @channel:		per channel driver data
  */
 struct samsung_pwm_chip {
 	struct pwm_chip chip;

base-commit: 4c9548d24c0d4034f056e2c9f0e72599a382a846
-- 
2.42.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]

Hello Thierry,

On Thu, Oct 12, 2023 at 11:02:29PM +0200, Uwe Kleine-König wrote:
> My earlier commit reworking how driver data is tracked added a new
> member to struct samsung_pwm_chip but failed to add matching
> documentation. Make up leeway.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310130404.uQ33q5Dk-lkp@intel.com/
> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

I forgot to mention: Feel free to squash this into 4c9548d24c0d. I guess
you have to rewrite your for-next anyhow as the commits you took from my
PR and rebased on your for-next lack your S-o-b.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Thierry Reding]

On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
> My earlier commit reworking how driver data is tracked added a new
> member to struct samsung_pwm_chip but failed to add matching
> documentation. Make up leeway.
> 
> 

Applied, thanks!

[1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
      commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595

Best regards,
-- 
Thierry Reding <thierry.reding@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 655 bytes --]

On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
> > Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
> 
> Applied, thanks!
> 
> [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
>       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595

You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
rewrote your for-next branch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 985 bytes --]

Hello,

On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-König wrote:
> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
> > On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
> > > Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
> > 
> > Applied, thanks!
> > 
> > [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
> >       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595
> 
> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
> rewrote your for-next branch.

This is still open. I wonder there is no automated check that warns if
there is a Fixes: line in next that doesn't refer to an ancestor.

Would be great to get this fixed before sending out the PR for the next
merge window.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Krzysztof Kozlowski]

On 24/10/2023 16:55, Uwe Kleine-König wrote:
> Hello,
> 
> On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-König wrote:
>> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
>>> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
>>>> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
>>>
>>> Applied, thanks!
>>>
>>> [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
>>>       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595
>>
>> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
>> rewrote your for-next branch.
> 
> This is still open. I wonder there is no automated check that warns if
> there is a Fixes: line in next that doesn't refer to an ancestor.

I am using Greg's/Stephen's scripts in commit hooks:
https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit
https://github.com/krzk/tools/blob/master/linux/verify_fixes.sh

Happy to receive more ideas during:
https://lpc.events/event/17/contributions/1498/

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 2319 bytes --]

On Tue, Oct 24, 2023 at 04:58:22PM +0200, Krzysztof Kozlowski wrote:
> On 24/10/2023 16:55, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-König wrote:
> >> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
> >>> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
> >>>> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
> >>>
> >>> Applied, thanks!
> >>>
> >>> [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
> >>>       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595
> >>
> >> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
> >> rewrote your for-next branch.
> > 
> > This is still open. I wonder there is no automated check that warns if
> > there is a Fixes: line in next that doesn't refer to an ancestor.
> 
> I am using Greg's/Stephen's scripts in commit hooks:
> https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit
> https://github.com/krzk/tools/blob/master/linux/verify_fixes.sh

Skimming throud the verify_fixes script I'd say the following addition
to verify_fixes should do:

diff --git a/linux/verify_fixes.sh b/linux/verify_fixes.sh
index f22384bb6bb8..12e73da82dd4 100755
--- a/linux/verify_fixes.sh
+++ b/linux/verify_fixes.sh
@@ -100,6 +100,13 @@ verify_fixes()
 				continue
 			fi
 
+			if ! git merge-base --is-ancestor "$sha" "$c"; then
+				printf '%s%s\t\t- %s\n' "$commit_msg" "$fixes_msg" 'Target SHA should be an ancestor of your tree'
+				commit_msg=''
+				error=1
+				continue
+			fi
+
 			if [ "${#sha}" -lt 12 ]; then
 				msg="${msg:+${msg}${nl}}${tab}${tab}- SHA1 should be at least 12 digits long${nl}${tab}${tab}  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11${nl}${tab}${tab}  or later) just making sure it is not set (or set to \"auto\")."
 			fi

It has quite a few hits in next ...

> Happy to receive more ideas during:
> https://lpc.events/event/17/contributions/1498/

I hope you pick up this idea even without me repeating this suggestion
there :-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Krzysztof Kozlowski]

On 24/10/2023 18:46, Uwe Kleine-König wrote:
> On Tue, Oct 24, 2023 at 04:58:22PM +0200, Krzysztof Kozlowski wrote:
>> On 24/10/2023 16:55, Uwe Kleine-König wrote:
>>> Hello,
>>>
>>> On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-König wrote:
>>>> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
>>>>> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
>>>>>> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
>>>>>
>>>>> Applied, thanks!
>>>>>
>>>>> [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
>>>>>       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595
>>>>
>>>> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
>>>> rewrote your for-next branch.
>>>
>>> This is still open. I wonder there is no automated check that warns if
>>> there is a Fixes: line in next that doesn't refer to an ancestor.
>>
>> I am using Greg's/Stephen's scripts in commit hooks:
>> https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit
>> https://github.com/krzk/tools/blob/master/linux/verify_fixes.sh
> 
> Skimming throud the verify_fixes script I'd say the following addition
> to verify_fixes should do:
> 
> diff --git a/linux/verify_fixes.sh b/linux/verify_fixes.sh
> index f22384bb6bb8..12e73da82dd4 100755
> --- a/linux/verify_fixes.sh
> +++ b/linux/verify_fixes.sh
> @@ -100,6 +100,13 @@ verify_fixes()
>  				continue
>  			fi
>  
> +			if ! git merge-base --is-ancestor "$sha" "$c"; then
> +				printf '%s%s\t\t- %s\n' "$commit_msg" "$fixes_msg" 'Target SHA should be an ancestor of your tree'
> +				commit_msg=''
> +				error=1
> +				continue
> +			fi
> +
>  			if [ "${#sha}" -lt 12 ]; then
>  				msg="${msg:+${msg}${nl}}${tab}${tab}- SHA1 should be at least 12 digits long${nl}${tab}${tab}  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11${nl}${tab}${tab}  or later) just making sure it is not set (or set to \"auto\")."
>  			fi

Oh, thanks! It makes sense.

> 
> It has quite a few hits in next ...
> 
>> Happy to receive more ideas during:
>> https://lpc.events/event/17/contributions/1498/
> 
> I hope you pick up this idea even without me repeating this suggestion
> there :-)
> 
Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Krzysztof Kozlowski]

On 24/10/2023 18:46, Uwe Kleine-König wrote:
> On Tue, Oct 24, 2023 at 04:58:22PM +0200, Krzysztof Kozlowski wrote:
>> On 24/10/2023 16:55, Uwe Kleine-König wrote:
>>> Hello,
>>>
>>> On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-König wrote:
>>>> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
>>>>> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
>>>>>> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
>>>>>
>>>>> Applied, thanks!
>>>>>
>>>>> [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
>>>>>       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595
>>>>
>>>> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
>>>> rewrote your for-next branch.
>>>
>>> This is still open. I wonder there is no automated check that warns if
>>> there is a Fixes: line in next that doesn't refer to an ancestor.
>>
>> I am using Greg's/Stephen's scripts in commit hooks:
>> https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit
>> https://github.com/krzk/tools/blob/master/linux/verify_fixes.sh
> 
> Skimming throud the verify_fixes script I'd say the following addition
> to verify_fixes should do:
> 
> diff --git a/linux/verify_fixes.sh b/linux/verify_fixes.sh
> index f22384bb6bb8..12e73da82dd4 100755
> --- a/linux/verify_fixes.sh
> +++ b/linux/verify_fixes.sh
> @@ -100,6 +100,13 @@ verify_fixes()
>  				continue
>  			fi
>  
> +			if ! git merge-base --is-ancestor "$sha" "$c"; then
> +				printf '%s%s\t\t- %s\n' "$commit_msg" "$fixes_msg" 'Target SHA should be an ancestor of your tree'
> +				commit_msg=''
> +				error=1
> +				continue
> +			fi
> +
>  			if [ "${#sha}" -lt 12 ]; then
>  				msg="${msg:+${msg}${nl}}${tab}${tab}- SHA1 should be at least 12 digits long${nl}${tab}${tab}  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11${nl}${tab}${tab}  or later) just making sure it is not set (or set to \"auto\")."
>  			fi
> 

Thanks Uwe for the snippet. I went further and it allowed to simplify
checking for commit in Linus' tree.

Cc, Greg, Stephen,
Maybe you will find it useful to update your scripts as well (I forked
from yours):
https://github.com/krzk/tools/commit/39d2c71a72f5d4f30d0752e45b9bcc09b75b5026

https://github.com/krzk/tools/commit/0061331501fac2f4b24709adb0ec5cf267bcb661#diff-0100377e067a4cd4cb89c0f0ae8732d3e814ed25e816a392bf2e0855a392adbcL11

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip

[Greg Kroah-Hartman]

On Sun, Oct 29, 2023 at 12:07:02PM +0100, Krzysztof Kozlowski wrote:
> On 24/10/2023 18:46, Uwe Kleine-König wrote:
> > On Tue, Oct 24, 2023 at 04:58:22PM +0200, Krzysztof Kozlowski wrote:
> >> On 24/10/2023 16:55, Uwe Kleine-König wrote:
> >>> Hello,
> >>>
> >>> On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-König wrote:
> >>>> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote:
> >>>>> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-König wrote:
> >>>>>> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driver data")
> >>>>>
> >>>>> Applied, thanks!
> >>>>>
> >>>>> [1/1] pwm: samsung: Document new member .channel in struct samsung_pwm_chip
> >>>>>       commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595
> >>>>
> >>>> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you
> >>>> rewrote your for-next branch.
> >>>
> >>> This is still open. I wonder there is no automated check that warns if
> >>> there is a Fixes: line in next that doesn't refer to an ancestor.
> >>
> >> I am using Greg's/Stephen's scripts in commit hooks:
> >> https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit
> >> https://github.com/krzk/tools/blob/master/linux/verify_fixes.sh
> > 
> > Skimming throud the verify_fixes script I'd say the following addition
> > to verify_fixes should do:
> > 
> > diff --git a/linux/verify_fixes.sh b/linux/verify_fixes.sh
> > index f22384bb6bb8..12e73da82dd4 100755
> > --- a/linux/verify_fixes.sh
> > +++ b/linux/verify_fixes.sh
> > @@ -100,6 +100,13 @@ verify_fixes()
> >  				continue
> >  			fi
> >  
> > +			if ! git merge-base --is-ancestor "$sha" "$c"; then
> > +				printf '%s%s\t\t- %s\n' "$commit_msg" "$fixes_msg" 'Target SHA should be an ancestor of your tree'
> > +				commit_msg=''
> > +				error=1
> > +				continue
> > +			fi
> > +
> >  			if [ "${#sha}" -lt 12 ]; then
> >  				msg="${msg:+${msg}${nl}}${tab}${tab}- SHA1 should be at least 12 digits long${nl}${tab}${tab}  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11${nl}${tab}${tab}  or later) just making sure it is not set (or set to \"auto\")."
> >  			fi
> > 
> 
> Thanks Uwe for the snippet. I went further and it allowed to simplify
> checking for commit in Linus' tree.
> 
> Cc, Greg, Stephen,
> Maybe you will find it useful to update your scripts as well (I forked
> from yours):
> https://github.com/krzk/tools/commit/39d2c71a72f5d4f30d0752e45b9bcc09b75b5026
> 
> https://github.com/krzk/tools/commit/0061331501fac2f4b24709adb0ec5cf267bcb661#diff-0100377e067a4cd4cb89c0f0ae8732d3e814ed25e816a392bf2e0855a392adbcL11

Thanks, I've applied this to my tree, let's see how it works out.

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel