From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46661C2BB1D for ; Fri, 13 Mar 2020 12:01:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16712206FA for ; Fri, 13 Mar 2020 12:01:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="THkirkso" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16712206FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uZJC7QicHwzhyExC/s3nFxjIh67kNR1Sk3ohrtzImys=; b=THkirksoN/g52d LfZJlrBYYNOQeykslpcC06SbwBe73ieJQ5ILzau2kCFnDiMm9DdDzzLVIpkP++SiZoZaTnKB7k0Tw ndANaDs7IuHSxWY+5NMPXpYovOd1dg9TQB2/27BBZ2/Swir7c74nqwsNw8s0+hC+3AxfEiXt6570v oaPdp15bwdSVK+ekhbYWzmY3rZkfNjY8p8iUiwYTU/Cn5VDbselNY7SyXCypBomD0iwkgoH7NjCM3 ksYP66zemwiD9q3d7EnmAaUQeX253xAxi2/pgFS+xWBmDM8l6/p0WlhjCJvOBvdGSXN3B7I9ug7Ha ER+iEcC1cWGsD0bOYySA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCj0Y-0000tv-Ik; Fri, 13 Mar 2020 12:01:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCj0V-0000t9-Fi for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 12:01:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6AEFFEC; Fri, 13 Mar 2020 05:01:35 -0700 (PDT) Received: from [10.37.12.218] (unknown [10.37.12.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9F7A3F534; Fri, 13 Mar 2020 05:01:31 -0700 (PDT) Subject: Re: [PATCH v2 20/20] arm64: vdso32: Enable Clang Compilation To: Nathan Chancellor References: <20200306133242.26279-1-vincenzo.frascino@arm.com> <20200306133242.26279-21-vincenzo.frascino@arm.com> <20200310014039.GA12211@ubuntu-m2-xlarge-x86> From: Vincenzo Frascino Message-ID: Date: Fri, 13 Mar 2020 12:01:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200310014039.GA12211@ubuntu-m2-xlarge-x86> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_050139_613384_71FFB50F X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/10/20 1:40 AM, Nathan Chancellor wrote: > On Fri, Mar 06, 2020 at 01:32:42PM +0000, Vincenzo Frascino wrote: >> Enable Clang Compilation for the vdso32 library. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Signed-off-by: Vincenzo Frascino >> --- >> arch/arm64/kernel/vdso32/Makefile | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile >> index 04df57b43cb1..650cfc5757eb 100644 >> --- a/arch/arm64/kernel/vdso32/Makefile >> +++ b/arch/arm64/kernel/vdso32/Makefile >> @@ -10,7 +10,18 @@ include $(srctree)/lib/vdso/Makefile >> >> # Same as cc-*option, but using CC_COMPAT instead of CC >> ifeq ($(CONFIG_CC_IS_CLANG), y) >> -CC_COMPAT ?= $(CC) >> +COMPAT_GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE_COMPAT)elfedit)) >> +COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) >> + >> +CLANG_CC_COMPAT := $(CC) >> +CLANG_CC_COMPAT += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) >> +CLANG_CC_COMPAT += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) >> +CLANG_CC_COMPAT += -no-integrated-as -Qunused-arguments >> +ifneq ($(COMPAT_GCC_TOOLCHAIN),) >> +CLANG_CC_COMPAT += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) >> +endif >> + >> +CC_COMPAT ?= $(CLANG_CC_COMPAT) >> else >> CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc >> endif >> -- >> 2.25.1 >> > If CC_COMPAT is ever specified on the command line as clang (maybe by > some unsuspecting user), we'd loose all of the above flags. Maybe it > would be better to build a set of COMPAT_CLANG_FLAGS and append them to > CC_COMPAT, maybe like below? > Fine by me. > Regardless, the current approach works in my testing with clang 9.0.1 > and master (clang 11.0.0). This patch specifically is: > Good to hear. I will add your tags to the patch. > Reviewed-by: Nathan Chancellor > Tested-by: Nathan Chancellor # build > > ================================================================================== > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 650cfc5757eb..df5145fab287 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -13,15 +13,16 @@ ifeq ($(CONFIG_CC_IS_CLANG), y) > COMPAT_GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE_COMPAT)elfedit)) > COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) > > -CLANG_CC_COMPAT := $(CC) > -CLANG_CC_COMPAT += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > -CLANG_CC_COMPAT += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) > -CLANG_CC_COMPAT += -no-integrated-as -Qunused-arguments > +COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > +COMPAT_CLANG_FLAGS += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR) > +COMPAT_CLANG_FLAGS += -no-integrated-as -Qunused-arguments > ifneq ($(COMPAT_GCC_TOOLCHAIN),) > -CLANG_CC_COMPAT += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > +COMPAT_CLANG_FLAGS += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > endif > > -CC_COMPAT ?= $(CLANG_CC_COMPAT) > +CC_COMPAT ?= $(CC) > +CC_COMPAT += $(COMPAT_CLANG_FLAGS) > + > else > CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > endif > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel