From: Mark Brown <broonie@kernel.org>
To: Lucas Costa <2000.costalucas@gmail.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] spi: bcm2835: fix device_node reference leak in bcm2835_spi_setup()
Date: Fri, 25 Sep 2026 20:42:33 +0100 [thread overview]
Message-ID: <ce711fbc-71a1-460f-bde7-9e2cefd96db4@sirena.org.uk> (raw)
In-Reply-To: <20260925193008.127314-1-2000.costalucas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On Fri, Sep 25, 2026 at 04:30:08PM -0300, Lucas Costa wrote:
> of_find_compatible_node() returns a device_node with its reference count
> incremented, but bcm2835_spi_setup() only uses the return value to test
> for a matching node in the loop and never releases it.
Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-25 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 18:44 [PATCH] spi: bcm2835: fix device_node reference leak in bcm2835_spi_setup() Lucas Costa
2026-09-24 7:48 ` Bartosz Golaszewski
2026-09-25 19:30 ` [PATCH v2] " Lucas Costa
2026-09-25 19:42 ` Mark Brown [this message]
2026-09-28 8:31 ` Bartosz Golaszewski
2026-09-28 17:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce711fbc-71a1-460f-bde7-9e2cefd96db4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=2000.costalucas@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox