From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32B18C001E0 for ; Thu, 10 Aug 2023 13:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1I6ttiETPXS81HxenHfmcJ5hK8uIxMp3x0E4yYaY1VA=; b=uXJD8+ubHADS36 0yC7F44qp2LnyCZ3xzzijPwg1pIlfgyUA0MsghFY056sK5/cs/0wu90bJFBP3+CNP/MoE6zZQUD87 1LJ6AII8lH74/3dRopffAcS4MpralWzf/HDIBh79f6bBqvWSy6EhO14OMP7HNhEYlgbHPM2PLsjpO EBN0pA52W054iehTRnJ4Hp1GGFUHlGuxIFvUE2oFEp9CH7VgjJg7DuUXepVIFOwHxJC4rrhA4TGWM KOWMgGGRlhgEglk6mNnaZownZYpgO50GbENIpFHnMzyVS+k5CWLD/9ewm0i/VxB96abTAm/qAEMxC 5vx2n1gqbN3fs9Y+2LRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU5z7-007mcV-0G; Thu, 10 Aug 2023 13:45:53 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU5z3-007mbc-1j for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 13:45:51 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AClM6D009211; Thu, 10 Aug 2023 15:45:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=qd8558qevje9CkFMuo6OGsMVLyIAZeqVXdpJae7LwQA=; b=Gu 3DsyFZQM4ymh8/EvcOJDwKyajC82pfjwqSpEXAJKYZVsLYCTfravJgbpoo/yBnyT eyDEJ1WqdavyVJ89rBUHzeAxlOgEmlBmA/beSMclOPEmu7hTfmyFxTMjUKIN1FAX vBgF8v0MeyMgAPcQNos3ckvvNlIx1V91u0yNsSD8IjiVBvb/xqKcEAjF9/X94uuC BA76ExfKpsJXtdiBUb/3qfQYoud9jJ9pk71VTFAGOLZQVUlJ0d5429JwWmlPZ2E4 Sq9VGbkvCVuEqsr8zkXTvzSK4hUmscg7YZeFNne0GkFYLPdA5d2Ur9PaYzkyqdu7 Qu6Sq2NqX+2jjweK9bcg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3sd0730afe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 15:45:37 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A7CBA100053; Thu, 10 Aug 2023 15:45:36 +0200 (CEST) Received: from Webmail-eu.st.com (eqndag1node4.st.com [10.75.129.133]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6E18321BF73; Thu, 10 Aug 2023 15:45:36 +0200 (CEST) Received: from [10.201.21.122] (10.201.21.122) by EQNDAG1NODE4.st.com (10.75.129.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 10 Aug 2023 15:45:35 +0200 Message-ID: Date: Thu, 10 Aug 2023 15:45:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next v3 01/10] net: stmmac: correct RX COE parsing for xgmac Content-Language: en-US To: Jisheng Zhang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro , Jose Abreu CC: , , , , References: <20230809165007.1439-1-jszhang@kernel.org> <20230809165007.1439-2-jszhang@kernel.org> From: Alexandre TORGUE In-Reply-To: <20230809165007.1439-2-jszhang@kernel.org> X-Originating-IP: [10.201.21.122] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To EQNDAG1NODE4.st.com (10.75.129.133) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_10,2023-08-10_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_064550_038625_1953FBEC X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/9/23 18:49, Jisheng Zhang wrote: > xgmac can support RX COE, but there's no two kinds of COE, I.E type 1 > and type 2 COE. > > Signed-off-by: Jisheng Zhang > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index e1f1c034d325..15ed3947361b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -6271,7 +6271,7 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v) > seq_printf(seq, "\tAV features: %s\n", (priv->dma_cap.av) ? "Y" : "N"); > seq_printf(seq, "\tChecksum Offload in TX: %s\n", > (priv->dma_cap.tx_coe) ? "Y" : "N"); > - if (priv->synopsys_id >= DWMAC_CORE_4_00) { > + if (priv->synopsys_id >= DWMAC_CORE_4_00 || priv->plat->has_xgmac) { > seq_printf(seq, "\tIP Checksum Offload in RX: %s\n", > (priv->dma_cap.rx_coe) ? "Y" : "N"); > } else { > @@ -7013,7 +7013,7 @@ static int stmmac_hw_init(struct stmmac_priv *priv) > if (priv->plat->rx_coe) { > priv->hw->rx_csum = priv->plat->rx_coe; > dev_info(priv->device, "RX Checksum Offload Engine supported\n"); > - if (priv->synopsys_id < DWMAC_CORE_4_00) > + if (priv->synopsys_id < DWMAC_CORE_4_00 && !priv->plat->has_xgmac) > dev_info(priv->device, "COE Type %d\n", priv->hw->rx_csum); > } > if (priv->plat->tx_coe) Acked-by: Alexandre TORGUE Regards Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel