From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDDAC3A59B for ; Mon, 19 Aug 2019 07:41:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7A5A20989 for ; Mon, 19 Aug 2019 07:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kKap2kuw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="EKPcW4iB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7A5A20989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=etl4UCU2g2RKgOXIrQTv43iSKGjAoWR3a6+HkQ3dZQE=; b=kKap2kuwLxP20N OGJ+3Poj9A788k1ykzvjjYvZYEOiAS7kZyCpsXdZ1CyPuQDSt7Xe9diQ7dB1jn6LQOhpRbXr2ZsLT fzdFNs3NTHosoMULQKrhcFVDny5meD0nRmyJhxMEMQLhKvk8dDHymlx9o1D1EkUA0EwtFWkFvaig0 473Lx8pZU/ZROqomTCMXzgoZa9YW+C/FwbBL1jIPMDsSJi+CZ77aagNjggesHPpzaUS4UnrP/NmBH dcnPqQv4k3YDtFL0c6bmEw531gfOIyHWLsp7Xxk5L8LI2ROsCqk5uyRZFRcCAzkj5OSYnW5h/F/u1 fyLiplKB9zGrjjkZ2OTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzcHp-0004ce-L1; Mon, 19 Aug 2019 07:41:05 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzcHm-0004c7-J2 for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 07:41:04 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7J7aQWn026361; Mon, 19 Aug 2019 09:40:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=7aSw9X3s9+ekMFjoSt5O6z5zbNruogj2ZJ47vk/drdI=; b=EKPcW4iBPC8PYxzEQdYvVFfEciolJUKqkhXZqUAPuf+EQN/YIb46Gp5r9kotBPe+B/el dZVLEq80GTQ1lTrdXPW8pMmiRNJ9VI3aTxbZLU3WbH1eXAoJaDpdutbmye4wgRZp7mDX 40Yp0j8MWkvqx3G++CBD252jtDrei4x75/Yqs27BdPyaeKrOSFzQkcjnjR1Xe1oqSDba mPYaS/j31o4U4RmkyJsNSUKDpOf/TO8x2pQXYWiCEnqMoDPWxgELrMwpYtUVgwyWfm+Y VoS8ICQDf8uCRXFfY4VPOUcsr5sdMpFl6GRMbGEJE+NLBOMVU0gZNvcGzZ4RKyRoGWtR eg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2ue720t0ev-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 19 Aug 2019 09:40:55 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 70A003F; Mon, 19 Aug 2019 07:40:54 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag6node2.st.com [10.75.127.17]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5AB022C06DC; Mon, 19 Aug 2019 09:40:54 +0200 (CEST) Received: from SFHDAG5NODE1.st.com (10.75.127.13) by SFHDAG6NODE2.st.com (10.75.127.17) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 19 Aug 2019 09:40:53 +0200 Received: from SFHDAG5NODE1.st.com ([fe80::cc53:528c:36c8:95f6]) by SFHDAG5NODE1.st.com ([fe80::cc53:528c:36c8:95f6%20]) with mapi id 15.00.1473.003; Mon, 19 Aug 2019 09:40:53 +0200 From: Hugues FRUCHET To: Sakari Ailus Subject: Re: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code Thread-Topic: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code Thread-Index: AQHVVAq68UiFQiNcNkmXdD8YMRgfcacB9FUAgAAA2oCAAAQPgA== Date: Mon, 19 Aug 2019 07:40:53 +0000 Message-ID: References: <1565790533-10043-1-git-send-email-hugues.fruchet@st.com> <1565790533-10043-3-git-send-email-hugues.fruchet@st.com> <20190816081514.GU6133@paasikivi.fi.intel.com> <20190819072621.GZ6133@paasikivi.fi.intel.com> In-Reply-To: <20190819072621.GZ6133@paasikivi.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.49] Content-ID: <3124090F81DAD34B8BD1CF42EC06E4A3@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-19_02:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_004102_997965_F86AC509 X-CRM114-Status: GOOD ( 22.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yannick FERTRE , Alexandre TORGUE , Mickael GUENE , "linux-kernel@vger.kernel.org" , Philippe CORNU , Hans Verkuil , Benjamin Gaignard , Mauro Carvalho Chehab , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, OK, I will change. Have you some other remarks on this serie in order that I group changes in the next version ? On 8/19/19 9:26 AM, Sakari Ailus wrote: > Hi Hugues, > > On Mon, Aug 19, 2019 at 07:23:17AM +0000, Hugues FRUCHET wrote: >> Hi Sakari, >> >> On 8/16/19 10:15 AM, Sakari Ailus wrote: >>> Hi Hugues, >>> >>> On Wed, Aug 14, 2019 at 03:48:51PM +0200, Hugues Fruchet wrote: >>>> Add a trace of the set of supported fourcc/mbus_code which >>>> intersect between DCMI and source sub-device. >>>> >>>> Signed-off-by: Hugues Fruchet >>>> --- >>>> drivers/media/platform/stm32/stm32-dcmi.c | 12 ++++++++++-- >>>> 1 file changed, 10 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c >>>> index b462f71..18acecf 100644 >>>> --- a/drivers/media/platform/stm32/stm32-dcmi.c >>>> +++ b/drivers/media/platform/stm32/stm32-dcmi.c >>>> @@ -1447,12 +1447,20 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi) >>>> /* Code supported, have we got this fourcc yet? */ >>>> for (j = 0; j < num_fmts; j++) >>>> if (sd_fmts[j]->fourcc == >>>> - dcmi_formats[i].fourcc) >>>> + dcmi_formats[i].fourcc) { >>>> /* Already available */ >>>> + dev_dbg(dcmi->dev, "Skipping fourcc/code: %4.4s/0x%x\n", >>>> + (char *)&sd_fmts[j]->fourcc, >>>> + mbus_code.code); >>>> break; >>>> - if (j == num_fmts) >>>> + } >>>> + if (j == num_fmts) { >>>> /* New */ >>>> sd_fmts[num_fmts++] = dcmi_formats + i; >>>> + dev_dbg(dcmi->dev, "Supported fourcc/code: %4.4s/0x%x\n", >>> >>> Over 80 characters per line. >>> >> >> This an exception of the "80 chars" in order to be able to grep in >> kernel messages: >> https://www.kernel.org/doc/html/v4.10/process/coding-style.html >> "However, never break user-visible strings such as printk messages, >> because that breaks the ability to grep for them." >> >> This exception is managed in checkpatch.pl (--strict). > > This exception is for cases where wrapping the line in the usual way, e.g. > at argument boundaries, does not prevent it exceeding 80 characters. But it is > not the case here. > BR, Hugues. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel