From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCD1C3A5A4 for ; Fri, 30 Aug 2019 09:07:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D41C02343C for ; Fri, 30 Aug 2019 09:07:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bHeFl0kR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="VECDpe6G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D41C02343C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=12nlf1mfHNVRRt5mHoUDgD29e8uUGv0F576C9euTJeA=; b=bHeFl0kRBUDkEyi8RXE0xP0mv dqg/K4Op14GP4o/uDfUEvOE33sD4n+I9WDa+jIrlkMwO2zDetU6ieHr83DH0uhAcFoDUkAmGi4hn0 S9KxgUghDxLZ6dEcl+1fJ+U6AfSt7ZyCpjAPZLiKKrdbdWHcQCXlCqfhjsjS9MRyBs3ur60XZlFYx UCVZL0LXti6bE+dtDJk23QB7ylafiWXTp/z0+10ZoW7ASrccrBFPoGb5qpMUMKucBmw8xT9gOO2IV ln4uLF2+CrGs3PwfyPiLqns0xQtbPud70kGaZBNE5DEvHyMPpLDu0Y4GaabF8ah6c292JbJWQz6w3 uAf4AEn1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3csK-0003Jr-02; Fri, 30 Aug 2019 09:07:20 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3csG-0003JY-QR for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2019 09:07:18 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7U97BYH075140; Fri, 30 Aug 2019 04:07:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1567156031; bh=pbbHjXFgEMUNVSFKH41QJG48HyK2dDKJg25+FIAOwgc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=VECDpe6GWhf9qaBrfGZm7EvMrdsIKsfbQlJ0pCe8RqkCZefHYvJ4Z8XkEiAqC2n+d 5WFPU85s3eJKKGNfTILEspun7nwAZgkDZacGhSO9BhrkeU/TiQE9toHGZaBbp9evml 6jYyu092MIJN8hENWF20ma/bNvT/0FWf499VLuTg= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7U97Bo8071724 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 30 Aug 2019 04:07:11 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 30 Aug 2019 04:07:11 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 30 Aug 2019 04:07:11 -0500 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7U97879074497; Fri, 30 Aug 2019 04:07:09 -0500 Subject: Re: [PATCHv2 03/11] soc: ti: omap-prm: poll for reset complete during de-assert To: Philipp Zabel , , , , References: <20190828071941.32378-1-t-kristo@ti.com> <20190828071941.32378-4-t-kristo@ti.com> <1567084467.5345.9.camel@pengutronix.de> From: Tero Kristo Message-ID: Date: Fri, 30 Aug 2019 12:07:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1567084467.5345.9.camel@pengutronix.de> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_020716_965251_AFF01537 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tony@atomide.com, devicetree@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/08/2019 16:14, Philipp Zabel wrote: > Hi Tero, > > On Wed, 2019-08-28 at 10:19 +0300, Tero Kristo wrote: >> Poll for reset completion status during de-assertion of reset, otherwise >> the IP in question might be accessed before it has left reset properly. >> >> Signed-off-by: Tero Kristo >> --- >> drivers/soc/ti/omap_prm.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c >> index fd5c431f8736..afeb70761b27 100644 >> --- a/drivers/soc/ti/omap_prm.c >> +++ b/drivers/soc/ti/omap_prm.c >> @@ -127,6 +127,7 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, >> u32 v; >> int st_bit; >> bool has_rstst; >> + int timeout = 0; >> >> if (!_is_valid_reset(reset, id)) >> return -EINVAL; >> @@ -153,6 +154,25 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, >> v &= ~(1 << id); >> writel_relaxed(v, reset->prm->base + reset->prm->data->rstctrl); >> >> + if (!has_rstst) >> + return 0; >> + >> + /* wait for the status to be set */ >> + while (1) { >> + v = readl_relaxed(reset->prm->base + reset->prm->data->rstst); >> + v &= 1 << st_bit; >> + if (v) >> + break; >> + timeout++; >> + if (timeout > OMAP_RESET_MAX_WAIT) { >> + pr_err("%s: timedout waiting for %s:%lu\n", __func__, >> + dev_name(rcdev->dev), id); >> + return -EBUSY; >> + } >> + >> + udelay(1); >> + } > > This looks like you could use > > readl_relaxed_poll_timeout(_atomic) Yeah true, let me change that. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel