From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Zhang Qilong <zhangqilong3@huawei.com>, <ssantosh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: Fix reference imbalance in knav_dma_probe
Date: Thu, 19 Nov 2020 21:55:05 +0200 [thread overview]
Message-ID: <cef2332c-e2af-cc6c-cdeb-79c655572ee7@ti.com> (raw)
In-Reply-To: <20201119141303.175871-1-zhangqilong3@huawei.com>
On 19/11/2020 16:13, Zhang Qilong wrote:
> The patch fix two reference leak.
>
> 1) pm_runtime_get_sync will increment pm usage counter even it
> failed. Forgetting to call put operation will result in
> reference leak.
>
> 2) The pm_runtime_enable will increase power disable depth. Thus
> a pairing decrement is needed on the error handling path to
> keep it balanced.
>
> We fix it by: 1) adding call pm_runtime_put_noidle or
> pm_runtime_put_sync in error handling. 2) adding pm_runtime_disable
> in error handling, to keep usage counter and disable depth balanced.
>
> Fixes: 88139ed030583 ("soc: ti: add Keystone Navigator DMA support")
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/soc/ti/knav_dma.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index 8c863ecb1c60..56597f6ea666 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -749,8 +749,9 @@ static int knav_dma_probe(struct platform_device *pdev)
> pm_runtime_enable(kdev->dev);
> ret = pm_runtime_get_sync(kdev->dev);
> if (ret < 0) {
> + pm_runtime_put_noidle(kdev->dev);
> dev_err(kdev->dev, "unable to enable pktdma, err %d\n", ret);
> - return ret;
> + goto err_pm_disable;
> }
>
> /* Initialise all packet dmas */
> @@ -764,7 +765,8 @@ static int knav_dma_probe(struct platform_device *pdev)
>
> if (list_empty(&kdev->list)) {
> dev_err(dev, "no valid dma instance\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto err_put_sync;
> }
>
> debugfs_create_file("knav_dma", S_IFREG | S_IRUGO, NULL, NULL,
> @@ -772,6 +774,13 @@ static int knav_dma_probe(struct platform_device *pdev)
>
> device_ready = true;
> return ret;
> +
> +err_put_sync:
> + pm_runtime_put_sync(kdev->dev);
> +err_pm_disable:
> + pm_runtime_disable(kdev->dev);
> +
> + return ret;
> }
>
> static int knav_dma_remove(struct platform_device *pdev)
>
Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-19 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 14:13 [PATCH] soc: ti: Fix reference imbalance in knav_dma_probe Zhang Qilong
2020-11-19 19:55 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef2332c-e2af-cc6c-cdeb-79c655572ee7@ti.com \
--to=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ssantosh@kernel.org \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).