From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC40C54FD0 for ; Fri, 24 Apr 2020 12:54:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D16C20706 for ; Fri, 24 Apr 2020 12:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HaURIMWH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D16C20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hpKFz32XybMxKp6sstUdqdENEP++4wT/W824uc4xQAc=; b=HaURIMWHl5JC8T x2yN7kWGcDACIMnQtHVXjno26LH5jnkqXp9GEHzZp2oOKK/JYIZhymfujGude7Wve76BwCv76lPaK /dlUSP7W0IwYK7CDlTN6NM3wYy7LghgXGUZzGwQmA6BbPZZ8960wZzK04xmYaEKmurs7L50OUaONB a2PQxTvkeKlx5VLbnU605WoK0AWIzqoFzKflXqVT80JUD61hsXpNeP0WiodEkA+Brz5XwUn0yyJcO vY2W8F59qJxEsg454wdZbspdLfgbaDUpCWdvwoyiizaXpBP7qk93n8TbVDarWH7+NwxBCfUKmeLi1 qlzmQmsNnocTKc3y2xeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRxqX-0005Y2-Rg; Fri, 24 Apr 2020 12:54:21 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRxqU-0005Vu-6N; Fri, 24 Apr 2020 12:54:19 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id E0DE32A2C38 Message-ID: Subject: Re: [PATCH v2 3/4] media: rockchip: rga: Add support for the PX30 compatible From: Ezequiel Garcia To: Paul Kocialkowski , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 24 Apr 2020 09:54:04 -0300 In-Reply-To: <20200423200937.1039257-4-paul.kocialkowski@bootlin.com> References: <20200423200937.1039257-1-paul.kocialkowski@bootlin.com> <20200423200937.1039257-4-paul.kocialkowski@bootlin.com> Organization: Collabora User-Agent: Evolution 3.36.0-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200424_055418_360858_27D4B339 X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: justin.swartz@risingedge.co.za, Heiko Stuebner , Hans Verkuil , Rob Herring , Thomas Petazzoni , Johan Jonker , Mauro Carvalho Chehab Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Paul, Thanks for the patch! On Thu, 2020-04-23 at 22:09 +0200, Paul Kocialkowski wrote: > The PX30 SoC has a RGA block, so add the associated compatible to > support it. > > Signed-off-by: Paul Kocialkowski > --- > drivers/media/platform/rockchip/rga/rga.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index 9d122429706e..4fb4615662b7 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -955,6 +955,9 @@ static const struct dev_pm_ops rga_pm = { > }; > > static const struct of_device_id rockchip_rga_match[] = { > + { > + .compatible = "rockchip,px30-rga", > + }, Please note that if you don't have anything px30-specific, then you don't need the compatible in the driver. You can have something like: compatible = "rockchip,px30-rga", "rockchip,rk3288-rga" so you need to add it to the bindings. See Justin Swartz recent patches for rk3228. Down the road, if you find something specific for px30, you can make the driver aware. Cheers, Ezequiel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel