From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF44C433E0 for ; Mon, 29 Jun 2020 11:43:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9ADA723C8E for ; Mon, 29 Jun 2020 11:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vFcLbSuS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ADA723C8E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sMRrQlwQoNozkGraeV5QMryYjFSY5NCexYk0zitjW5o=; b=vFcLbSuSn6Uky/2A+mkzyT45N iZOAZRrtG1nkM/XywP3lfRCMA8FuS/adKs3SfrRq3sVraBxzcSSGlNgY+4EtH8etRWN81oC9SRH1/ yf3CvWtpEDAp7JohIIL5B3AWugaNYVZ0nAr6WxNRiLsTz/1h/V5M2eaJC+eO4YLh0oRm+u2qQGO1q tc5JjcIhCxA7xSAiMWyePdpPBFVf7u9bR6PxGWy+F5whqC/ZBGv11wAf3RS2wmVI7+NpT/Z6ySg+9 ydk4inUNKzV2N/mXC0Hm2mbnIbTZ6zQggzqOWFHQ9pyThWvTSHlYq/CgfXkGN/SZhYNOIf7kIbYfM n45SCuGpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsAl-0003nW-4D; Mon, 29 Jun 2020 11:42:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsAi-0003mh-48 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 11:42:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 125D91435; Mon, 29 Jun 2020 04:41:59 -0700 (PDT) Received: from [10.37.12.67] (unknown [10.37.12.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DA9D3F73C; Mon, 29 Jun 2020 04:41:56 -0700 (PDT) Subject: Re: brocken devfreq simple_ondemand for Odroid XU3/4? To: Sylwester Nawrocki References: <20200623164733.qbhua7b6cg2umafj@macmini.local> <20200623191129.GA4171@kozik-lap> <85f5a8c0-7d48-f2cd-3385-c56d662f2c88@arm.com> <4a72fcab-e8da-8323-1fbe-98a6a4b3e0f1@arm.com> <708feba7-6b11-4943-1073-a1b5e54b6283@samsung.com> From: Lukasz Luba Message-ID: Date: Mon, 29 Jun 2020 12:41:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <708feba7-6b11-4943-1073-a1b5e54b6283@samsung.com> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willy Wolff , "linux-samsung-soc@vger.kernel.org" , linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Chanwoo Choi , Kyungmin Park , Kukjin Kim , MyungJoo Ham , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/26/20 6:50 PM, Sylwester Nawrocki wrote: > Hi Lukasz, > > On 25.06.2020 12:02, Lukasz Luba wrote: >> Regarding the 'performance counters overflow interrupts' there is one >> thing worth to keep in mind: variable utilization and frequency. >> For example, in order to make a conclusion in algorithm deciding that >> the device should increase or decrease the frequency, we fix the period >> of observation, i.e. to 500ms. That can cause the long delay if the >> utilization of the device suddenly drops. For example we set an >> overflow threshold to value i.e. 1000 and we know that at 1000MHz >> and full utilization (100%) the counter will reach that threshold >> after 500ms (which we want, because we don't want too many interrupts >> per sec). What if suddenly utilization drops to 2% (i.e. from 5GB/s >> to 250MB/s (what if it drops to 25MB/s?!)), the counter will reach the >> threshold after 50*500ms = 25s. It is impossible just for the counters >> to predict next utilization and adjust the threshold. > > Agreed, that's in case when we use just the performance counter (PMCNT) > overflow interrupts. In my experiments I used the (total) cycle counter > (CCNT) overflow interrupts. As that counter is clocked with fixed rate > between devfreq updates it can be used as a timer by pre-loading it with > initial value depending on current bus frequency. But we could as well > use some reliable system timer mechanism to generate periodic events. > I was hoping to use the cycle counter to generate low frequency monitor > events and the actual performance counters overflow interrupts to detect > any sudden changes of utilization. However, it seems it cannot be done > with as simple performance counters HW architecture as on Exynos4412. > It looks like on Exynos5422 we have all what is needed, there is more > flexibility in selecting the counter source signal, e.g. each counter > can be a clock cycle counter or can count various bus events related to > actual utilization. Moreover, we could configure the counter gating period > and alarm interrupts are available for when the counter value drops below > configured MIN threshold or exceeds configured MAX value. I see. I don't have TRM for Exynos5422 so couldn't see that. I also have to keep in mind other platforms which might not have this feature. > > So it should be possible to configure the HW to generate the utilization > monitoring events without excessive continuous CPU intervention. I agree, that would be desirable especially for low load in the system. > But I'm rather not going to work on the Exynos5422 SoC support at the moment. I see. > >> To address that, we still need to have another mechanism (like watchdog) >> which will be triggered just to check if the threshold needs adjustment. >> This mechanism can be a local timer in the driver or a framework >> timer running kind of 'for loop' on all this type of devices (like >> the scheduled workqueue). In both cases in the system there will be >> interrupts, timers (even at workqueues) and scheduling. >> The approach to force developers to implement their local watchdog >> timers (or workqueues) in drivers is IMHO wrong and that's why we have >> frameworks. > > Yes, it should be also possible in the framework to use the counter alarm > events where the hardware is advanced enough, in order to avoid excessive > SW polling. Looks promising, but that would need more plumbing I assume. Regards, Lukasz > > -- > Regards, > Sylwester > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel