From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CF2C4361B for ; Tue, 15 Dec 2020 12:16:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4E1F2078D for ; Tue, 15 Dec 2020 12:16:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4E1F2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0BeFIhUYT0n8QGe6f7KtGGYRQcJo8JNBLs97Y2LSJU4=; b=gBZko9nKQ2p/i0JeYYrnsE0tq YqrMQUB9TXTrYUUo8EMxEf8UdIR1WoO7xAM2Kzd0cv0UgasaPFTpc8w6Uoj+MMLvBOxECRLr3wlIc gGBlrMElWs6ItHJ0IjDFWzkq+l0UPBBoZ2fi2x60hdh8TFycfmFxWhUzaaIUQ+WE+ypydadWxeHsX qnuSSrPovEEpVqg3qcJ+pY7JbLihAVPIk12hru3Xu1nlZvPuA2Yn0SV/KATCgQBQTTBAFUMSl06nm izIDjhINT+qVHOT7X4PStD3Q+M4WwUFsJH264K9sFoFBqYcXNPKbgasy1wbiTMrjTh0lyJ4bcINto HT8gjUK1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp9EH-0002Xq-7U; Tue, 15 Dec 2020 12:14:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp9ED-0002Wb-OK for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 12:14:55 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A53042078D; Tue, 15 Dec 2020 12:14:52 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kp9EA-001TN0-IX; Tue, 15 Dec 2020 12:14:50 +0000 MIME-Version: 1.0 Date: Tue, 15 Dec 2020 12:14:50 +0000 From: Marc Zyngier To: Valentin Schneider Subject: Re: [PATCH 3/5] irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq() In-Reply-To: References: <20201109094121.29975-1-valentin.schneider@arm.com> <20201109094121.29975-4-valentin.schneider@arm.com> <20201215002134.GA182208@roeck-us.net> <38f8fbe9ceb7a0adb47e62d62260b297@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andrew@lunn.ch, Lorenzo.Pieralisi@arm.com, jason@lakedaemon.net, sbranden@broadcom.com, gregory.clement@bootlin.com, f.fainelli@gmail.com, rjui@broadcom.com, tglx@linutronix.de, sebastian.hesselbarth@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_071454_384877_E9771EA1 X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , Scott Branden , Ray Jui , Gregory Clement , linux-kernel@vger.kernel.org, Florian Fainelli , Guenter Roeck , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-12-15 11:14, Valentin Schneider wrote: > On 15/12/20 10:19, Marc Zyngier wrote: >> Hi Gunter, >> >> On 2020-12-15 00:21, Guenter Roeck wrote: >>> On Mon, Nov 09, 2020 at 09:41:19AM +0000, Valentin Schneider wrote: >>>> As done for the Arm GIC irqchips, move IPIs to >>>> handle_percpu_devid_irq() as >>>> handle_percpu_devid_fasteoi_ipi() isn't actually required. >>>> >>>> Signed-off-by: Valentin Schneider >>> >>> This patch results in boot failures (silent stall) for the qemu >>> raspi2 emulation. Unfortunately it can not be reverted because >>> handle_percpu_devid_fasteoi_ipi no longer exists in next-20201214, >>> so I don't know if it is the only problem. >> >> This is odd. This works just fine for me on both the RPi2 and 3 >> emulation, running a full Debian userspace. Could this be caused >> by the version of QEMU you are using? Here's what I have: >> >> $ qemu-system-arm --version >> QEMU emulator version 5.1.0 (Debian 1:5.1+dfsg-4+b1) >> >> Could you try the following hack and let me know if that helps? >> > > Thanks for looking into this. It does look like I inverted the ordering > of > that mailbox write vs the handling of the IPI. I don't see how the IPI > could mess with the mailbox (unless some creative use of irq_work / > smp_call), but in any case having the write in irq_ack() as you've done > below should restore said ordering. This hack indeed brings us back to the previous situation, where we allowed the interrupt to be re-generated while handling the IPI. Still, that doesn't explain why I'm not experiencing any issue here. I hope that the various CI bots will let us know if anything is broken on real HW. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel