From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6313BC3DA4B for ; Mon, 15 Jul 2024 21:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZDgo6/roqthuSa9h2cJWgH9Wy9T/pvV7p+6Nl8xKZW4=; b=z6PCcAulZzdJ1xcy6v60se2hZ3 3uOkGGrMWNhWkQsF46U6ibMYZrpHgGE32VqaP/IBHp1ylaBsfOjrGVUP9Czm29MPdbZfRtKJ8u+xR PLOc42hKeh5EgTsgnonyl+XjkdQKMV54LQJVvmSyipYnalYnXaqnLlZuD8QE5VCSHlAGccV3yM+44 3MZ62RLrHGnAO9xq1V0M2mNgensaLjvQSg0httCWuwAaYhmKyt1M7mrcKoQB73mF+/ohxStWfy/XM fFz77go0DXvnjKjl5kkpmnZ8ALdfkTyKJQcfmLh4DFlXC32FTJUe8WmB+ervvi6BEclNRY/c3PzKu P8JIZuLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTSyu-00000008QH2-2IIV; Mon, 15 Jul 2024 21:11:36 +0000 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTSyZ-00000008QAo-2WBZ; Mon, 15 Jul 2024 21:11:16 +0000 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-6b61689d7c9so29719396d6.2; Mon, 15 Jul 2024 14:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721077873; x=1721682673; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZDgo6/roqthuSa9h2cJWgH9Wy9T/pvV7p+6Nl8xKZW4=; b=m0rwXLkuHVVaWuTb7k4wAL1dfWGRoQUSUTuKmiyH+H7TP1lZYWC21d37fFAcRLSq4R 1COr/0H/SDzOyvyF0TPyAhDKiSp4E3sTQN3QTG+Rg2B4wEPRTg9FcYuMJ5UwEjnSZgS7 Wx3y2PrZQzHw0H70dOgyijDAugXaRejW9XuVEX3RprcHKNuE5AsngwH4EvXMXcDr6yaJ bxY/cf3GvPADJT1TjZ3NgGbHPTPyC+fg/hOE2LgvheADe3ZqEp6EDd440RLkSwnUmOQ8 8xgtSQBGmHk5lBVw2sTqyVktE2Sw4+AbzZZcZ4IDpFDNTrrJzhh3QbZjbuwdB8eiTGyi MhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721077873; x=1721682673; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZDgo6/roqthuSa9h2cJWgH9Wy9T/pvV7p+6Nl8xKZW4=; b=IzP1lZjvyM419uJYYWlN3xM/mbxXngTCUwppNvDtYnw+0KMash1HdZNNw4W4wuhnpn pvUkAjZ7ZJizCQP5pTF13OXzTClgtFdqU233rXJgzGGKQx6dmq+NNogbCXrqV9/gzcit LKt25wA6zY4aGdYYupA6RFvZLRpbfT+KOE5GKWq+dJ5F6k+6M58QBoWAUaZxGV504iR7 Dsy+mO0FrhlfM+AugYjRfHuMlHKNsDMjxvi4NMhrQ1iRdpno6dVzg5RCoixwTZ/t3oQE ZzsMOTEzeLDBJbkqAAiHpwXIcSWoQ1SCt6c3xPl+5SG4MOg38UP9dYlhF4lkl6PpCuWj YURA== X-Forwarded-Encrypted: i=1; AJvYcCXtqOPkv3SftmmHJNWydgVvBgWF5gHxPLXAZaVYPpbnFTezYg1tx4wE1QGBE9Ih0FlDsVTaTsLEYs6jf/Mc6332Dsbo4fj4/InTtmDAg+eYxnYrqfrMEQUJWT6q63WCzTtVRl+nZ+5pp2PZHs2TPuBZ50VJZ4yUjxm7Hg== X-Gm-Message-State: AOJu0YyMxXcPk8J75s5fhYXbm8NYCK1UVGtMSEMUjb+oaO0SkkfME7Bn BtI2qAZnwPaJSAoUXq5Psue9gXKe2RiVWUcVNufBA9/pQpNUVGEO X-Google-Smtp-Source: AGHT+IHFvWkX/s7qTAtzppR7TyaZgVXpSaehoSrKXhXImnANwBQKzLvb6NAoTQZ43XF6+UpQvvC6hw== X-Received: by 2002:a05:6214:e88:b0:6b5:4ca8:2798 with SMTP id 6a1803df08f44-6b77f5161e1mr4873286d6.27.1721077873338; Mon, 15 Jul 2024 14:11:13 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-6b761a583a3sm24941056d6.126.2024.07.15.14.10.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 14:10:57 -0700 (PDT) Message-ID: Date: Mon, 15 Jul 2024 14:10:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/12] PCI: brcmstb: Use common error handling code in brcm_pcie_probe() To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240710221630.29561-1-james.quinlan@broadcom.com> <20240710221630.29561-4-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli In-Reply-To: <20240710221630.29561-4-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_141115_673203_755456D2 X-CRM114-Status: UNSURE ( 7.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/10/24 15:16, Jim Quinlan wrote: > o Move the clk_prepare_enable() below the resource allocations. > o Add a jump target (clk_out) so that a bit of exception handling can be > better reused at the end of this function implementation. > > Signed-off-by: Jim Quinlan > > Fixes: bb610757fcd7 ("PCI: brcmstb: Use reset/rearm instead of deassert/assert") (no need for an empty line between your Signed-off-by and the Fixes tags BTW). Reviewed-by: Florian Fainelli -- Florian