From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Quentin Perret <qperret@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v2 5/5] KVM: arm64: Disable privileged hypercalls after pKVM finalisation
Date: Fri, 08 Oct 2021 08:31:11 +0100 [thread overview]
Message-ID: <cf74e6afcf1988ab7fcb87eb20bb2947@kernel.org> (raw)
In-Reply-To: <20211008072722.GA32625@willie-the-truck>
On 2021-10-08 08:27, Will Deacon wrote:
> On Thu, Oct 07, 2021 at 01:56:47PM +0100, Marc Zyngier wrote:
>> On Tue, 05 Oct 2021 12:37:21 +0100,
>> Will Deacon <will@kernel.org> wrote:
>> >
>> This is no helping with the above, but can we *please* try to get rid
>> of this #define insanity before moving things around? I came up with
>> the following, which seems to build.
>>
>> Thoughts?
>>
>> M.
>>
>> From 8a50c98489220d2ebaf02d4ffdbef3cf0d6634ee Mon Sep 17 00:00:00 2001
>> From: Marc Zyngier <maz@kernel.org>
>> Date: Thu, 7 Oct 2021 13:18:29 +0100
>> Subject: [PATCH] KVM: arm64: Turn __KVM_HOST_SMCCC_FUNC_* into an enum
>> (mostly)
>>
>> __KVM_HOST_SMCCC_FUNC_* is a royal pain, as there is a fair amount
>> of churn around these #defines, and we avoid making it an enum
>> only for the sake of the early init, low level code that requires
>> __KVM_HOST_SMCCC_FUNC___kvm_hyp_init to be usable from assembly.
>>
>> Let's be brave and turn everything but this symbol into an enum,
>> using a bit of arithmetic to avoid any overlap.
>>
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> ---
>> arch/arm64/include/asm/kvm_asm.h | 44
>> +++++++++++++++++---------------
>> 1 file changed, 24 insertions(+), 20 deletions(-)
>
> Looks fine to me:
>
> Acked-by: Will Deacon <will@kernel.org>
>
> Do you need me to respin my series on top of this?
If you don't mind, that'd make my life easier.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-10-08 7:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 11:37 [PATCH v2 0/5] KVM: arm64: Restrict host hypercalls when pKVM is enabled Will Deacon
2021-10-05 11:37 ` [PATCH v2 1/5] arm64: Prevent kexec and hibernation if is_protected_kvm_enabled() Will Deacon
2021-10-05 11:37 ` [PATCH v2 2/5] KVM: arm64: Reject stub hypercalls after pKVM has been initialised Will Deacon
2021-10-05 11:37 ` [PATCH v2 3/5] KVM: arm64: Propagate errors from __pkvm_prot_finalize hypercall Will Deacon
2021-10-05 11:37 ` [PATCH v2 4/5] KVM: arm64: Prevent re-finalisation of pKVM for a given CPU Will Deacon
2021-10-05 11:37 ` [PATCH v2 5/5] KVM: arm64: Disable privileged hypercalls after pKVM finalisation Will Deacon
2021-10-07 12:56 ` Marc Zyngier
2021-10-08 7:27 ` Will Deacon
2021-10-08 7:31 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf74e6afcf1988ab7fcb87eb20bb2947@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=qperret@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).