From: Neil Armstrong <narmstrong@baylibre.com>
To: dri-devel <dri-devel@lists.freedesktop.org>,
linux-amlogic@lists.infradead.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH v5 1/8] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression
Date: Tue, 21 Apr 2020 15:14:35 +0200 [thread overview]
Message-ID: <cf9811b6-ecf3-98af-f2ae-73c491a53050@baylibre.com> (raw)
In-Reply-To: <20200421121641.GU3456981@phenom.ffwll.local>
On 21/04/2020 14:16, Daniel Vetter wrote:
> On Mon, Apr 20, 2020 at 12:21:24PM +0200, Neil Armstrong wrote:
>> On 17/04/2020 20:14, Daniel Vetter wrote:
>>> On Fri, Apr 17, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>>
>>>> On 17/04/2020 17:07, Daniel Vetter wrote:
>>
>> [...]
>>
>>>
>>> Yup there's a number of parametried modifiers. As long as the stuff
>>> you get from a DRM_FORMAT_MOD_ ... macro is a full modifier with
>>> everything it should be all fine.
>>
>> Would something like that be ok ?
>>
>> #define __fourcc_mod_amlogic_layout_mask 0xf
>> #define __fourcc_mod_amlogic_options_shift 8
>> #define __fourcc_mod_amlogic_options_mask 0xf
>>
>> #define DRM_FORMAT_MOD_AMLOGIC_FBC(__layout, __options) \
>> fourcc_mod_code(AMLOGIC, \
>> ((__layout) & __fourcc_mod_amlogic_layout_mask) | \
>> ((options) & __fourcc_mod_amlogic_options_mask \
>> << __fourcc_mod_amlogic_options_shift))
>>
>> /* Amlogic FBC Layouts */
>>
>> /* bla */
>> #define AMLOGIC_FBC_LAYOUT_BASIC (1ULL)
>>
>> /* bla */
>> #define AMLOGIC_FBC_LAYOUT_SCATTER (2ULL)
>>
>> /* Amlogic FBC Layout Options Bit Mask */
>>
>> /* bla */
>> #define AMLOGIC_FBC_OPTION_MEM_SAVING (1ULL << 0)
>
> lgtm.
> -Daniel
Thanks,
Re-sending with this.
Neil
>
>>
>> Neil
>>
>>> -Daniel
>>>
>>>> Neil
>>>>
>>>>> -Daniel
>>>>>
>>>>>> +
>>>>>> #if defined(__cplusplus)
>>>>>> }
>>>>>> #endif
>>>>>> --
>>>>>> 2.22.0
>>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> dri-devel mailing list
>>>> dri-devel@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>>
>>>
>>>
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-21 13:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 15:24 [PATCH v5 0/8] drm/meson: add support for Amlogic Video FBC Neil Armstrong
2020-04-16 15:24 ` [PATCH v5 1/8] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression Neil Armstrong
2020-04-17 15:07 ` Daniel Vetter
2020-04-17 16:05 ` Neil Armstrong
2020-04-17 16:11 ` Neil Armstrong
2020-04-17 18:14 ` Daniel Vetter
2020-04-20 10:21 ` Neil Armstrong
2020-04-21 12:16 ` Daniel Vetter
2020-04-21 13:14 ` Neil Armstrong [this message]
2020-04-16 15:24 ` [PATCH v5 2/8] drm/meson: add Amlogic Video FBC registers Neil Armstrong
2020-04-16 15:24 ` [PATCH v5 3/8] drm/meson: overlay: setup overlay for Amlogic FBC Neil Armstrong
2020-04-16 15:24 ` [PATCH v5 4/8] drm/meson: crtc: handle commit of Amlogic FBC frames Neil Armstrong
2020-04-16 15:24 ` [PATCH v5 5/8] drm/fourcc: amlogic: Add modifier definitions for Memory Saving option Neil Armstrong
2020-04-16 15:24 ` [PATCH v5 6/8] drm/meson: overlay: setup overlay for Amlogic FBC Memory Saving mode Neil Armstrong
2020-04-16 15:24 ` [PATCH v5 7/8] drm/fourcc: amlogic: Add modifier definitions for the Scatter layout Neil Armstrong
2020-04-16 15:25 ` [PATCH v5 8/8] drm/meson: overlay: setup overlay for Amlogic FBC Scatter Memory layout Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf9811b6-ecf3-98af-f2ae-73c491a53050@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox