From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7159C4345F for ; Fri, 26 Apr 2024 00:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qGR6Etv+2a5qjiob8vIdmZfDrYDXI+4zjyjxvV2dqWI=; b=Q/zkj3QvnYHDen f+PUb0Yl8B6xcBRjgHVZuicXSIS3mRGuPer3q+4H9dn/LxExAu9YyY4HBiOreygjAvg+Zb6nynV6y vAyzXYktifLFIP98BKq84/Tscbu5jfnCMBCk2x6f1MpJOtA0RuskrQqsczspLS20Pj3NMbuo/uiUI S+JHQPjMha7kMeoS3ctHPAPKk7tjXawTcMPbBmI59i1sH9/PVlLrLgjrg80BZnl+6p6HvqT1m9vAj //pov3RCcrJZrN3GI2laEP0Gn5ft4r/f82n1Tj/Wj6JKosP+UW6uHMAl7aOES05WP3q4ZptXt5a3Q EkgEKn4Wy0JvspRN2ZNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s09vn-0000000AkwD-3nGF; Fri, 26 Apr 2024 00:59:15 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s09vk-0000000AkvW-11m6 for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 00:59:14 +0000 Received: from [192.168.68.112] (ppp14-2-127-66.adl-apt-pir-bras32.tpg.internode.on.net [14.2.127.66]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 7711320075; Fri, 26 Apr 2024 08:59:09 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1714093150; bh=MAnTooQ3NWgoEkJO0tXSf39pJZ1lMIpBC5h/JQHXvew=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=jZHya2SQ6YJ7VWUlGZbqB0aMCTZfYXBAsGHhVoMIGiACDXu8l7aI9qVxqPF6RStCa /trLlmZPQAPAeGw9kVikC96f+Ur0+azQhWR3z3lXgosxtyh/Igijl0xzPTHjX/mv/z kK77IgFgLZkNAWpa0x+wsDuh0CfA1sbFWhtVczMiwjd1dEYlIfFAJNZZQ6OZV9O/YP t1CBaTlDYVgRgk1wNcq0eAuw39LeRq8KIl3Pdj7k5fEjGzdl0WJQTs+r92bEuDtBiV jgAiObK3rdJKlKiRnv6qm98UTa9rW+OnY/rU1VIpEH5P6lET5M70qLCaXpVPPq4sab oS/3+SJ8rYPWg== Message-ID: Subject: Re: [PATCH v1 2/2] Add nct7363 in yosemite4 dts From: Andrew Jeffery To: Delphine CC Chiu , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 26 Apr 2024 10:29:08 +0930 In-Reply-To: <20240425060626.2558515-3-Delphine_CC_Chiu@wiwynn.com> References: <20240425060626.2558515-1-Delphine_CC_Chiu@wiwynn.com> <20240425060626.2558515-3-Delphine_CC_Chiu@wiwynn.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_175913_143720_5A151B9F X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-04-25 at 14:06 +0800, Delphine CC Chiu wrote: > ARM: dts: aspeed: yosemite4: This should be in the patch subject, not the commit message body. > Add nct7363(0x21 and 0x23) in yosemite4.dts > > Signed-off-by: Delphine CC Chiu > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index e45293762316..06b709b0a706 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -467,6 +467,42 @@ channel@5 { > }; > }; > > + hwmon0: hwmon@21 { I feel hwmon describes a subsystem in linux more than it does hardware, and using it for a node name feels a bit off to me. It's not listed in the devicetree spec (v0.4) as a recommended generic name, and is only used in a handful of devicetrees - two of which are ancient BMC devicetrees: ((v6.9-rc5)) $ git grep -l hwmon@ -- arch/arm/boot/dts/ arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts arch/arm/boot/dts/aspeed/aspeed-bmc-opp-vesnin.dts arch/arm/boot/dts/intel/ixp/intel-ixp42x-freecom-fsg-3.dts arch/arm/boot/dts/intel/ixp/intel-ixp42x-gateworks-gw2348.dts arch/arm/boot/dts/intel/ixp/intel-ixp43x-gateworks-gw2358.dts arch/arm/boot/dts/marvell/armada-370-c200-v2.dts arch/arm/boot/dts/marvell/armada-385-atl-x530.dts arch/arm/boot/dts/microchip/lan966x.dtsi arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval-v1.2.dts arch/arm/boot/dts/xilinx/zynq-zc702.dts > + compatible = "nuvoton,nct7363"; This compatible seems to be undocumented as of v6.9-rc5? Should you also send a binding patch? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel