From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: pm: remove useless extern definition
Date: Tue, 27 Sep 2016 13:58:10 +0200 [thread overview]
Message-ID: <cfbb320a-4fc1-4e00-5ceb-632bf0a3da67@atmel.com> (raw)
In-Reply-To: <20160927103715.26785-1-alexandre.belloni@free-electrons.com>
Le 27/09/2016 ? 12:37, Alexandre Belloni a ?crit :
> at91_ramc_base is local to pm.c, remove its definition in pm.h
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/mach-at91/pm.c | 2 +-
> arch/arm/mach-at91/pm.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index b4332b727e9c..3d89b7905bd9 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -55,7 +55,7 @@ static struct {
> int memctrl;
> } at91_pm_data;
>
> -void __iomem *at91_ramc_base[2];
> +static void __iomem *at91_ramc_base[2];
>
> static int at91_pm_valid_state(suspend_state_t state)
> {
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 3fcf8810f14e..bf980c6ef294 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -18,8 +18,6 @@
> #include <soc/at91/at91sam9_sdramc.h>
>
> #ifndef __ASSEMBLY__
> -extern void __iomem *at91_ramc_base[];
> -
> #define at91_ramc_read(id, field) \
> __raw_readl(at91_ramc_base[id] + field)
>
>
--
Nicolas Ferre
prev parent reply other threads:[~2016-09-27 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 10:37 [PATCH] ARM: at91: pm: remove useless extern definition Alexandre Belloni
2016-09-27 11:58 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfbb320a-4fc1-4e00-5ceb-632bf0a3da67@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox