From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E74F1D1A431 for ; Sat, 12 Oct 2024 05:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hvDr0hBqceMPoqKr59VTJA2PMmkK0w6bfmvafMG1XxI=; b=v1Mzhdq8a5dCCXEKf7xlGxPaJ/ P8kc+JrhJ6Ebks6Grkd95mzHCwNlp5gYLgmRl9oJEev3dLRKHwUu8q5wIGqiqw63KdhO9Dj2utIAz r5Xz2RHVgb+uxuXm35kG+nS6XvKHkX/fcqwxWDtA0ClgXHNB/AuZgbA+ir7glMTAe7B0wzgCROt24 V63w9/FrTFL+rg0NorkukIcVP2d4EBtARHPBJz1/vvWluKs81OyrA2GDz86Vbzv7zOfaR2ciPt9SY wdmv8mVB0Pwu8O3rVd4g9gtAd3DqYK4qcSC9C3MF6GrIZsWuxYfreRKpEJAbX7fbS5DuLj/nIMexx xUOce1Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szUbV-00000000ZAE-3OkI; Sat, 12 Oct 2024 05:23:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szUa7-00000000Z4n-39xv for linux-arm-kernel@lists.infradead.org; Sat, 12 Oct 2024 05:22:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728710540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hvDr0hBqceMPoqKr59VTJA2PMmkK0w6bfmvafMG1XxI=; b=Dm5/+cMVNBzbfRqv+ROUMIs/ZQgIP7hqP8GzPLpnUyePti5UfztUwUwpDN3pLUrP6q/mKC qUfXxC9GUKgWby7TwaBQwejXEzhlA602YpHv1nbzOdKGAXd4c1gKtwVSwsOhmghDKiywl/ 68po9XIonYtIKxu7vL+Ig6MJECq6PQM= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-WFEKZb0_MW2zvd4A0j8RcA-1; Sat, 12 Oct 2024 01:22:18 -0400 X-MC-Unique: WFEKZb0_MW2zvd4A0j8RcA-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-20c8a637b77so34192005ad.2 for ; Fri, 11 Oct 2024 22:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728710536; x=1729315336; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvDr0hBqceMPoqKr59VTJA2PMmkK0w6bfmvafMG1XxI=; b=ESEGXXqmwS6aj5HsHbvxIweLqJqPRrPyuTY6p0v2DNKun3y78PiJdG/p0H4RQ8zKmA +OCse5CXTJX2ZqKXH0MB39oNQA+yPdaPj7oUSi0lzkPDBBDDy1XkVfSRZOQyQxqdw5aD LnzHzj3uUtSneb1WOpB2V2U5o0K119wx6V3bLw4JOmiCD31294X4qa413DEZq/SHVpRx lQIw7R1UHLnwvWcZtJw6w4GbjszJ5tPTtnqk9FZMDUaATI14I2RvodgoGQdNITRQTdAC vWms0Si/e9tdqmnpdIaCGHKYiuBfw5kPGbYXIXC6TrZjP4bzHuYIHOmoPNKBtOszn7/P qLfw== X-Forwarded-Encrypted: i=1; AJvYcCWGETGOIhoVpK7aWZnC0bXraG10MGnW5/OFBJz/oH8iRbJmj7TVWOtw0KpmaePD6Jaj3AnKKoBC15sPROuV11kn@lists.infradead.org X-Gm-Message-State: AOJu0Yy8+hNu2mkYViawchSNLqNF4o/JoqifNDwTJhzb8lCQfZFjgwUJ selAFP2dqUAoEaA39asIxtnBTlx0NECJpycrkaisUan+WoBMT5CcOtfnNoVefY39FK5U6OwAWuu Qn+sUocKIVujqnrb1TXJVsw4D3BpGG+sohD6ehvUSvz01OTLsWwcbSaT8OSeIgBSmyk2W8I+8 X-Received: by 2002:a17:903:2292:b0:20c:be0e:d47e with SMTP id d9443c01a7336-20cbe0ed77fmr27330115ad.56.1728710536131; Fri, 11 Oct 2024 22:22:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPdfPL4sLDuZbuEZ8hOCaoZXNRre8SGr7tfbn9VtHIuESumtQnMGZco/QwYJ9wvIb8IjS+5g== X-Received: by 2002:a17:903:2292:b0:20c:be0e:d47e with SMTP id d9443c01a7336-20cbe0ed77fmr27329915ad.56.1728710535801; Fri, 11 Oct 2024 22:22:15 -0700 (PDT) Received: from [192.168.68.54] ([180.233.125.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c33fdf9sm31443385ad.260.2024.10.11.22.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 22:22:15 -0700 (PDT) Message-ID: Date: Sat, 12 Oct 2024 15:22:06 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 05/11] arm64: rsi: Map unprotected MMIO as decrypted To: Catalin Marinas Cc: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev, Suzuki K Poulose , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" References: <20241004144307.66199-1-steven.price@arm.com> <20241004144307.66199-6-steven.price@arm.com> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_222223_909679_5CE7E714 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/11/24 11:19 PM, Catalin Marinas wrote: > On Tue, Oct 08, 2024 at 10:31:06AM +1000, Gavin Shan wrote: >> On 10/5/24 12:43 AM, Steven Price wrote: >>> diff --git a/arch/arm64/kernel/rsi.c b/arch/arm64/kernel/rsi.c >>> index d7bba4cee627..f1add76f89ce 100644 >>> --- a/arch/arm64/kernel/rsi.c >>> +++ b/arch/arm64/kernel/rsi.c >>> @@ -6,6 +6,8 @@ >>> #include >>> #include >>> #include >>> + >>> +#include >>> #include >>> struct realm_config config; >>> @@ -92,6 +94,16 @@ bool arm64_is_protected_mmio(phys_addr_t base, size_t size) >>> } >>> EXPORT_SYMBOL(arm64_is_protected_mmio); >>> +static int realm_ioremap_hook(phys_addr_t phys, size_t size, pgprot_t *prot) >>> +{ >>> + if (arm64_is_protected_mmio(phys, size)) >>> + *prot = pgprot_encrypted(*prot); >>> + else >>> + *prot = pgprot_decrypted(*prot); >>> + >>> + return 0; >>> +} >>> + >> >> We probably need arm64_is_mmio_private() here, meaning arm64_is_protected_mmio() isn't >> sufficient to avoid invoking SMCCC call SMC_RSI_IPA_STATE_GET in a regular guest where >> realm capability isn't present. > > I think we get away with this since the hook won't be registered in a > normal guest (done from arm64_rsi_init()). So the additional check in > arm64_is_mmio_private() is unnecessary. > Indeed. I missed the point that the hook won't be registered for a normal guest. So we're good and safe. Thanks, Gavin