From: <Claudiu.Beznea@microchip.com>
To: <broonie@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Codrin.Ciubotariu@microchip.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 2/2] ARM: dts: at91: Describe regulators on at91sam9g20ek
Date: Wed, 30 Mar 2022 13:09:56 +0000 [thread overview]
Message-ID: <cfdfa402-cb6f-2482-2ff7-3aa6cb488136@microchip.com> (raw)
In-Reply-To: <20220325152715.1597893-3-broonie@kernel.org>
On 25.03.2022 17:27, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The at91sam9g20ek has no software controllable regulators, only some fixed
> discrete regulators, but they are there and currently the wm8731 driver
> does try to use them. Show the supplies in the DT and map them for the
> wm8731 so things start up cleanly.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/boot/dts/at91sam9g20ek_common.dtsi | 36 +++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> index ca03685f0f08..88cf3ab40aa6 100644
> --- a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> @@ -225,6 +225,11 @@ wm8731: wm8731@1b {
> clock-names = "mclk";
> assigned-clocks = <&pmc PMC_TYPE_SYSTEM 8>;
> assigned-clock-rates = <12000000>;
> +
> + HPVDD-supply = <&vcc_dac>;
> + AVDD-supply = <&vcc_dac>;
> + DCVDD-supply = <®_3v3>;
> + DBVDD-supply = <®_3v3>;
> };
> };
>
> @@ -260,4 +265,35 @@ sound {
> atmel,ssc-controller = <&ssc0>;
> atmel,audio-codec = <&wm8731>;
> };
> +
> + reg_5v: fixedregulator0 {
> + compatible = "regulator-fixed";
> + regulator-name = "5V";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> + reg_3v3: fixedregulator1 {
> + compatible = "regulator-fixed";
> + regulator-name = "3V3";
> + vin-supply = <®_5v>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + reg_1v: fixedregulator2 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V";
> + vin-supply = <®_5v>;
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + };
> +
> + vcc_dac: fixedregulator3 {
> + compatible = "regulator-fixed";
> + regulator-name = "VCC_DAC";
> + vin-supply = <®_3v3>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> };
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-03-30 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 15:27 [PATCH v1 0/2] ARM: dts: at91: Fixes for AT91SAM9G20-EK audio DTS Mark Brown
2022-03-25 15:27 ` [PATCH v1 1/2] ARM: dts: at91: Map MCLK for wm8731 on at91sam9g20ek Mark Brown
2022-03-30 13:09 ` Claudiu.Beznea
2022-03-25 15:27 ` [PATCH v1 2/2] ARM: dts: at91: Describe regulators " Mark Brown
2022-03-30 13:09 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfdfa402-cb6f-2482-2ff7-3aa6cb488136@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).