* ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
@ 2019-10-29 23:43 CKI Project
2019-10-30 10:03 ` Jan Stancek
2019-10-30 10:06 ` Will Deacon
0 siblings, 2 replies; 11+ messages in thread
From: CKI Project @ 2019-10-29 23:43 UTC (permalink / raw)
To: will, catalin.marinas, linux-arm-kernel; +Cc: Memory Management, Jan Stancek
Hello,
We ran automated tests on a recent commit from this kernel tree:
Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
Commit: 34072e52a3fc - Merge remote-tracking branch 'arm64/for-next/memory-hotremove' into for-kernelci
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Merge: OK
Compile: OK
Tests: FAILED
All kernel binaries, config files, and logs are available for download here:
https://artifacts.cki-project.org/pipelines/255362
One or more kernel tests failed:
aarch64:
❌ LTP lite
We hope that these logs can help you find the problem quickly. For the full
detail on our testing procedures, please scroll to the bottom of this message.
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Compile testing
---------------
We compiled the kernel for 1 architecture:
aarch64:
make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg
Hardware testing
----------------
We booted each kernel and ran the following tests:
aarch64:
Host 1:
✅ Boot test
✅ xfstests: ext4
✅ xfstests: xfs
✅ selinux-policy: serge-testsuite
✅ lvm thinp sanity
✅ storage: software RAID testing
🚧 ✅ Storage blktests
Host 2:
✅ Boot test
✅ Podman system integration test (as root)
✅ Podman system integration test (as user)
❌ LTP lite
✅ Loopdev Sanity
✅ jvm test suite
✅ Memory function: memfd_create
✅ Memory function: kaslr
✅ AMTU (Abstract Machine Test Utility)
✅ LTP: openposix test suite
✅ Ethernet drivers sanity
✅ Networking MACsec: sanity
✅ Networking socket: fuzz
✅ Networking sctp-auth: sockopts test
✅ Networking: igmp conformance test
✅ Networking route: pmtu
✅ Networking TCP: keepalive test
✅ Networking UDP: socket
✅ Networking tunnel: geneve basic test
✅ Networking tunnel: gre basic
✅ Networking tunnel: vxlan basic
✅ audit: audit testsuite test
✅ httpd: mod_ssl smoke sanity
✅ iotop: sanity
✅ tuned: tune-processes-through-perf
✅ ALSA PCM loopback test
✅ ALSA Control (mixer) Userspace Element test
✅ Usex - version 1.9-29
✅ storage: SCSI VPD
✅ stress: stress-ng
✅ trace: ftrace/tracer
🚧 ✅ CIFS Connectathon
🚧 ✅ POSIX pjd-fstest suites
🚧 ✅ Networking bridge: sanity
🚧 ✅ Networking route_func: local
✅ Networking route_func: forward
🚧 ✅ L2TP basic test
🚧 ✅ Networking vnic: ipvlan/basic
🚧 ✅ storage: dm/common
🚧 ✅ Networking ipsec: basic netns transport
🚧 ✅ Networking ipsec: basic netns tunnel
Test sources: https://github.com/CKI-project/tests-beaker
💚 Pull requests are welcome for new tests or improvements to existing tests!
Waived tests
------------
If the test run included waived tests, they are marked with 🚧. Such tests are
executed but their results are not taken into account. Tests are waived when
their results are not reliable enough, e.g. when they're just introduced or are
being fixed.
Testing timeout
---------------
We aim to provide a report within reasonable timeframe. Tests that haven't
finished running are marked with ⏱. Reports for non-upstream kernels have
a Beaker recipe linked to next to each host.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-29 23:43 ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next) CKI Project
@ 2019-10-30 10:03 ` Jan Stancek
2019-10-30 10:07 ` Will Deacon
2019-10-30 10:06 ` Will Deacon
1 sibling, 1 reply; 11+ messages in thread
From: Jan Stancek @ 2019-10-30 10:03 UTC (permalink / raw)
To: will, linux-arm-kernel, catalin marinas; +Cc: Memory Management, CKI Project
----- Original Message -----
>
> Hello,
>
> We ran automated tests on a recent commit from this kernel tree:
>
> Kernel repo:
> git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> Commit: 34072e52a3fc - Merge remote-tracking branch
> 'arm64/for-next/memory-hotremove' into for-kernelci
>
> The results of these automated tests are provided below.
>
> Overall result: FAILED (see details below)
> Merge: OK
> Compile: OK
> Tests: FAILED
>
> All kernel binaries, config files, and logs are available for download here:
>
> https://artifacts.cki-project.org/pipelines/255362
>
> One or more kernel tests failed:
>
> aarch64:
> ❌ LTP lite
What's failing is preadv2/readv over PROT_NONE mapping:
[pid 2424] mmap(NULL, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0) = 0x3ff7f8b0000
[pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000, iov_len=64}], 1, 0, 0) = 16
Test expects EFAULT.
It seems specific to arm64/linux.git as I do not see it fail on
Linus' master (v5.4-rc5-34-g23fdb198ae81).
Regards,
Jan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-29 23:43 ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next) CKI Project
2019-10-30 10:03 ` Jan Stancek
@ 2019-10-30 10:06 ` Will Deacon
2019-10-30 11:02 ` Jan Stancek
1 sibling, 1 reply; 11+ messages in thread
From: Will Deacon @ 2019-10-30 10:06 UTC (permalink / raw)
To: CKI Project
Cc: catalin.marinas, Memory Management, Jan Stancek, linux-arm-kernel
Hi all,
On Tue, Oct 29, 2019 at 11:43:13PM -0000, CKI Project wrote:
> We ran automated tests on a recent commit from this kernel tree:
>
> Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> Commit: 34072e52a3fc - Merge remote-tracking branch 'arm64/for-next/memory-hotremove' into for-kernelci
>
> The results of these automated tests are provided below.
>
> Overall result: FAILED (see details below)
> Merge: OK
> Compile: OK
> Tests: FAILED
>
> All kernel binaries, config files, and logs are available for download here:
>
> https://artifacts.cki-project.org/pipelines/255362
>
> One or more kernel tests failed:
>
> aarch64:
> ❌ LTP lite
As far as I can make out from the logs, this is because the following
syscall tests failed:
preadv202
preadv202_64
readv02
Before I go digging deeper, is it possible to see whether these pass on
a vanilla 5.4-rc5 kernel? I couldn't figure out a way to translate
"v5.4-rc5" into a directory under https://artifacts.cki-project.org/pipelines/
which would let me see if we've regressed in the arm64 tree.
Thanks,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 10:03 ` Jan Stancek
@ 2019-10-30 10:07 ` Will Deacon
2019-10-30 10:45 ` Will Deacon
0 siblings, 1 reply; 11+ messages in thread
From: Will Deacon @ 2019-10-30 10:07 UTC (permalink / raw)
To: Jan Stancek
Cc: catalin marinas, Memory Management, CKI Project, linux-arm-kernel
On Wed, Oct 30, 2019 at 06:03:56AM -0400, Jan Stancek wrote:
>
>
> ----- Original Message -----
> >
> > Hello,
> >
> > We ran automated tests on a recent commit from this kernel tree:
> >
> > Kernel repo:
> > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> > Commit: 34072e52a3fc - Merge remote-tracking branch
> > 'arm64/for-next/memory-hotremove' into for-kernelci
> >
> > The results of these automated tests are provided below.
> >
> > Overall result: FAILED (see details below)
> > Merge: OK
> > Compile: OK
> > Tests: FAILED
> >
> > All kernel binaries, config files, and logs are available for download here:
> >
> > https://artifacts.cki-project.org/pipelines/255362
> >
> > One or more kernel tests failed:
> >
> > aarch64:
> > ❌ LTP lite
>
> What's failing is preadv2/readv over PROT_NONE mapping:
>
> [pid 2424] mmap(NULL, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0) = 0x3ff7f8b0000
> [pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000, iov_len=64}], 1, 0, 0) = 16
>
> Test expects EFAULT.
>
> It seems specific to arm64/linux.git as I do not see it fail on
> Linus' master (v5.4-rc5-34-g23fdb198ae81).
Aha, our emails crossed paths. Thanks, I'll try to reproduce the failure
locally.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 10:07 ` Will Deacon
@ 2019-10-30 10:45 ` Will Deacon
2019-10-30 11:42 ` Robin Murphy
0 siblings, 1 reply; 11+ messages in thread
From: Will Deacon @ 2019-10-30 10:45 UTC (permalink / raw)
To: Jan Stancek
Cc: catalin marinas, Memory Management, robin.murphy, CKI Project,
linux-arm-kernel
[+Robin as FYI]
On Wed, Oct 30, 2019 at 10:07:47AM +0000, Will Deacon wrote:
> On Wed, Oct 30, 2019 at 06:03:56AM -0400, Jan Stancek wrote:
> > > We ran automated tests on a recent commit from this kernel tree:
> > >
> > > Kernel repo:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> > > Commit: 34072e52a3fc - Merge remote-tracking branch
> > > 'arm64/for-next/memory-hotremove' into for-kernelci
> > >
> > > The results of these automated tests are provided below.
> > >
> > > Overall result: FAILED (see details below)
> > > Merge: OK
> > > Compile: OK
> > > Tests: FAILED
> > >
> > > All kernel binaries, config files, and logs are available for download here:
> > >
> > > https://artifacts.cki-project.org/pipelines/255362
> > >
> > > One or more kernel tests failed:
> > >
> > > aarch64:
> > > ❌ LTP lite
> >
> > What's failing is preadv2/readv over PROT_NONE mapping:
> >
> > [pid 2424] mmap(NULL, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0) = 0x3ff7f8b0000
> > [pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000, iov_len=64}], 1, 0, 0) = 16
> >
> > Test expects EFAULT.
> >
> > It seems specific to arm64/linux.git as I do not see it fail on
> > Linus' master (v5.4-rc5-34-g23fdb198ae81).
>
> Aha, our emails crossed paths. Thanks, I'll try to reproduce the failure
> locally.
Looks like the rewrite of our string routines has broken the return value
for some syscalls:
readv02 2 TFAIL : readv02.c:145: Error: readv returned a positive value
preadv202.c:87: FAIL: preadv2() failed unexpectedly, expected EFAULT: SUCCESS (0)
preadv202.c:87: FAIL: preadv2() failed unexpectedly, expected EFAULT: SUCCESS (0)
We'll drop the for-next/cortex-strings branch for now.
Thanks,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 10:06 ` Will Deacon
@ 2019-10-30 11:02 ` Jan Stancek
2019-10-30 12:37 ` Rachel Sibley
0 siblings, 1 reply; 11+ messages in thread
From: Jan Stancek @ 2019-10-30 11:02 UTC (permalink / raw)
To: CKI Project, Rachel Sibley
Cc: catalin marinas, Memory Management, Will Deacon, linux-arm-kernel
----- Original Message -----
> Hi all,
>
> On Tue, Oct 29, 2019 at 11:43:13PM -0000, CKI Project wrote:
> > We ran automated tests on a recent commit from this kernel tree:
> >
> > Kernel repo:
> > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> > Commit: 34072e52a3fc - Merge remote-tracking branch
> > 'arm64/for-next/memory-hotremove' into for-kernelci
> >
> > The results of these automated tests are provided below.
> >
> > Overall result: FAILED (see details below)
> > Merge: OK
> > Compile: OK
> > Tests: FAILED
> >
> > All kernel binaries, config files, and logs are available for download
> > here:
> >
> > https://artifacts.cki-project.org/pipelines/255362
> >
> > One or more kernel tests failed:
> >
> > aarch64:
> > ❌ LTP lite
>
> As far as I can make out from the logs, this is because the following
> syscall tests failed:
>
> preadv202
> preadv202_64
> readv02
@CKI: There seem to be only high level test status?
Can you upload also verbose test output to artifacts?
The file is usually named *.run.log. It gives much better details for failures:
tst_test.c:1116: INFO: Timeout per run is 0h 05m 00s
preadv202.c:82: PASS: preadv2() failed as expected: EINVAL (22)
preadv202.c:82: PASS: preadv2() failed as expected: EINVAL (22)
preadv202.c:82: PASS: preadv2() failed as expected: EOPNOTSUPP (95)
preadv202.c:86: FAIL: preadv2() failed unexpectedly, expected EFAULT: SUCCESS (0)
preadv202.c:82: PASS: preadv2() failed as expected: EBADF (9)
preadv202.c:82: PASS: preadv2() failed as expected: EBADF (9)
preadv202.c:82: PASS: preadv2() failed as expected: EISDIR (21)
preadv202.c:82: PASS: preadv2() failed as expected: ESPIPE (29)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 10:45 ` Will Deacon
@ 2019-10-30 11:42 ` Robin Murphy
2019-10-30 15:08 ` Robin Murphy
0 siblings, 1 reply; 11+ messages in thread
From: Robin Murphy @ 2019-10-30 11:42 UTC (permalink / raw)
To: Will Deacon, Jan Stancek
Cc: catalin marinas, Memory Management, CKI Project, linux-arm-kernel
On 30/10/2019 10:45, Will Deacon wrote:
> [+Robin as FYI]
>
> On Wed, Oct 30, 2019 at 10:07:47AM +0000, Will Deacon wrote:
>> On Wed, Oct 30, 2019 at 06:03:56AM -0400, Jan Stancek wrote:
>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>
>>>> Kernel repo:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
>>>> Commit: 34072e52a3fc - Merge remote-tracking branch
>>>> 'arm64/for-next/memory-hotremove' into for-kernelci
>>>>
>>>> The results of these automated tests are provided below.
>>>>
>>>> Overall result: FAILED (see details below)
>>>> Merge: OK
>>>> Compile: OK
>>>> Tests: FAILED
>>>>
>>>> All kernel binaries, config files, and logs are available for download here:
>>>>
>>>> https://artifacts.cki-project.org/pipelines/255362
>>>>
>>>> One or more kernel tests failed:
>>>>
>>>> aarch64:
>>>> ❌ LTP lite
>>>
>>> What's failing is preadv2/readv over PROT_NONE mapping:
>>>
>>> [pid 2424] mmap(NULL, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0) = 0x3ff7f8b0000
>>> [pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000, iov_len=64}], 1, 0, 0) = 16
>>>
>>> Test expects EFAULT.
>>>
>>> It seems specific to arm64/linux.git as I do not see it fail on
>>> Linus' master (v5.4-rc5-34-g23fdb198ae81).
>>
>> Aha, our emails crossed paths. Thanks, I'll try to reproduce the failure
>> locally.
>
> Looks like the rewrite of our string routines has broken the return value
> for some syscalls:
Urgh... Thanks for the report. I was pretty sure we had the fault
handler correct, so I'll fire up the debugger and try to figure out
what's up.
Robin.
> readv02 2 TFAIL : readv02.c:145: Error: readv returned a positive value
> preadv202.c:87: FAIL: preadv2() failed unexpectedly, expected EFAULT: SUCCESS (0)
> preadv202.c:87: FAIL: preadv2() failed unexpectedly, expected EFAULT: SUCCESS (0)
>
> We'll drop the for-next/cortex-strings branch for now.
>
> Thanks,
>
> Will
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 11:02 ` Jan Stancek
@ 2019-10-30 12:37 ` Rachel Sibley
0 siblings, 0 replies; 11+ messages in thread
From: Rachel Sibley @ 2019-10-30 12:37 UTC (permalink / raw)
To: Jan Stancek, CKI Project
Cc: catalin marinas, Memory Management, Will Deacon, linux-arm-kernel
On 10/30/19 7:02 AM, Jan Stancek wrote:
>
> ----- Original Message -----
>> Hi all,
>>
>> On Tue, Oct 29, 2019 at 11:43:13PM -0000, CKI Project wrote:
>>> We ran automated tests on a recent commit from this kernel tree:
>>>
>>> Kernel repo:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
>>> Commit: 34072e52a3fc - Merge remote-tracking branch
>>> 'arm64/for-next/memory-hotremove' into for-kernelci
>>>
>>> The results of these automated tests are provided below.
>>>
>>> Overall result: FAILED (see details below)
>>> Merge: OK
>>> Compile: OK
>>> Tests: FAILED
>>>
>>> All kernel binaries, config files, and logs are available for download
>>> here:
>>>
>>> https://artifacts.cki-project.org/pipelines/255362
>>>
>>> One or more kernel tests failed:
>>>
>>> aarch64:
>>> ❌ LTP lite
>> As far as I can make out from the logs, this is because the following
>> syscall tests failed:
>>
>> preadv202
>> preadv202_64
>> readv02
> @CKI: There seem to be only high level test status?
> Can you upload also verbose test output to artifacts?
>
> The file is usually named *.run.log. It gives much better details for failures:
>
> tst_test.c:1116: INFO: Timeout per run is 0h 05m 00s
> preadv202.c:82: PASS: preadv2() failed as expected: EINVAL (22)
> preadv202.c:82: PASS: preadv2() failed as expected: EINVAL (22)
> preadv202.c:82: PASS: preadv2() failed as expected: EOPNOTSUPP (95)
> preadv202.c:86: FAIL: preadv2() failed unexpectedly, expected EFAULT: SUCCESS (0)
> preadv202.c:82: PASS: preadv2() failed as expected: EBADF (9)
> preadv202.c:82: PASS: preadv2() failed as expected: EBADF (9)
> preadv202.c:82: PASS: preadv2() failed as expected: EISDIR (21)
> preadv202.c:82: PASS: preadv2() failed as expected: ESPIPE (29)
Yes sorry about that, we'll work on uploading the missing logs for LTP.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 11:42 ` Robin Murphy
@ 2019-10-30 15:08 ` Robin Murphy
2019-10-31 11:06 ` Catalin Marinas
0 siblings, 1 reply; 11+ messages in thread
From: Robin Murphy @ 2019-10-30 15:08 UTC (permalink / raw)
To: Will Deacon, catalin marinas
Cc: linux-arm-kernel, Memory Management, Jan Stancek, CKI Project
On 30/10/2019 11:42, Robin Murphy wrote:
> On 30/10/2019 10:45, Will Deacon wrote:
>> [+Robin as FYI]
>>
>> On Wed, Oct 30, 2019 at 10:07:47AM +0000, Will Deacon wrote:
>>> On Wed, Oct 30, 2019 at 06:03:56AM -0400, Jan Stancek wrote:
>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>
>>>>> Kernel repo:
>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
>>>>> Commit: 34072e52a3fc - Merge remote-tracking branch
>>>>> 'arm64/for-next/memory-hotremove' into for-kernelci
>>>>>
>>>>> The results of these automated tests are provided below.
>>>>>
>>>>> Overall result: FAILED (see details below)
>>>>> Merge: OK
>>>>> Compile: OK
>>>>> Tests: FAILED
>>>>>
>>>>> All kernel binaries, config files, and logs are available for
>>>>> download here:
>>>>>
>>>>> https://artifacts.cki-project.org/pipelines/255362
>>>>>
>>>>> One or more kernel tests failed:
>>>>>
>>>>> aarch64:
>>>>> ❌ LTP lite
>>>>
>>>> What's failing is preadv2/readv over PROT_NONE mapping:
>>>>
>>>> [pid 2424] mmap(NULL, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0,
>>>> 0) = 0x3ff7f8b0000
>>>> [pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000, iov_len=64}], 1, 0,
>>>> 0) = 16
>>>>
>>>> Test expects EFAULT.
>>>>
>>>> It seems specific to arm64/linux.git as I do not see it fail on
>>>> Linus' master (v5.4-rc5-34-g23fdb198ae81).
>>>
>>> Aha, our emails crossed paths. Thanks, I'll try to reproduce the failure
>>> locally.
>>
>> Looks like the rewrite of our string routines has broken the return value
>> for some syscalls:
>
> Urgh... Thanks for the report. I was pretty sure we had the fault
> handler correct, so I'll fire up the debugger and try to figure out
> what's up.
OK, what's up is that we designed the improved fixup logic to support
offset addressing in the implicit context of the existing copy template,
where accesses were always in strictly increasing order. And then we
also plumbed in a clever new template which in certain cases does some
out-of-order copying to support overlaps :(
If a nonzero return from copy_*_user() is allowed to underestimate how
many bytes were actually copied, then I think there should be a
relatively simple fix; if it must always be exact, then I've got some
more thinking to do...
Robin.
>> readv02 2 TFAIL : readv02.c:145: Error: readv returned a
>> positive value
>> preadv202.c:87: FAIL: preadv2() failed unexpectedly, expected EFAULT:
>> SUCCESS (0)
>> preadv202.c:87: FAIL: preadv2() failed unexpectedly, expected EFAULT:
>> SUCCESS (0)
>>
>> We'll drop the for-next/cortex-strings branch for now.
>>
>> Thanks,
>>
>> Will
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-30 15:08 ` Robin Murphy
@ 2019-10-31 11:06 ` Catalin Marinas
2019-10-31 11:26 ` Will Deacon
0 siblings, 1 reply; 11+ messages in thread
From: Catalin Marinas @ 2019-10-31 11:06 UTC (permalink / raw)
To: Robin Murphy
Cc: linux-arm-kernel, Memory Management, Will Deacon, Jan Stancek,
CKI Project
On Wed, Oct 30, 2019 at 03:08:36PM +0000, Robin Murphy wrote:
> > > > On Wed, Oct 30, 2019 at 06:03:56AM -0400, Jan Stancek wrote:
> > > > > What's failing is preadv2/readv over PROT_NONE mapping:
> > > > >
> > > > > [pid 2424] mmap(NULL, 1, PROT_NONE,
> > > > > MAP_PRIVATE|MAP_ANONYMOUS, 0, 0) = 0x3ff7f8b0000
> > > > > [pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000,
> > > > > iov_len=64}], 1, 0, 0) = 16
> > > > >
> > > > > Test expects EFAULT.
> > > > >
> > > > > It seems specific to arm64/linux.git as I do not see it fail on
> > > > > Linus' master (v5.4-rc5-34-g23fdb198ae81).
[...]
> OK, what's up is that we designed the improved fixup logic to support offset
> addressing in the implicit context of the existing copy template, where
> accesses were always in strictly increasing order. And then we also plumbed
> in a clever new template which in certain cases does some out-of-order
> copying to support overlaps :(
>
> If a nonzero return from copy_*_user() is allowed to underestimate how many
> bytes were actually copied, then I think there should be a relatively simple
> fix; if it must always be exact, then I've got some more thinking to do...
I think in various incarnations of the copy routines we always had some
risk of underestimating. For example, we align the source but not the
destination. The destination is written via STP post-indexed but if the
second 64-bit write fails, we still report the copy based on the
unmodified dst, so underestimating by 8 bytes.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next)
2019-10-31 11:06 ` Catalin Marinas
@ 2019-10-31 11:26 ` Will Deacon
0 siblings, 0 replies; 11+ messages in thread
From: Will Deacon @ 2019-10-31 11:26 UTC (permalink / raw)
To: Catalin Marinas
Cc: linux-arm-kernel, Memory Management, Robin Murphy, Jan Stancek,
CKI Project
On Thu, Oct 31, 2019 at 11:06:55AM +0000, Catalin Marinas wrote:
> On Wed, Oct 30, 2019 at 03:08:36PM +0000, Robin Murphy wrote:
> > > > > On Wed, Oct 30, 2019 at 06:03:56AM -0400, Jan Stancek wrote:
> > > > > > What's failing is preadv2/readv over PROT_NONE mapping:
> > > > > >
> > > > > > [pid 2424] mmap(NULL, 1, PROT_NONE,
> > > > > > MAP_PRIVATE|MAP_ANONYMOUS, 0, 0) = 0x3ff7f8b0000
> > > > > > [pid 2424] preadv2(3, [{iov_base=0x3ff7f8b0000,
> > > > > > iov_len=64}], 1, 0, 0) = 16
> > > > > >
> > > > > > Test expects EFAULT.
> > > > > >
> > > > > > It seems specific to arm64/linux.git as I do not see it fail on
> > > > > > Linus' master (v5.4-rc5-34-g23fdb198ae81).
> [...]
> > OK, what's up is that we designed the improved fixup logic to support offset
> > addressing in the implicit context of the existing copy template, where
> > accesses were always in strictly increasing order. And then we also plumbed
> > in a clever new template which in certain cases does some out-of-order
> > copying to support overlaps :(
> >
> > If a nonzero return from copy_*_user() is allowed to underestimate how many
> > bytes were actually copied, then I think there should be a relatively simple
> > fix; if it must always be exact, then I've got some more thinking to do...
>
> I think in various incarnations of the copy routines we always had some
> risk of underestimating. For example, we align the source but not the
> destination. The destination is written via STP post-indexed but if the
> second 64-bit write fails, we still report the copy based on the
> unmodified dst, so underestimating by 8 bytes.
I wonder if this could be an issue in general though. If, for example, we
took a fault on the second page when crossing a page boundary, any "number
of bytes copied" metric returned to userspace probably needs to identify the
second page as the faulting one. Perhaps that works out because we only make
naturally-aligned accesses, but I'm not super comfortable about the
under-estimation. Do other architectures do that?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-10-31 11:26 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 23:43 ❌ FAIL: Test report for kernel 5.4.0-rc5-34072e5.cki (arm-next) CKI Project
2019-10-30 10:03 ` Jan Stancek
2019-10-30 10:07 ` Will Deacon
2019-10-30 10:45 ` Will Deacon
2019-10-30 11:42 ` Robin Murphy
2019-10-30 15:08 ` Robin Murphy
2019-10-31 11:06 ` Catalin Marinas
2019-10-31 11:26 ` Will Deacon
2019-10-30 10:06 ` Will Deacon
2019-10-30 11:02 ` Jan Stancek
2019-10-30 12:37 ` Rachel Sibley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).