linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 0/3] hwmon: GMT G72/G763 PWM fan controller
Date: Wed, 24 Apr 2013 00:05:43 +0200	[thread overview]
Message-ID: <cover.1366753420.git.arno@natisbad.org> (raw)
In-Reply-To: 20130419043555.GA14124@roeck-us.net

Hi,

This series adds support for GMT G762/G763. This work is based on a
basic version for 2.6.31 kernel developed Olivier Mouchet (kept as
author for this reason in g762.c) for LaCie NAS. Updates have been
performed to run on recent kernels. Supported has been completed and
additional features added: ability to configure various characteristics
from .dts file, better initialization, alarms and error reporting
support, gear mode, polarity, fan pulse per revolution, fan startup
voltage control. The following detailed datasheet has been used as a
basis for this work:

  http://natisbad.org/NAS/refs/GMT_EDS-762_763-080710-0.2.pdf

The patch was developed for and tested against the GMT G762 fan
controller used in a Netgear ReadyNAS Duo v2 (kirkwood 88F6282-based
NAS). This is the main reason for the device tree bindings provided in
first patch. The patches are against current ARM tree; tell me if you
need me to rebase it against something else.

Patch 2 and 3 provides documentation for the driver and DT bindings, 
respectively.

I hope the comments provided on v0 have all been correctly taken into
account. A list of changes is provided below.

Comments welcome,

Cheers,

a+

Changes since v0:
    Removed forward declaration 
    Used bool for 'valid' field instead of bit field.
    Protected macro args
    Fixed typo in subject line
    Added mention for G763 support in Kconfig
    Fixed typo in driver name in Kconfig
    Do not use DRVNAME in i2c_device_id g762_id[] 
    Following discussions, kept DEVICE_ATTR (i.e. no switch to SENSOR_DEVICE_ATTR)
    Removed useless casts when flipping bit values
    Sanity check user input value (e.g. to prevent 256 to silenty become 0)
    Added extra lines for multiline comments when needed
    Removed various testing knobs
    Make removed knobs available via DT
    Passed checkpatch script on the patch
    Removed useless lock protection againt clk setting
    Moved all setter at the beginning of the file
    Removed bad (u16) casts in g762_write_value() calls
    Added config structure and helpers
    Provide specific helper to overload config from dts


Arnaud Ebalard (3):
  Add support for GMT G762/G763 PWM fan controller
  Add documentation for g762 driver
  Add DT documentation for g762 driver

 Documentation/devicetree/bindings/hwmon/g762.txt |   57 ++
 Documentation/hwmon/g762                         |   67 ++
 drivers/hwmon/Kconfig                            |   10 +
 drivers/hwmon/Makefile                           |    1 +
 drivers/hwmon/g762.c                             | 1058 ++++++++++++++++++++++
 5 files changed, 1193 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/g762.txt
 create mode 100644 Documentation/hwmon/g762
 create mode 100644 drivers/hwmon/g762.c

-- 
1.7.10.4

  parent reply	other threads:[~2013-04-23 22:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 22:27 [RFC,PATCHv0 0/3] Add support for GMT G762/G763 PWM fan controller Arnaud Ebalard
2013-04-18 22:28 ` [PATCH 1/3] Add support for GMT G72/G763 " Arnaud Ebalard
2013-04-19  4:35   ` Guenter Roeck
2013-04-19  5:34     ` Arnaud Ebalard
2013-04-23 22:05     ` Arnaud Ebalard [this message]
2013-04-23 22:05       ` [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 " Arnaud Ebalard
2013-04-24  5:37         ` Andrew Lunn
2013-04-24  9:06           ` Arnaud Ebalard
2013-04-24 10:04             ` Simon Guinot
2013-04-24 10:50               ` Arnaud Ebalard
2013-04-24 13:38             ` Guenter Roeck
2013-04-24 20:28               ` Arnaud Ebalard
2013-04-24 22:47                 ` Guenter Roeck
2013-04-25 10:14                   ` Simon Guinot
2013-04-24 17:06         ` Simon Guinot
2013-04-24 23:37         ` Guenter Roeck
2013-04-25  9:58         ` Simon Guinot
2013-04-27 14:03         ` Simon Guinot
2013-04-27 14:12           ` Jean Delvare
2013-04-27 16:56           ` Guenter Roeck
2013-04-27 18:55             ` Arnaud Ebalard
2013-04-23 22:06       ` [PATCHv1 2/3] hwmon: Add documentation for g762 driver Arnaud Ebalard
2013-04-24 17:32         ` Guenter Roeck
2013-04-24 20:33           ` Arnaud Ebalard
2013-04-23 22:06       ` [PATCHv1 3/3] hwmon: Add DT " Arnaud Ebalard
2013-04-23 22:23         ` Jason Cooper
2013-04-24  5:43           ` Arnaud Ebalard
2013-04-19  5:50   ` [PATCH 1/3] Add support for GMT G72/G763 PWM fan controller Andrew Lunn
2013-04-19 11:30     ` Arnaud Ebalard
2013-04-19 13:37       ` Guenter Roeck
2013-04-19  6:05   ` Jean Delvare
2013-04-19 11:31     ` Arnaud Ebalard
2013-04-18 22:28 ` [RFC,PATCHv0 2/3] Add DT documentation for G762 " Arnaud Ebalard
2013-04-18 22:28 ` [PATCH 3/3] Add documentation for g762 driver Arnaud Ebalard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1366753420.git.arno@natisbad.org \
    --to=arno@natisbad.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).