From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260
Date: Tue, 05 Nov 2013 21:45:33 +0100 [thread overview]
Message-ID: <cover.1383681717.git.arno@natisbad.org> (raw)
Hi,
As discussed earlier, here is a set of two patches fixing Armada XP
mv78230 and mv78260 PCIe units definition. AFAICT, the most accurate
information available regarding those is the table available on the
following page:
http://www.marvell.com/embedded-processors/armada-xp/
First patch is simply a resend of the one Thomas reviewed with my
SoB. It fixes mv78230 .dtsi and has been tested on real hardware.
Second patch fixes mv78260 .dtsi to reflect the fact that the two first
units are x4 and quad x1 capable, and third (and last) interface is x4
only. This patch has only been compiled and not tested on real hardware.
As associated changes are quite error-prone, I think it needs some
careful review.
As a side note, Thomas, I noticed one more thing, this time in mv78460
.dtsi when comparing it w/ mv78230 and mv78260 ones. The first address
of "assigned-address" property varies in the former for each pcie
node:
$ grep assigned-address armada-xp-mv78230.dtsi
assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x48000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x4c000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
$ grep assigned-address armada-xp-mv78260.dtsi
assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x48000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x4c000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x84000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x88000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x8c000 0 0x2000>;
assigned-addresses = <0x82000800 0 0x42000 0 0x2000>;
$ grep assigned-address armada-xp-mv78460.dtsi
assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
assigned-addresses = <0x82001000 0 0x44000 0 0x2000>;
assigned-addresses = <0x82001800 0 0x48000 0 0x2000>;
assigned-addresses = <0x82002000 0 0x4c000 0 0x2000>;
assigned-addresses = <0x82002800 0 0x80000 0 0x2000>;
assigned-addresses = <0x82003000 0 0x84000 0 0x2000>;
assigned-addresses = <0x82003800 0 0x88000 0 0x2000>;
assigned-addresses = <0x82004000 0 0x8c000 0 0x2000>;
assigned-addresses = <0x82004800 0 0x42000 0 0x2000>;
assigned-addresses = <0x82005000 0 0x82000 0 0x2000>;
I took at Documentation/devicetree/bindings/pci/mvebu-pci.txt but
failed to find an answer. Can you explain where the difference comes
from?
Cheers,
a+
Arnaud Ebalard (2):
ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable
ARM: mvebu: fix second and third PCIe units of Armada XP mv78260
arch/arm/boot/dts/armada-xp-mv78230.dtsi | 24 +++----
arch/arm/boot/dts/armada-xp-mv78260.dtsi | 109 ++++++++++++++++++++++++-------
2 files changed, 97 insertions(+), 36 deletions(-)
--
1.8.4.rc3
next reply other threads:[~2013-11-05 20:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 20:45 Arnaud Ebalard [this message]
2013-11-05 20:45 ` [PATCH 1/2] ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable Arnaud Ebalard
2013-11-06 14:43 ` Thomas Petazzoni
2013-11-06 18:08 ` Arnaud Ebalard
2013-11-06 18:12 ` Jason Cooper
2013-11-06 18:20 ` Thomas Petazzoni
2013-11-21 23:28 ` Arnaud Ebalard
2013-11-22 13:44 ` Jason Cooper
2013-11-22 14:28 ` Thomas Petazzoni
2013-11-05 20:46 ` [PATCH 2/2] ARM: mvebu: fix second and third PCIe unit of Armada XP mv78260 Arnaud Ebalard
2013-11-06 14:54 ` Thomas Petazzoni
2013-11-06 18:14 ` [PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260 Arnaud Ebalard
2013-11-06 18:22 ` Thomas Petazzoni
2013-11-06 18:37 ` Jason Gunthorpe
2013-11-06 20:08 ` Arnaud Ebalard
2013-11-06 20:55 ` Jason Cooper
2013-11-06 21:32 ` Arnaud Ebalard
2013-11-22 15:04 ` Jason Cooper
2013-11-22 15:29 ` Arnaud Ebalard
2013-11-23 15:36 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1383681717.git.arno@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).