[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Simon Horman]

Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC clocks updates for v3.19.


The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:

  Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocks-for-v3.19

for you to fetch changes up to 2b02b8020fad6ed505ff9cfb1b418c4b59f102a5:

  ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module (2014-10-24 10:30:50 +0900)

----------------------------------------------------------------
Renesas ARM Based SoC Clocks Updates for v3.19

* Add missing INTCA clock for irqpin module on r8a7740

----------------------------------------------------------------
Geert Uytterhoeven (1):
      ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module

 arch/arm/mach-shmobile/clock-r8a7740.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

[PATCH] ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module

[Simon Horman]

From: Geert Uytterhoeven <geert+renesas@glider.be>

This clock drives the irqpin controller modules.
Before, it was assumed enabled by the bootloader or reset state.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/clock-r8a7740.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c b/arch/arm/mach-shmobile/clock-r8a7740.c
index 0794f04..6cb1de2 100644
--- a/arch/arm/mach-shmobile/clock-r8a7740.c
+++ b/arch/arm/mach-shmobile/clock-r8a7740.c
@@ -455,7 +455,7 @@ enum {
 	MSTP128, MSTP127, MSTP125,
 	MSTP116, MSTP111, MSTP100, MSTP117,
 
-	MSTP230,
+	MSTP230, MSTP229,
 	MSTP222,
 	MSTP218, MSTP217, MSTP216, MSTP214,
 	MSTP207, MSTP206, MSTP204, MSTP203, MSTP202, MSTP201, MSTP200,
@@ -479,6 +479,7 @@ static struct clk mstp_clks[MSTP_NR] = {
 	[MSTP100] = SH_CLK_MSTP32(&div4_clks[DIV4_B],	SMSTPCR1,  0, 0), /* LCDC0 */
 
 	[MSTP230] = SH_CLK_MSTP32(&div6_clks[DIV6_SUB],	SMSTPCR2, 30, 0), /* SCIFA6 */
+	[MSTP229] = SH_CLK_MSTP32(&div6_clks[DIV4_HP],	SMSTPCR2, 29, 0), /* INTCA */
 	[MSTP222] = SH_CLK_MSTP32(&div6_clks[DIV6_SUB],	SMSTPCR2, 22, 0), /* SCIFA7 */
 	[MSTP218] = SH_CLK_MSTP32(&div4_clks[DIV4_HP],  SMSTPCR2, 18, 0), /* DMAC1 */
 	[MSTP217] = SH_CLK_MSTP32(&div4_clks[DIV4_HP],  SMSTPCR2, 17, 0), /* DMAC2 */
@@ -575,6 +576,10 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh-dma-engine.0",	&mstp_clks[MSTP218]),
 	CLKDEV_DEV_ID("sh-sci.7",		&mstp_clks[MSTP222]),
 	CLKDEV_DEV_ID("e6cd0000.serial",	&mstp_clks[MSTP222]),
+	CLKDEV_DEV_ID("renesas_intc_irqpin.0",	&mstp_clks[MSTP229]),
+	CLKDEV_DEV_ID("renesas_intc_irqpin.1",	&mstp_clks[MSTP229]),
+	CLKDEV_DEV_ID("renesas_intc_irqpin.2",	&mstp_clks[MSTP229]),
+	CLKDEV_DEV_ID("renesas_intc_irqpin.3",	&mstp_clks[MSTP229]),
 	CLKDEV_DEV_ID("sh-sci.6",		&mstp_clks[MSTP230]),
 	CLKDEV_DEV_ID("e6cc0000.serial",	&mstp_clks[MSTP230]),
 
-- 
2.1.1

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Olof Johansson]

On Wed, Oct 29, 2014 at 01:58:17PM +0900, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
> 
> Please consider these Renesas ARM based SoC clocks updates for v3.19.
> 
> 
> The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
> 
>   Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocks-for-v3.19
> 
> for you to fetch changes up to 2b02b8020fad6ed505ff9cfb1b418c4b59f102a5:
> 
>   ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module (2014-10-24 10:30:50 +0900)
> 
> ----------------------------------------------------------------
> Renesas ARM Based SoC Clocks Updates for v3.19
> 
> * Add missing INTCA clock for irqpin module on r8a7740
> 
> ----------------------------------------------------------------
> Geert Uytterhoeven (1):
>       ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module

Hi,

I'm trying to categorize this patch and it's hard. Is it a fix for a
bug? Support for new firmware that doesn't enable this clock? How does
the breakage show itself, and in what circumstances? Essentially, the
patch description doesn't describe why it's needed and what it fixes.

Which means I don't know where to merge it to.


-Olof

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Simon Horman]

On Tue, Nov 04, 2014 at 02:30:54PM -0800, Olof Johansson wrote:
> On Wed, Oct 29, 2014 at 01:58:17PM +0900, Simon Horman wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> > 
> > Please consider these Renesas ARM based SoC clocks updates for v3.19.
> > 
> > 
> > The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
> > 
> >   Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocks-for-v3.19
> > 
> > for you to fetch changes up to 2b02b8020fad6ed505ff9cfb1b418c4b59f102a5:
> > 
> >   ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module (2014-10-24 10:30:50 +0900)
> > 
> > ----------------------------------------------------------------
> > Renesas ARM Based SoC Clocks Updates for v3.19
> > 
> > * Add missing INTCA clock for irqpin module on r8a7740
> > 
> > ----------------------------------------------------------------
> > Geert Uytterhoeven (1):
> >       ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module
> 
> Hi,
> 
> I'm trying to categorize this patch and it's hard. Is it a fix for a
> bug? Support for new firmware that doesn't enable this clock? How does
> the breakage show itself, and in what circumstances? Essentially, the
> patch description doesn't describe why it's needed and what it fixes.
> 
> Which means I don't know where to merge it to.

I believe that this fixes a problem that doesn't manifest.

It ensures that the clock required for the irqpin controller is available.
But as it is in practice the boot loader appears to make the clock
available and its been working due to that for several years. And I'm not
aware of anyone for whom it is not working without this patch.

My personal feeling is that you should just queue it up as a regular
non-bug-fix patch. Sorry for not making that clearer in the first place.

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Geert Uytterhoeven]

Hi Olof, Simon,

On Wed, Nov 5, 2014 at 5:04 AM, Simon Horman <horms@verge.net.au> wrote:
>> > Renesas ARM Based SoC Clocks Updates for v3.19
>> >
>> > * Add missing INTCA clock for irqpin module on r8a7740
>> >
>> > ----------------------------------------------------------------
>> > Geert Uytterhoeven (1):
>> >       ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module
>>
>> Hi,
>>
>> I'm trying to categorize this patch and it's hard. Is it a fix for a
>> bug? Support for new firmware that doesn't enable this clock? How does
>> the breakage show itself, and in what circumstances? Essentially, the
>> patch description doesn't describe why it's needed and what it fixes.
>>
>> Which means I don't know where to merge it to.
>
> I believe that this fixes a problem that doesn't manifest.
>
> It ensures that the clock required for the irqpin controller is available.
> But as it is in practice the boot loader appears to make the clock
> available and its been working due to that for several years. And I'm not
> aware of anyone for whom it is not working without this patch.

That was the first part.

There's a second part (which I indeed forgot to mention in the commit
message, sorry for that). If the system doesn't know about the clock,
it cannot disable it when the affected devices are not used (system suspend,
or runtime PM), thus wasting power.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Geert Uytterhoeven]

On Tue, Nov 4, 2014 at 11:30 PM, Olof Johansson <olof@lixom.net> wrote:
> On Wed, Oct 29, 2014 at 01:58:17PM +0900, Simon Horman wrote:
>> Hi Olof, Hi Kevin, Hi Arnd,
>>
>> Please consider these Renesas ARM based SoC clocks updates for v3.19.
>>
>>
>> The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
>>
>>   Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocks-for-v3.19
>>
>> for you to fetch changes up to 2b02b8020fad6ed505ff9cfb1b418c4b59f102a5:
>>
>>   ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module (2014-10-24 10:30:50 +0900)
>>
>> ----------------------------------------------------------------
>> Renesas ARM Based SoC Clocks Updates for v3.19
>>
>> * Add missing INTCA clock for irqpin module on r8a7740
>>
>> ----------------------------------------------------------------
>> Geert Uytterhoeven (1):
>>       ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module
>
> Hi,
>
> I'm trying to categorize this patch and it's hard. Is it a fix for a
> bug? Support for new firmware that doesn't enable this clock? How does
> the breakage show itself, and in what circumstances? Essentially, the
> patch description doesn't describe why it's needed and what it fixes.
>
> Which means I don't know where to merge it to.

Unfortunately I've just discovered a stupid typo in that patch.
I've sent a fix ("[PATCH] ARM: shmobile: r8a7740 legacy: Fix INTCA
clock parent").

If you prefer a complete new patch including the fix, just let me know.

Sorry for the inconvenience.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Olof Johansson]

On Wed, Nov 5, 2014 at 1:11 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Nov 4, 2014 at 11:30 PM, Olof Johansson <olof@lixom.net> wrote:
>> On Wed, Oct 29, 2014 at 01:58:17PM +0900, Simon Horman wrote:
>>> Hi Olof, Hi Kevin, Hi Arnd,
>>>
>>> Please consider these Renesas ARM based SoC clocks updates for v3.19.
>>>
>>>
>>> The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
>>>
>>>   Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocks-for-v3.19
>>>
>>> for you to fetch changes up to 2b02b8020fad6ed505ff9cfb1b418c4b59f102a5:
>>>
>>>   ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module (2014-10-24 10:30:50 +0900)
>>>
>>> ----------------------------------------------------------------
>>> Renesas ARM Based SoC Clocks Updates for v3.19
>>>
>>> * Add missing INTCA clock for irqpin module on r8a7740
>>>
>>> ----------------------------------------------------------------
>>> Geert Uytterhoeven (1):
>>>       ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module
>>
>> Hi,
>>
>> I'm trying to categorize this patch and it's hard. Is it a fix for a
>> bug? Support for new firmware that doesn't enable this clock? How does
>> the breakage show itself, and in what circumstances? Essentially, the
>> patch description doesn't describe why it's needed and what it fixes.
>>
>> Which means I don't know where to merge it to.
>
> Unfortunately I've just discovered a stupid typo in that patch.
> I've sent a fix ("[PATCH] ARM: shmobile: r8a7740 legacy: Fix INTCA
> clock parent").
>
> If you prefer a complete new patch including the fix, just let me know.

Since I haven't applied it yet, feel free to squash it in and send a
fresh pull request. That way you can revisit the commit message too!


-Olof

[GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19

[Geert Uytterhoeven]

Hi Olof,

On Wed, Nov 5, 2014 at 8:14 PM, Olof Johansson <olof@lixom.net> wrote:
>>>> Geert Uytterhoeven (1):
>>>>       ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module
>>>
>>> I'm trying to categorize this patch and it's hard. Is it a fix for a
>>> bug? Support for new firmware that doesn't enable this clock? How does
>>> the breakage show itself, and in what circumstances? Essentially, the
>>> patch description doesn't describe why it's needed and what it fixes.
>>>
>>> Which means I don't know where to merge it to.
>>
>> Unfortunately I've just discovered a stupid typo in that patch.
>> I've sent a fix ("[PATCH] ARM: shmobile: r8a7740 legacy: Fix INTCA
>> clock parent").
>>
>> If you prefer a complete new patch including the fix, just let me know.
>
> Since I haven't applied it yet, feel free to squash it in and send a
> fresh pull request. That way you can revisit the commit message too!

Sent v2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds