linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 0/3] arm: mvebu: add Synology DS213j and DS414 .dts files
Date: Sun, 16 Nov 2014 01:04:01 +0100	[thread overview]
Message-ID: <cover.1416095841.git.arno@natisbad.org> (raw)

Hi,

This series adds .dts files for Synology DS213j (armada 370 2-bay NAS) and
DS414 (armada XP 4-bay NAS) devices. It is based on comments received on
a v0 submission of DS213j .dts file [1].

Andrew, in this v1, the two .dts files are still separate w/o any common
.dtsi. I took a quick look it seems there are small differences between
the two which make me wonder if its worth the trouble:

 - DS414 fans are not handled by the SoC
 - various pinctrl variations
 - a tiny difference in SPI flash partitioning
 - phy-mode for ethernet interfaces
 - different comments associated w/ same nodes (e.g. uart1)
 - etc

Could you take a quick look and tell me if you think it's worth it? I'll
follow what you'll decide.

Cheers,

a+

[1]: http://thread.gmane.org/gmane.linux.drivers.devicetree/95401

Changes since v0:

 - Added a comment at the beginning of DS213j and DS414j .dts file regarding
   the need for a recent Marvell bootloader. Arnd suggested to do a specific
   .dtb file for new and old bootloaders but I think if we follow this path
   for DS414 and DS213j, we will probably have to do it for all Armada-based
   synology NAS and possibly for other Armada 370/XP based devices. Opting
   for recent bootloaders config and having a comment is easier. It is likely
   that a user already has a recent bootloader. Otherwise, upgrade is a one
   click process anyway. If a user thinks it is easier to have two different
   .dts files in the kernel, she will still be able to push a patch. 
 - Added a comment in the .dts file about the bootloader screwing the kernel
   if the environment is saved.
 - Kept GPL licence for .dts file
 - Fixed bad naming of node and alias (_ vs -)
 - Added micron vendor prefix for n25q064 flash
 - Disabled SoC RTC; a Seiko S-35390A is used as main RTC
 - Added comments about the purpose of each serial port
 - Added stdout-path = &uart0; to help barebox. A specific patch is included
   in the series to provide labels for uart serial nodes
 - Added patch for DS414 .dts file
 

Arnaud Ebalard (3):
  arm: mvebu: add uartX labels for Armada SoC serial nodes
  arm: mvebu: add .dts file for Synology DS213j
  arm: mvebu: add .dts file for Synology DS414

 arch/arm/boot/dts/Makefile                       |   6 +-
 arch/arm/boot/dts/armada-370-synology-ds213j.dts | 351 +++++++++++++++++++++++
 arch/arm/boot/dts/armada-370-xp.dtsi             |   5 +-
 arch/arm/boot/dts/armada-xp-synology-ds414.dts   | 343 ++++++++++++++++++++++
 arch/arm/boot/dts/armada-xp.dtsi                 |   5 +-
 5 files changed, 704 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/boot/dts/armada-370-synology-ds213j.dts
 create mode 100644 arch/arm/boot/dts/armada-xp-synology-ds414.dts

-- 
2.1.1

             reply	other threads:[~2014-11-16  0:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16  0:04 Arnaud Ebalard [this message]
2014-11-16  0:04 ` [PATCHv1 1/3] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-16  1:09   ` Andrew Lunn
2014-11-16 12:34     ` Arnaud Ebalard
2014-11-16  0:04 ` [PATCHv1 2/3] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-16  2:00   ` Andrew Lunn
2014-11-16  2:31     ` Andrew Lunn
2014-11-16 13:14     ` Arnaud Ebalard
2014-11-16 23:23       ` Ben Peddell
2014-11-17  8:25         ` Arnaud Ebalard
2014-11-17 22:41           ` Ben Peddell
2014-11-17 23:23             ` Arnaud Ebalard
2014-11-16  0:04 ` [PATCHv1 3/3] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
2014-11-16  2:15   ` Andrew Lunn
2014-11-16 13:17     ` Arnaud Ebalard
2014-11-16  2:20 ` [PATCHv1 0/3] arm: mvebu: add Synology DS213j and DS414 .dts files Andrew Lunn
2014-11-16 13:24   ` Arnaud Ebalard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1416095841.git.arno@natisbad.org \
    --to=arno@natisbad.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).