* [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
@ 2015-03-30 23:45 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Joe Perches @ 2015-03-30 23:45 UTC (permalink / raw)
To: linux-arm-kernel
Joe Perches (25):
arm: Use bool function return values of true/false not 1/0
arm64: Use bool function return values of true/false not 1/0
hexagon: Use bool function return values of true/false not 1/0
ia64: Use bool function return values of true/false not 1/0
mips: Use bool function return values of true/false not 1/0
powerpc: Use bool function return values of true/false not 1/0
s390: Use bool function return values of true/false not 1/0
sparc: Use bool function return values of true/false not 1/0
tile: Use bool function return values of true/false not 1/0
unicore32: Use bool function return values of true/false not 1/0
x86: Use bool function return values of true/false not 1/0
virtio_console: Use bool function return values of true/false not 1/0
csiostor: Use bool function return values of true/false not 1/0
dcache: Use bool function return values of true/false not 1/0
nfsd: nfs4state: Use bool function return values of true/false not 1/0
include/linux: Use bool function return values of true/false not 1/0
sound: Use bool function return values of true/false not 1/0
rcu: tree_plugin: Use bool function return values of true/false not 1/0
sched: Use bool function return values of true/false not 1/0
ftrace: Use bool function return values of true/false not 1/0
slub: Use bool function return values of true/false not 1/0
bridge: Use bool function return values of true/false not 1/0
netfilter: Use bool function return values of true/false not 1/0
security: Use bool function return values of true/false not 1/0
sound: wm5100-tables: Use bool function return values of true/false not 1/0
arch/arm/include/asm/dma-mapping.h | 8 ++--
arch/arm/include/asm/kvm_emulate.h | 2 +-
arch/arm/mach-omap2/powerdomain.c | 14 +++---
arch/arm64/include/asm/dma-mapping.h | 2 +-
arch/hexagon/include/asm/dma-mapping.h | 2 +-
arch/ia64/include/asm/dma-mapping.h | 2 +-
arch/mips/include/asm/dma-mapping.h | 2 +-
arch/powerpc/include/asm/dcr-native.h | 2 +-
arch/powerpc/include/asm/dma-mapping.h | 4 +-
arch/powerpc/include/asm/kvm_book3s_64.h | 4 +-
arch/powerpc/sysdev/dcr.c | 2 +-
arch/s390/include/asm/dma-mapping.h | 2 +-
arch/sparc/mm/init_64.c | 8 ++--
arch/tile/include/asm/dma-mapping.h | 2 +-
arch/unicore32/include/asm/dma-mapping.h | 2 +-
arch/x86/include/asm/archrandom.h | 2 +-
arch/x86/include/asm/dma-mapping.h | 2 +-
arch/x86/include/asm/kvm_para.h | 2 +-
arch/x86/kvm/cpuid.h | 2 +-
arch/x86/kvm/vmx.c | 72 ++++++++++++++--------------
drivers/char/virtio_console.c | 2 +-
drivers/scsi/csiostor/csio_scsi.c | 4 +-
fs/dcache.c | 12 ++---
fs/nfsd/nfs4state.c | 2 +-
include/linux/blkdev.h | 2 +-
include/linux/ide.h | 2 +-
include/linux/kgdb.h | 2 +-
include/linux/mfd/db8500-prcmu.h | 2 +-
include/linux/mm.h | 2 +-
include/linux/power_supply.h | 8 ++--
include/linux/ssb/ssb_driver_extif.h | 2 +-
include/linux/ssb/ssb_driver_gige.h | 16 +++----
include/sound/soc.h | 4 +-
kernel/rcu/tree_plugin.h | 4 +-
kernel/sched/auto_group.h | 2 +-
kernel/sched/completion.c | 16 ++++---
kernel/trace/ftrace.c | 10 ++--
mm/slub.c | 12 ++---
net/bridge/br_private.h | 2 +-
net/ipv4/netfilter/ipt_ah.c | 2 +-
net/netfilter/ipset/ip_set_hash_ip.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++--
net/netfilter/ipset/ip_set_hash_net.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netport.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++--
net/netfilter/xt_connlimit.c | 2 +-
net/netfilter/xt_hashlimit.c | 2 +-
net/netfilter/xt_ipcomp.c | 2 +-
security/apparmor/file.c | 8 ++--
security/apparmor/policy.c | 10 ++--
sound/soc/codecs/wm5100-tables.c | 12 ++---
55 files changed, 178 insertions(+), 176 deletions(-)
--
2.1.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 01/25] arm: Use bool function return values of true/false not 1/0
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
@ 2015-03-30 23:45 ` Joe Perches
2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
[not found] ` <5519E53B.5040504@schaufler-ca.com>
2 siblings, 2 replies; 8+ messages in thread
From: Joe Perches @ 2015-03-30 23:45 UTC (permalink / raw)
To: linux-arm-kernel
Use the normal return values for bool functions
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm/include/asm/dma-mapping.h | 8 ++++----
arch/arm/include/asm/kvm_emulate.h | 2 +-
arch/arm/mach-omap2/powerdomain.c | 14 +++++++-------
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
index b52101d..166e1e1 100644
--- a/arch/arm/include/asm/dma-mapping.h
+++ b/arch/arm/include/asm/dma-mapping.h
@@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
u64 limit, mask;
if (!dev->dma_mask)
- return 0;
+ return false;
mask = *dev->dma_mask;
limit = (mask + 1) & ~mask;
if (limit && size > limit)
- return 0;
+ return false;
if ((addr | (addr + size - 1)) & ~mask)
- return 0;
+ return false;
- return 1;
+ return true;
}
static inline void dma_mark_clean(void *addr, size_t size) { }
diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h
index a9c80a2..ad200a0 100644
--- a/arch/arm/include/asm/kvm_emulate.h
+++ b/arch/arm/include/asm/kvm_emulate.h
@@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
{
- return 1;
+ return true;
}
static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu)
diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index 78af6d8..897f9fb 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm)
*/
bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
{
- return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0;
+ return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR);
}
int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
@@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
if (!pwrdm) {
pr_debug("powerdomain: %s: invalid powerdomain pointer\n",
__func__);
- return 1;
+ return true;
}
if (pwrdm->pwrsts & PWRSTS_OFF)
- return 1;
+ return true;
if (pwrdm->pwrsts & PWRSTS_RET) {
if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF)
- return 1;
+ return true;
for (i = 0; i < pwrdm->banks; i++)
if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF)
- return 1;
+ return true;
}
for (i = 0; i < pwrdm->banks; i++)
if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF)
- return 1;
+ return true;
- return 0;
+ return false;
}
--
2.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 02/25] arm64: Use bool function return values of true/false not 1/0
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
@ 2015-03-30 23:46 ` Joe Perches
2015-03-31 15:29 ` Will Deacon
[not found] ` <5519E53B.5040504@schaufler-ca.com>
2 siblings, 1 reply; 8+ messages in thread
From: Joe Perches @ 2015-03-30 23:46 UTC (permalink / raw)
To: linux-arm-kernel
Use the normal return values for bool functions
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm64/include/asm/dma-mapping.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
index 6932bb5..9437e3d 100644
--- a/arch/arm64/include/asm/dma-mapping.h
+++ b/arch/arm64/include/asm/dma-mapping.h
@@ -97,7 +97,7 @@ static inline int dma_set_mask(struct device *dev, u64 mask)
static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
{
if (!dev->dma_mask)
- return 0;
+ return false;
return addr + size - 1 <= *dev->dma_mask;
}
--
2.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
[not found] ` <5519E53B.5040504@schaufler-ca.com>
@ 2015-03-31 0:14 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2015-03-31 0:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote:
> On 3/30/2015 4:45 PM, Joe Perches wrote:
> > Joe Perches (25):
> > arm: Use bool function return values of true/false not 1/0
[etc...]
> Why, and why these in particular?
bool functions are probably better returning
bool values instead of 1 and 0.
Especially when the functions intermix returning
returning 1/0 and true/false.
(there are only a couple of those though)
These are all the remaining instances in the
kernel tree.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 02/25] arm64: Use bool function return values of true/false not 1/0
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
@ 2015-03-31 15:29 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2015-03-31 15:29 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 31, 2015 at 12:46:00AM +0100, Joe Perches wrote:
> Use the normal return values for bool functions
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm64/include/asm/dma-mapping.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
> index 6932bb5..9437e3d 100644
> --- a/arch/arm64/include/asm/dma-mapping.h
> +++ b/arch/arm64/include/asm/dma-mapping.h
> @@ -97,7 +97,7 @@ static inline int dma_set_mask(struct device *dev, u64 mask)
> static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> {
> if (!dev->dma_mask)
> - return 0;
> + return false;
>
> return addr + size - 1 <= *dev->dma_mask;
> }
> --
> 2.1.2
Looks simple enough, I'll pick it up for 4.1.
Will
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 01/25] arm: Use bool function return values of true/false not 1/0
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
@ 2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini
1 sibling, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2015-03-31 15:54 UTC (permalink / raw)
To: linux-arm-kernel
* Joe Perches <joe@perches.com> [150330 16:47]:
> Use the normal return values for bool functions
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/include/asm/dma-mapping.h | 8 ++++----
> arch/arm/include/asm/kvm_emulate.h | 2 +-
> arch/arm/mach-omap2/powerdomain.c | 14 +++++++-------
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index b52101d..166e1e1 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> u64 limit, mask;
>
> if (!dev->dma_mask)
> - return 0;
> + return false;
>
> mask = *dev->dma_mask;
>
> limit = (mask + 1) & ~mask;
> if (limit && size > limit)
> - return 0;
> + return false;
>
> if ((addr | (addr + size - 1)) & ~mask)
> - return 0;
> + return false;
>
> - return 1;
> + return true;
> }
>
> static inline void dma_mark_clean(void *addr, size_t size) { }
> diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h
> index a9c80a2..ad200a0 100644
> --- a/arch/arm/include/asm/kvm_emulate.h
> +++ b/arch/arm/include/asm/kvm_emulate.h
> @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
>
> static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
> {
> - return 1;
> + return true;
> }
>
> static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu)
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 78af6d8..897f9fb 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm)
> */
> bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
> {
> - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0;
> + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR);
> }
>
> int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
> @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
> if (!pwrdm) {
> pr_debug("powerdomain: %s: invalid powerdomain pointer\n",
> __func__);
> - return 1;
> + return true;
> }
>
> if (pwrdm->pwrsts & PWRSTS_OFF)
> - return 1;
> + return true;
>
> if (pwrdm->pwrsts & PWRSTS_RET) {
> if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF)
> - return 1;
> + return true;
>
> for (i = 0; i < pwrdm->banks; i++)
> if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF)
> - return 1;
> + return true;
> }
>
> for (i = 0; i < pwrdm->banks; i++)
> if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF)
> - return 1;
> + return true;
>
> - return 0;
> + return false;
> }
> --
> 2.1.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 01/25] arm: Use bool function return values of true/false not 1/0
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
2015-03-31 15:54 ` Tony Lindgren
@ 2015-03-31 15:58 ` Paolo Bonzini
2015-03-31 16:05 ` Marc Zyngier
1 sibling, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2015-03-31 15:58 UTC (permalink / raw)
To: linux-arm-kernel
On 31/03/2015 01:45, Joe Perches wrote:
> Use the normal return values for bool functions
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/include/asm/dma-mapping.h | 8 ++++----
> arch/arm/include/asm/kvm_emulate.h | 2 +-
> arch/arm/mach-omap2/powerdomain.c | 14 +++++++-------
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index b52101d..166e1e1 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> u64 limit, mask;
>
> if (!dev->dma_mask)
> - return 0;
> + return false;
>
> mask = *dev->dma_mask;
>
> limit = (mask + 1) & ~mask;
> if (limit && size > limit)
> - return 0;
> + return false;
>
> if ((addr | (addr + size - 1)) & ~mask)
> - return 0;
> + return false;
>
> - return 1;
> + return true;
> }
>
> static inline void dma_mark_clean(void *addr, size_t size) { }
> diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h
> index a9c80a2..ad200a0 100644
> --- a/arch/arm/include/asm/kvm_emulate.h
> +++ b/arch/arm/include/asm/kvm_emulate.h
> @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
>
> static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
> {
> - return 1;
> + return true;
> }
>
> static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu)
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 78af6d8..897f9fb 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm)
> */
> bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
> {
> - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0;
> + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR);
> }
>
> int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
> @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
> if (!pwrdm) {
> pr_debug("powerdomain: %s: invalid powerdomain pointer\n",
> __func__);
> - return 1;
> + return true;
> }
>
> if (pwrdm->pwrsts & PWRSTS_OFF)
> - return 1;
> + return true;
>
> if (pwrdm->pwrsts & PWRSTS_RET) {
> if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF)
> - return 1;
> + return true;
>
> for (i = 0; i < pwrdm->banks; i++)
> if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF)
> - return 1;
> + return true;
> }
>
> for (i = 0; i < pwrdm->banks; i++)
> if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF)
> - return 1;
> + return true;
>
> - return 0;
> + return false;
> }
>
Marc/Christoffer, please pick this up yourself.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 01/25] arm: Use bool function return values of true/false not 1/0
2015-03-31 15:58 ` Paolo Bonzini
@ 2015-03-31 16:05 ` Marc Zyngier
0 siblings, 0 replies; 8+ messages in thread
From: Marc Zyngier @ 2015-03-31 16:05 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 31 Mar 2015 16:58:28 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 31/03/2015 01:45, Joe Perches wrote:
> > Use the normal return values for bool functions
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > arch/arm/include/asm/dma-mapping.h | 8 ++++----
> > arch/arm/include/asm/kvm_emulate.h | 2 +-
> > arch/arm/mach-omap2/powerdomain.c | 14 +++++++-------
> > 3 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> > index b52101d..166e1e1 100644
> > --- a/arch/arm/include/asm/dma-mapping.h
> > +++ b/arch/arm/include/asm/dma-mapping.h
> > @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> > u64 limit, mask;
> >
> > if (!dev->dma_mask)
> > - return 0;
> > + return false;
> >
> > mask = *dev->dma_mask;
> >
> > limit = (mask + 1) & ~mask;
> > if (limit && size > limit)
> > - return 0;
> > + return false;
> >
> > if ((addr | (addr + size - 1)) & ~mask)
> > - return 0;
> > + return false;
> >
> > - return 1;
> > + return true;
> > }
> >
> > static inline void dma_mark_clean(void *addr, size_t size) { }
> > diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h
> > index a9c80a2..ad200a0 100644
> > --- a/arch/arm/include/asm/kvm_emulate.h
> > +++ b/arch/arm/include/asm/kvm_emulate.h
> > @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
> >
> > static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
> > {
> > - return 1;
> > + return true;
> > }
> >
> > static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu)
> > diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> > index 78af6d8..897f9fb 100644
> > --- a/arch/arm/mach-omap2/powerdomain.c
> > +++ b/arch/arm/mach-omap2/powerdomain.c
> > @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm)
> > */
> > bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
> > {
> > - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0;
> > + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR);
> > }
> >
> > int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
> > @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
> > if (!pwrdm) {
> > pr_debug("powerdomain: %s: invalid powerdomain pointer\n",
> > __func__);
> > - return 1;
> > + return true;
> > }
> >
> > if (pwrdm->pwrsts & PWRSTS_OFF)
> > - return 1;
> > + return true;
> >
> > if (pwrdm->pwrsts & PWRSTS_RET) {
> > if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF)
> > - return 1;
> > + return true;
> >
> > for (i = 0; i < pwrdm->banks; i++)
> > if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF)
> > - return 1;
> > + return true;
> > }
> >
> > for (i = 0; i < pwrdm->banks; i++)
> > if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF)
> > - return 1;
> > + return true;
> >
> > - return 0;
> > + return false;
> > }
> >
>
> Marc/Christoffer, please pick this up yourself.
Given that it touches a range of completely unrelated files, for the
KVM part:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-31 16:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini
2015-03-31 16:05 ` Marc Zyngier
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
2015-03-31 15:29 ` Will Deacon
[not found] ` <5519E53B.5040504@schaufler-ca.com>
2015-03-31 0:14 ` [PATCH 00/25] treewide: " Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).