* [GIT PULL] Renesas ARM Based SoC Updates for v4.7
@ 2016-04-25 4:08 Simon Horman
2016-04-25 4:08 ` [PATCH] ARM: shmobile: timer: Drop support for Cortex A8 Simon Horman
2016-04-25 22:11 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.7 Arnd Bergmann
0 siblings, 2 replies; 3+ messages in thread
From: Simon Horman @ 2016-04-25 4:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olof, Hi Kevin, Hi Arnd,
Please consider these Renesas ARM based SoC updates for v4.7.
This pull request is based on "[GIT PULL v2] Renesas ARM Based SoC Fixes
for v4.6", tagged as renesas-fixes-for-v4.6, which I have previously sent
a pull request for.
The reason is that this series depends on c531fb27e969 ("ARM: shmobile:
timer: Fix preset_lpj leading to too short delays")
The following changes since commit c531fb27e9699eaee478ee5686a3cca5dee73602:
ARM: shmobile: timer: Fix preset_lpj leading to too short delays (2016-04-20 08:52:55 +1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-soc-for-v4.7
for you to fetch changes up to a4b8c18c40704c28be62af4606cc6758c9ff3dba:
ARM: shmobile: timer: Drop support for Cortex A8 (2016-04-20 08:55:09 +1000)
----------------------------------------------------------------
Renesas ARM Based SoC Updates for v4.7
Drop support for Cortex A8 in timer code
----------------------------------------------------------------
Geert Uytterhoeven (1):
ARM: shmobile: timer: Drop support for Cortex A8
arch/arm/mach-shmobile/timer.c | 52 ++++++++++++++++--------------------------
1 file changed, 20 insertions(+), 32 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: shmobile: timer: Drop support for Cortex A8
2016-04-25 4:08 [GIT PULL] Renesas ARM Based SoC Updates for v4.7 Simon Horman
@ 2016-04-25 4:08 ` Simon Horman
2016-04-25 22:11 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.7 Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-04-25 4:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy
file") removed the DTS for the last shmobile SoC with a Cortex A8 CPU
core (sh7372 aka SH-Mobile AP4), hence drop support for it in the
loops-per-jiffy preset code.
As "div" is always 1 for supported contemporary ARM processors, we can
simplify the code:
- Absorb shmobile_setup_delay_hz(), which was always called with
mult = div = 1,
- Return earlier if the Cortex A7/A15 arch timer exists and support is
enabled.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/timer.c | 52 ++++++++++++++++--------------------------
1 file changed, 20 insertions(+), 32 deletions(-)
diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
index 67d79f9c6bad..6196a6380385 100644
--- a/arch/arm/mach-shmobile/timer.c
+++ b/arch/arm/mach-shmobile/timer.c
@@ -20,28 +20,9 @@
#include "common.h"
-static void __init shmobile_setup_delay_hz(unsigned int max_cpu_core_hz,
- unsigned int mult, unsigned int div)
-{
- /* calculate a worst-case loops-per-jiffy value
- * based on maximum cpu core hz setting and the
- * __delay() implementation in arch/arm/lib/delay.S
- *
- * this will result in a longer delay than expected
- * when the cpu core runs on lower frequencies.
- */
-
- unsigned int value = HZ * div / mult;
-
- if (!preset_lpj)
- preset_lpj = max_cpu_core_hz / value;
-}
-
void __init shmobile_init_delay(void)
{
struct device_node *np, *cpus;
- unsigned int div = 0;
- bool has_arch_timer = false;
u32 max_freq = 0;
cpus = of_find_node_by_path("/cpus");
@@ -51,25 +32,32 @@ void __init shmobile_init_delay(void)
for_each_child_of_node(cpus, np) {
u32 freq;
+ if (IS_ENABLED(CONFIG_ARM_ARCH_TIMER) &&
+ (of_device_is_compatible(np, "arm,cortex-a7") ||
+ of_device_is_compatible(np, "arm,cortex-a15"))) {
+ of_node_put(np);
+ of_node_put(cpus);
+ return;
+ }
+
if (!of_property_read_u32(np, "clock-frequency", &freq))
max_freq = max(max_freq, freq);
-
- if (of_device_is_compatible(np, "arm,cortex-a8")) {
- div = 2;
- } else if (of_device_is_compatible(np, "arm,cortex-a9")) {
- div = 1;
- } else if (of_device_is_compatible(np, "arm,cortex-a7") ||
- of_device_is_compatible(np, "arm,cortex-a15")) {
- div = 1;
- has_arch_timer = true;
- }
}
of_node_put(cpus);
- if (!max_freq || !div)
+ if (!max_freq)
return;
- if (!has_arch_timer || !IS_ENABLED(CONFIG_ARM_ARCH_TIMER))
- shmobile_setup_delay_hz(max_freq, 1, div);
+ /*
+ * Calculate a worst-case loops-per-jiffy value
+ * based on maximum cpu core hz setting and the
+ * __delay() implementation in arch/arm/lib/delay.S.
+ *
+ * This will result in a longer delay than expected
+ * when the cpu core runs on lower frequencies.
+ */
+
+ if (!preset_lpj)
+ preset_lpj = max_freq / HZ;
}
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [GIT PULL] Renesas ARM Based SoC Updates for v4.7
2016-04-25 4:08 [GIT PULL] Renesas ARM Based SoC Updates for v4.7 Simon Horman
2016-04-25 4:08 ` [PATCH] ARM: shmobile: timer: Drop support for Cortex A8 Simon Horman
@ 2016-04-25 22:11 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-04-25 22:11 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 25 April 2016 14:08:11 Simon Horman wrote:
> This pull request is based on "[GIT PULL v2] Renesas ARM Based SoC Fixes
> for v4.6", tagged as renesas-fixes-for-v4.6, which I have previously sent
> a pull request for.
>
> The reason is that this series depends on c531fb27e969 ("ARM: shmobile:
> timer: Fix preset_lpj leading to too short delays")
>
Pulled into next/soc. I think I have everything you sent us so far now, but
please check yourself, thanks!
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-25 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 4:08 [GIT PULL] Renesas ARM Based SoC Updates for v4.7 Simon Horman
2016-04-25 4:08 ` [PATCH] ARM: shmobile: timer: Drop support for Cortex A8 Simon Horman
2016-04-25 22:11 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.7 Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).