From: "Guido Günther" <agx@sigxcpu.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
Robert Chiras <robert.chiras@nxp.com>,
Sam Ravnborg <sam@ravnborg.org>,
Fabio Estevam <festevam@gmail.com>
Subject: [PATCH v2 0/3] Mixel DPHY support for i.MX8
Date: Fri, 1 Feb 2019 09:49:52 +0100 [thread overview]
Message-ID: <cover.1549010639.git.agx@sigxcpu.org> (raw)
This adds initial support for the Mixel IP based mipi dphy as found on i.MX8
processors. It has support for the i.MX8MQ, support for other variants can be
added - once the necessary parts are in - via the provided devdata.
The driver is somewhat based on what's found in NXPs BSP.
Documentation on the DPHY's registers is currently thin in the i.MX8 reference
manuals (even on the i.MX8QXP form 11/18) so most of the values were taken from
existing drivers. Newer NXP drivers have a bit more details so where possible
the timings are calculated and validated.
This is based on linux-next as of 2019-01-25 and Maxime Ripard's dphy
configuration helper patches which would need to go in first.
To get DSI working on the imx8MQ there's a driver for the nwl dsi host
controller missing which I intend to look at too.
Changes from v1
* As per review comments from Fabio Estevam
* Kconfig: tristate mixel dphy support.
* Drop unused 'ret' in mixel_dphy_ref_power_off.
* Match values of DPHY_RXL{PRP,DRP} to those of
https://source.codeaurora.org/external/imx/linux-imx/log/?h=imx_4.14.78_1.0.0_ga
The previous values were based on 4.9.
* Use resource size on devm_ioremap, we have that in dt already.
* Use regmap so it's simple to dump the registers.
* Use regmap_read_poll_timeout instead of open coded loop.
* Add undocumented rxhs_settle register
* As per review comments from Sam Ravnborg
* Move driver to d/phy/freescale/
* Move SPDX-License-Identifier to top of file.
* Drop '/* #define DEBUG 1 */'.
* Use GPL-2.0+ since the vendor driver uses that as well.
* Drop the mutex, register access is now protected by regmap.
* Fix various style / indentation issues.
* Check for register read, write and ioremap errors
* Improve phy timing calculations
* Use LP clock rate where sensible, check for errors
* Use ad hoc forumulas for timings involving hs clock
* Switch from dphy_ops to devdata. Other i.MX8 variants
differ in register layout too
* Add Mixel Inc to vendor-prefixes.txt
Guido Günther (3):
dt-bindings: Add vendor prefix for Mixel Inc
dt-bindings: phy: Add documentation for mixel dphy
phy: Add driver for mixel dphy found on imx8
.../bindings/phy/mixel,mipi-dsi-phy.txt | 29 +
.../devicetree/bindings/vendor-prefixes.txt | 1 +
drivers/phy/freescale/Kconfig | 9 +
drivers/phy/freescale/Makefile | 1 +
.../phy/freescale/phy-fsl-imx8-mipi-dphy.c | 494 ++++++++++++++++++
5 files changed, 534 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.txt
create mode 100644 drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-02-01 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 8:49 Guido Günther [this message]
2019-02-01 8:49 ` [PATCH v2 1/3] dt-bindings: Add vendor prefix for Mixel Inc Guido Günther
2019-02-01 8:49 ` [PATCH v2 2/3] dt-bindings: phy: Add documentation for mixel dphy Guido Günther
2019-02-01 14:14 ` Sam Ravnborg
2019-02-02 10:22 ` Guido Günther
2019-02-01 8:49 ` [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8 Guido Günther
2019-02-01 11:26 ` Fabio Estevam
2019-02-08 11:38 ` Guido Günther
2019-02-03 9:32 ` kbuild test robot
2019-02-06 15:28 ` Robert Chiras
2019-02-08 11:40 ` Guido Günther
2019-02-08 11:55 ` Robert Chiras
2019-03-06 13:55 ` Guido Günther
2019-03-21 17:12 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1549010639.git.agx@sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime.ripard@bootlin.com \
--cc=robert.chiras@nxp.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).