From: Ming Qian <ming.qian@nxp.com>
To: mchehab@kernel.org, shawnguo@kernel.org
Cc: hverkuil-cisco@xs4all.nl, robh+dt@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] media: amphion: copy timestamp from output to
Date: Wed, 20 Apr 2022 19:34:52 +0800 [thread overview]
Message-ID: <cover.1650453924.git.ming.qian@nxp.com> (raw)
v3
- add helper function vpu_skip_frame() and vpu_next_src_buf()
v2
- reduce the min buffers count
There is a timestamp manager in firmware,
so in previous, driver will pass the timestamp to firmware,
and when a frame is decoded or encoded,
firmware will pass the timestamp to driver,
then driver set the timestamp to the capture vb2_buffer.
But there is problem that the timestamp manager will ensure that the
timestamps are monotonically increasing.
So if there are reorder frames, the capture buffer's timestamp is
inconsistent with the timestamp of the corresponding output buffer.
It goes against the description of V4L2_BUF_FLAG_TIMESTAMP_COPY in the
specification
In order to comply with the specification, driver should copy timestamp
from output buffer to capture buffer, and there is an helper function
v4l2_m2m_buf_copy_metadata to handle it.
Ming Qian (2):
media: amphion: decoder copy timestamp from output to capture
media: amphion: encoder copy timestamp from output to capture
drivers/media/platform/amphion/vdec.c | 76 ++++++++-------------
drivers/media/platform/amphion/venc.c | 47 +++++--------
drivers/media/platform/amphion/vpu_malone.c | 2 +-
drivers/media/platform/amphion/vpu_v4l2.c | 56 +++++++++++++++
drivers/media/platform/amphion/vpu_v4l2.h | 3 +
5 files changed, 103 insertions(+), 81 deletions(-)
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-04-20 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 11:34 Ming Qian [this message]
2022-04-20 11:34 ` [PATCH v3 1/2] media: amphion: decoder copy timestamp from output to capture Ming Qian
2022-04-20 11:34 ` [PATCH v3 2/2] media: amphion: encoder " Ming Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1650453924.git.ming.qian@nxp.com \
--to=ming.qian@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).