* [PATCH v2 1/2] net: stmmac: do not clear TBS enable bit on link up/down
2024-01-26 9:10 [PATCH v2 0/2] net: stmmac: dwmac-imx: Time Based Scheduling support Esben Haabendal
@ 2024-01-26 9:10 ` Esben Haabendal
2024-01-26 9:10 ` [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings Esben Haabendal
2024-01-30 12:10 ` [PATCH v2 0/2] net: stmmac: dwmac-imx: Time Based Scheduling support patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: Esben Haabendal @ 2024-01-26 9:10 UTC (permalink / raw)
To: netdev, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin,
Christian Marangi
Cc: stable, linux-stm32, linux-arm-kernel, linux-kernel
With the dma conf being reallocated on each call to stmmac_open(), any
information in there is lost, unless we specifically handle it.
The STMMAC_TBS_EN bit is set when adding an etf qdisc, and the etf qdisc
therefore would stop working when link was set down and then back up.
Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma conf before open")
Cc: stable@vger.kernel.org
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index b334eb16da23..25519952f754 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3932,6 +3932,9 @@ static int __stmmac_open(struct net_device *dev,
priv->rx_copybreak = STMMAC_RX_COPYBREAK;
buf_sz = dma_conf->dma_buf_sz;
+ for (int i = 0; i < MTL_MAX_TX_QUEUES; i++)
+ if (priv->dma_conf.tx_queue[i].tbs & STMMAC_TBS_EN)
+ dma_conf->tx_queue[i].tbs = priv->dma_conf.tx_queue[i].tbs;
memcpy(&priv->dma_conf, dma_conf, sizeof(*dma_conf));
stmmac_reset_queues_param(priv);
--
2.43.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings
2024-01-26 9:10 [PATCH v2 0/2] net: stmmac: dwmac-imx: Time Based Scheduling support Esben Haabendal
2024-01-26 9:10 ` [PATCH v2 1/2] net: stmmac: do not clear TBS enable bit on link up/down Esben Haabendal
@ 2024-01-26 9:10 ` Esben Haabendal
2024-01-26 13:05 ` Kurt Kanzenbach
2024-01-26 20:24 ` Vadim Fedorenko
2024-01-30 12:10 ` [PATCH v2 0/2] net: stmmac: dwmac-imx: Time Based Scheduling support patchwork-bot+netdevbpf
2 siblings, 2 replies; 6+ messages in thread
From: Esben Haabendal @ 2024-01-26 9:10 UTC (permalink / raw)
To: netdev, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Maxime Coquelin
Cc: Rohan G Thomas, Abhishek Chauhan (ABC), linux-stm32,
linux-arm-kernel, linux-kernel
TSO and TBS cannot coexist. For now we set i.MX Ethernet QOS controller to
use the first TX queue with TSO and the rest for TBS.
TX queues with TBS can support etf qdisc hw offload.
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
index 8f730ada71f9..6b65420e11b5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
@@ -353,6 +353,10 @@ static int imx_dwmac_probe(struct platform_device *pdev)
if (data->flags & STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY)
plat_dat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY;
+ /* Default TX Q0 to use TSO and rest TXQ for TBS */
+ for (int i = 1; i < plat_dat->tx_queues_to_use; i++)
+ plat_dat->tx_queues_cfg[i].tbs_en = 1;
+
plat_dat->host_dma_width = dwmac->ops->addr_width;
plat_dat->init = imx_dwmac_init;
plat_dat->exit = imx_dwmac_exit;
--
2.43.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings
2024-01-26 9:10 ` [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings Esben Haabendal
@ 2024-01-26 13:05 ` Kurt Kanzenbach
2024-01-26 20:24 ` Vadim Fedorenko
1 sibling, 0 replies; 6+ messages in thread
From: Kurt Kanzenbach @ 2024-01-26 13:05 UTC (permalink / raw)
To: Esben Haabendal, netdev, Alexandre Torgue, Jose Abreu,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Maxime Coquelin
Cc: Rohan G Thomas, Abhishek Chauhan (ABC), linux-stm32,
linux-arm-kernel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 363 bytes --]
On Fri Jan 26 2024, Esben Haabendal wrote:
> TSO and TBS cannot coexist. For now we set i.MX Ethernet QOS controller to
> use the first TX queue with TSO and the rest for TBS.
>
> TX queues with TBS can support etf qdisc hw offload.
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
Thanks for fixing this,
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings
2024-01-26 9:10 ` [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings Esben Haabendal
2024-01-26 13:05 ` Kurt Kanzenbach
@ 2024-01-26 20:24 ` Vadim Fedorenko
1 sibling, 0 replies; 6+ messages in thread
From: Vadim Fedorenko @ 2024-01-26 20:24 UTC (permalink / raw)
To: Esben Haabendal, netdev, Alexandre Torgue, Jose Abreu,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Maxime Coquelin
Cc: Rohan G Thomas, Abhishek Chauhan (ABC), linux-stm32,
linux-arm-kernel, linux-kernel
On 26/01/2024 09:10, Esben Haabendal wrote:
> TSO and TBS cannot coexist. For now we set i.MX Ethernet QOS controller to
> use the first TX queue with TSO and the rest for TBS.
>
> TX queues with TBS can support etf qdisc hw offload.
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> index 8f730ada71f9..6b65420e11b5 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> @@ -353,6 +353,10 @@ static int imx_dwmac_probe(struct platform_device *pdev)
> if (data->flags & STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY)
> plat_dat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY;
>
> + /* Default TX Q0 to use TSO and rest TXQ for TBS */
> + for (int i = 1; i < plat_dat->tx_queues_to_use; i++)
> + plat_dat->tx_queues_cfg[i].tbs_en = 1;
> +
> plat_dat->host_dma_width = dwmac->ops->addr_width;
> plat_dat->init = imx_dwmac_init;
> plat_dat->exit = imx_dwmac_exit;
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] net: stmmac: dwmac-imx: Time Based Scheduling support
2024-01-26 9:10 [PATCH v2 0/2] net: stmmac: dwmac-imx: Time Based Scheduling support Esben Haabendal
2024-01-26 9:10 ` [PATCH v2 1/2] net: stmmac: do not clear TBS enable bit on link up/down Esben Haabendal
2024-01-26 9:10 ` [PATCH v2 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings Esben Haabendal
@ 2024-01-30 12:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-30 12:10 UTC (permalink / raw)
To: Esben Haabendal
Cc: netdev, alexandre.torgue, joabreu, davem, edumazet, kuba, pabeni,
mcoquelin.stm32, shawnguo, s.hauer, kernel, festevam, linux-imx,
matthias.bgg, angelogioacchino.delregno, linux-arm-kernel,
linux-stm32, linux-kernel, rohan.g.thomas, quic_abchauha,
linux-mediatek
Hello:
This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 26 Jan 2024 10:10:40 +0100 you wrote:
> This small patch series allows using TBS support of the i.MX Ethernet QOS
> controller for etf qdisc offload.
> It achieves this in a similar manner that it is done in dwmac-intel.c,
> dwmac-mediatek.c and stmmac_pci.c.
>
> Changes since v1:
>
> [...]
Here is the summary with links:
- [v2,1/2] net: stmmac: do not clear TBS enable bit on link up/down
https://git.kernel.org/netdev/net/c/4896bb7c0b31
- [v2,2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings
https://git.kernel.org/netdev/net/c/3b12ec8f618e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread