[PATCH 0/2] Spreadtrum SC2731 MFD cleanups

[PATCH 0/2] Spreadtrum SC2731 MFD cleanups

[Stanislav Jakubek]

This series is a preparation for converting the SC27xx PMIC MFD bindings
to DT schema.

Stanislav Jakubek (2):
  arm64: dts: sprd: sc2731: correct interrupt-cells value to 2
  arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

 arch/arm64/boot/dts/sprd/sc2731.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH 1/2] arm64: dts: sprd: sc2731: correct interrupt-cells value to 2

[Stanislav Jakubek]

According to the DT bindings, SC2731's #interrupt-cells should have a
value of 2. Correct it as such.

Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
 arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi
index e15409f55f43..7e55b2b31c84 100644
--- a/arch/arm64/boot/dts/sprd/sc2731.dtsi
+++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi
@@ -13,7 +13,7 @@ sc2731_pmic: pmic@0 {
 		spi-max-frequency = <26000000>;
 		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-controller;
-		#interrupt-cells = <1>;
+		#interrupt-cells = <2>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-- 
2.34.1

Re: [PATCH 1/2] arm64: dts: sprd: sc2731: correct interrupt-cells value to 2

[Stanislav Jakubek]

Hi all,

you can most likely disregard this patch, according to [1], the correct
value is actually 1. I'll fix up the bindings during conversion, which I'll
be sending soon.

The second patch should be good.

Sorry for the noise,
Stanislav

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/sprd/sc2731.dtsi?h=v6.9&id=5863dbe071caabe752ce6f9f6782fa03914527ab

[PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

[Stanislav Jakubek]

According to DT spec, node names should be generic. Rename the
sprd,sc2731-fgu node to a more generic "fuel-gauge".

Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
 arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi
index 7e55b2b31c84..48b681768f6e 100644
--- a/arch/arm64/boot/dts/sprd/sc2731.dtsi
+++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi
@@ -95,7 +95,7 @@ pmic_adc: adc@480 {
 			nvmem-cells = <&adc_big_scale>, <&adc_small_scale>;
 		};
 
-		fgu@a00 {
+		fuel-gauge@a00 {
 			compatible = "sprd,sc2731-fgu";
 			reg = <0xa00>;
 			bat-detect-gpio = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

[Baolin Wang]

On 2024/7/14 19:57, Stanislav Jakubek wrote:
> According to DT spec, node names should be generic. Rename the
> sprd,sc2731-fgu node to a more generic "fuel-gauge".
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi
> index 7e55b2b31c84..48b681768f6e 100644
> --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi
> +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi
> @@ -95,7 +95,7 @@ pmic_adc: adc@480 {
>   			nvmem-cells = <&adc_big_scale>, <&adc_small_scale>;
>   		};
>   
> -		fgu@a00 {
> +		fuel-gauge@a00 {
>   			compatible = "sprd,sc2731-fgu";
>   			reg = <0xa00>;
>   			bat-detect-gpio = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;

Re: (subset) [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

[Krzysztof Kozlowski]

On Sun, 14 Jul 2024 13:57:00 +0200, Stanislav Jakubek wrote:
> According to DT spec, node names should be generic. Rename the
> sprd,sc2731-fgu node to a more generic "fuel-gauge".
> 
> 

This also waits for something... so I grabbed it.

Applied, thanks!

[2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic
      https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: (subset) [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

[Stanislav Jakubek]

On Wed, Aug 14, 2024 at 04:20:29PM +0200, Krzysztof Kozlowski wrote:
> 
> On Sun, 14 Jul 2024 13:57:00 +0200, Stanislav Jakubek wrote:
> > According to DT spec, node names should be generic. Rename the
> > sprd,sc2731-fgu node to a more generic "fuel-gauge".
> > 
> > 
> 
> This also waits for something... so I grabbed it.
> 
> Applied, thanks!
> 
> [2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic
>       https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c
> 
> Best regards,
> -- 
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Hi Krzysztof,

you already applied this change as part of [1].

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=0dcc203956537696e6f936eef886fde70e049f54

Cheers,
Stanislav

Re: (subset) [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

[Krzysztof Kozlowski]

On 15/08/2024 10:18, Stanislav Jakubek wrote:
> On Wed, Aug 14, 2024 at 04:20:29PM +0200, Krzysztof Kozlowski wrote:
>>
>> On Sun, 14 Jul 2024 13:57:00 +0200, Stanislav Jakubek wrote:
>>> According to DT spec, node names should be generic. Rename the
>>> sprd,sc2731-fgu node to a more generic "fuel-gauge".
>>>
>>>
>>
>> This also waits for something... so I grabbed it.
>>
>> Applied, thanks!
>>
>> [2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic
>>       https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c
>>
>> Best regards,
>> -- 
>> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Hi Krzysztof,
> 
> you already applied this change as part of [1].
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=0dcc203956537696e6f936eef886fde70e049f54

Indeed, thanks. I managed to double-apply because somehow how got
impression that was arm32, not arm64.

Best regards,
Krzysztof