From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38654CD13CF for ; Mon, 2 Sep 2024 05:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dcARxruAP0vzhVrIv4mZE+MUS7Q/ymIzQKM3BTvM2Fg=; b=eZAWOyfiIsMmzr6q9p/0Q/0TsD gNXwqkMeIY3apMKkCY6Eha78EGKRFnZEvN/NmcFekqb1jiQ9OHhv7QYq2mqEX7274e3Pk6xxNFugk +6B/K8dpXP3rjeaish2Kqx28kww1dYkyipEb6Uau6th1nIHMJzkXdaFBCQX3u5Vc0JzsawSuwNWEO O1E2uFiX93R2gfWVhf1DGOzO/Mru55Rz/9Tf9i1gzNX6wSAXf6XBmaMP7paXgyOvuZmFRPtM6CnH0 noKA+Ptk79gZTw+aUJdlkv32fKzm5A7fEo/6h4uARxihDGJh/cAvPR76ZX8YMGIa+dx6kWIe1tyHH qQpVfdHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skzha-0000000D2Sk-0lKJ; Mon, 02 Sep 2024 05:34:10 +0000 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skzfJ-0000000D1zy-0CoX for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 05:31:51 +0000 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-268d0979e90so148739fac.3 for ; Sun, 01 Sep 2024 22:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20230601.gappssmtp.com; s=20230601; t=1725255107; x=1725859907; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dcARxruAP0vzhVrIv4mZE+MUS7Q/ymIzQKM3BTvM2Fg=; b=CYA6ZS5JYtMAvsOaFKdh3PwR6eqMcTS/H9NJeGiJ7tSaFDeKdklJWSjGBJVh5LokVZ 2cCLsZCywStj3SWPjWeMrxcJo2fMGpLNo0Dr40J02LGCAshoi7DzNCt17J5EAnx1wNx5 yZMBtSncmJ/erHWinS79yTz0Y5sU/FLl1GJj4Ev+pzVXyMj8VhXczceuzsL7b6GWR6Xu 2bZ+i2EJUjPd2gohbWcBYoqHizkb53jaECgeqf2FbWPvNs+qXWTwrkexSD6S05xEoQyK 0oX3GUIgy3jTM2q79Mw+eEwm4wnIavR+6jLCdSu4y0jXkpGBCmaaopUH9r4ypzPrRdIX Dc0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725255107; x=1725859907; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dcARxruAP0vzhVrIv4mZE+MUS7Q/ymIzQKM3BTvM2Fg=; b=CGfiQ6EDtM991IbjZuSNUTR+LvQ0YJi6uBwAeIApgV3QvRORm72JK5BhBiAb9/nvUn n4/uKUicYM9ArV/7Ctlcd74CHU6Is1MY56kZYzXMplOV0QCpUV4EezJHKZzVLmVUsxvt HyiH7Yx93d6VisS+Bervgb31U7v5XVWeJatdkr6SYMs0ilwFZl5rtuq7keAF0koNtN0e hGF7CKy5e9wavlt8Gt8gtSm9iACjfQRjHfjAeiTJEZfyPaYueEZAcVVxFVXDzNmwn8Q+ 1sOdjW4fZb5/6vvBS8TL5fzmtCOVQWLPhHWE0JEQcdsIgKJfkSZaA4F/ar78wt8mJhNx h4ig== X-Forwarded-Encrypted: i=1; AJvYcCXVca3LK2+dh6e2Cm8Cy40tMCuoxCOwdHwnEhJVOfWMHKTaTbVQ/j8dv+RDIzkyL9MrV0GJSoz7+0bAnVpHun7o@lists.infradead.org X-Gm-Message-State: AOJu0YxVvt4ZR51iN8yZ6N2x1U9hjQcA2+X0+5+9f61vBQJhqAMWtdoC aT6FKTcZjGKz/rpURYEUQmbqzjv5MWyki0owlfv/Ew5GqyqbbqYNVmksxzCl6u8= X-Google-Smtp-Source: AGHT+IG4O9VSEnbCHyMlef62PC66eJmk+Wcfg7k+VoUwjggysZcp2Zp81AWYRWJzYn+qz65dfh/WPA== X-Received: by 2002:a05:6871:b09:b0:26c:78ce:b0cc with SMTP id 586e51a60fabf-277b0dd215bmr5158894fac.8.1725255107434; Sun, 01 Sep 2024 22:31:47 -0700 (PDT) Received: from telecaster.hsd1.wa.comcast.net ([2601:602:8980:9170::901f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e55a692fsm6076279b3a.60.2024.09.01.22.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Sep 2024 22:31:46 -0700 (PDT) From: Omar Sandoval To: linux-mm@kvack.org, Andrew Morton Cc: Christoph Hellwig , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org, kernel-team@fb.com Subject: [PATCH 0/2] mm: make copy_to_kernel_nofault() not fault on user addresses Date: Sun, 1 Sep 2024 22:31:27 -0700 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240901_223149_233814_9DA795E9 X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Omar Sandoval Hi, I hit a case where copy_to_kernel_nofault() will fault (lol): if the destination address is in userspace and x86 Supervisor Mode Access Prevention is enabled. Patch 2 has the details and the fix. Patch 1 renames a helper function so that its use in patch 2 makes more sense. If the rename is too intrusive, I can drop it. Thanks, Omar Omar Sandoval (2): mm: rename copy_from_kernel_nofault_allowed() to copy_kernel_nofault_allowed() mm: make copy_to_kernel_nofault() not fault on user addresses arch/arm/mm/fault.c | 2 +- arch/loongarch/mm/maccess.c | 2 +- arch/mips/mm/maccess.c | 2 +- arch/parisc/lib/memcpy.c | 2 +- arch/powerpc/mm/maccess.c | 2 +- arch/um/kernel/maccess.c | 2 +- arch/x86/mm/maccess.c | 4 ++-- include/linux/uaccess.h | 2 +- mm/maccess.c | 10 ++++++---- 9 files changed, 15 insertions(+), 13 deletions(-) -- 2.46.0