From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH 0/8] pwm: mediatek: Convert to waveform API
Date: Tue, 8 Jul 2025 19:18:30 +0200 [thread overview]
Message-ID: <cover.1751994509.git.u.kleine-koenig@baylibre.com> (raw)
Hello,
after a few cleanups and preparing changes .get_state() is implemented
and .apply() is aligned to the usual PWM rounding policy. The last
patch then converts the driver to implement the new waveform callbacks.
While this last commit removes functions that were created and adapted
earlier in the series I still consider these earlier changes sensible.
They provide a good intermediate step for both testing and bisection.
I don't have access to hardware documentation (yet), so please double
check that the names I introduce are sensible. Also one issue that I see
is that after poweron the LED that is connected to pwm0 on my mt8365
board is enabled, but the hardware is in a state that is detected as
disabled. So I'm open for feedback, otherwise I will address these
points when Mediatek will have given me access to their manuals.
Best regards
Uwe
Uwe Kleine-König (8):
pwm: mediatek: Simplify representation of channel offsets
pwm: mediatek: Introduce and use a few more register defines
pwm: mediatek: Rework parameters for clk helper function
pwm: mediatek: Initialize clks when the hardware is enabled at probe
time
pwm: mediatek: Implement .get_state() callback
pwm: mediatek: Fix various issues in the .apply() callback
pwm: mediatek: Lock and cache clock rate
pwm: mediatek: Convert to waveform API
drivers/pwm/pwm-mediatek.c | 498 +++++++++++++++++++++++++------------
1 file changed, 344 insertions(+), 154 deletions(-)
base-commit: edd3bcb1801e1bb98f4f81485140e18c86406ced
--
2.49.0
next reply other threads:[~2025-07-08 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 17:18 Uwe Kleine-König [this message]
2025-07-08 17:18 ` [PATCH 1/8] pwm: mediatek: Simplify representation of channel offsets Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 2/8] pwm: mediatek: Introduce and use a few more register defines Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 3/8] pwm: mediatek: Rework parameters for clk helper function Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 4/8] pwm: mediatek: Initialize clks when the hardware is enabled at probe time Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 5/8] pwm: mediatek: Implement .get_state() callback Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 6/8] pwm: mediatek: Fix various issues in the .apply() callback Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 7/8] pwm: mediatek: Lock and cache clock rate Uwe Kleine-König
2025-07-08 17:18 ` [PATCH 8/8] pwm: mediatek: Convert to waveform API Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1751994509.git.u.kleine-koenig@baylibre.com \
--to=u.kleine-koenig@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).