From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A62C10F14 for ; Tue, 16 Apr 2019 17:56:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A22072087C for ; Tue, 16 Apr 2019 17:56:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ezV/SaCh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="i4INWmBq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A22072087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w2++axZjO9g33Cuw2g9ql1nEyPgX8e5fdC7Cizlg/NQ=; b=ezV/SaCh9XmPOvO46/HGZRZXO KB/FbipDIu03HsbGLq5Cx1DcuQjQfA8dCJXD3Uihcb3GA1fWAAYXcyxsvT5ta/OaOa+3TilKJU+b2 h01MCI3+nBZdq2R8jvGtro9qHyUklkCj08+7v2sO5GAqKZavXTkMnoBkC4fL+hgfmWneabb4vLGA1 r+OXZrK2xCB3qDkYTCMcAcDJWGPUVzy8TedNQLzQjZtbpsT61tEOmy7xzPfYTYzHxvbdj/B+OTkfW OGzVAvj3oRTWeGTaa7apYDyUeGERWE4r0y67BvdXL+1LrczywoKxAzbZPDnc3xqeMMud9gtDz6j02 N8mypWrDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGSJF-00063s-NC; Tue, 16 Apr 2019 17:55:53 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGSJC-0005wx-Lk for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 17:55:51 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 16 Apr 2019 10:55:47 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 16 Apr 2019 10:55:50 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 16 Apr 2019 10:55:50 -0700 Received: from [10.25.74.19] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 16 Apr 2019 17:55:44 +0000 Subject: Re: [PATCH V2 13/16] arm64: tegra: Enable PCIe slots in P2972-0000 board To: Thierry Reding References: <1554407683-31580-1-git-send-email-vidyas@nvidia.com> <1554407683-31580-14-git-send-email-vidyas@nvidia.com> <20190415151235.GH29254@ulmo> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: Date: Tue, 16 Apr 2019 23:25:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190415151235.GH29254@ulmo> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1555437347; bh=NA09hSTwzj4+9peETlLcM5Mh7kA4wJJDZSW0zsGuB1c=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=i4INWmBqVuMCJB021yrPTM+zjHV+e5oH3xPjJUmOfwh4g5RirGijSl+/pTAlIeTog 0paibHDXjJcgei4w0Leph9tFhvEpujRc5kRha5pxaulh0X7+klkp6Qc2KCjOj5etcv 0HpaW7mDzXq+Jl29hOrlcpIzzaaEhWiVOK6WiJEtg9KC7w7NjSXmC8ru1pFmg0ibms jTKgkgrWmvolzV9oLwVAWdax2p2g2EkYeny9JtI6TVuZ3y/zh7qldVMeTmn0CjnO8l yMmUitSfpqCzwmJnGli/lMpiyrdzDwdy7lma8tDRG0156Vu6IFwoKwiiFuz4UxLCnn FtyhkLKXgtNIA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_105550_726004_0CDF82C1 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kthota@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/15/2019 8:42 PM, Thierry Reding wrote: > On Fri, Apr 05, 2019 at 01:24:40AM +0530, Vidya Sagar wrote: >> Enable PCIe controller nodes to enable respective PCIe slots on >> P2972-0000 board. Following is the ownership of slots by different >> PCIe controllers. >> Controller-0 : M.2 Key-M slot >> Controller-1 : On-board Marvell eSATA controller >> Controller-3 : M.2 Key-E slot >> >> Signed-off-by: Vidya Sagar >> --- >> Changes since [v1]: >> * Dropped 'pcie-' from phy-names property strings >> >> arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +- >> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 50 ++++++++++++++++++++++ >> 2 files changed, 51 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi >> index 246c1ebbd055..13263529125b 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi >> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi >> @@ -191,7 +191,7 @@ >> regulator-boot-on; >> }; >> >> - sd3 { >> + vdd_1v8ao: sd3 { >> regulator-name = "VDD_1V8AO"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <1800000>; >> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >> index b62e96945846..82eb30bceaa6 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >> @@ -169,4 +169,54 @@ >> }; >> }; >> }; >> + >> + pcie@14180000 { >> + status = "okay"; >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + >> + phys = <&p2u_2>, >> + <&p2u_3>, >> + <&p2u_4>, >> + <&p2u_5>; > > You can use multiple entries on a single line, especially if they are > this short. > >> + phy-names = "p2u-0", "p2u-1", "p2u-2", >> + "p2u-3"; > > Same here. > >> + }; >> + >> + pcie@14100000 { >> + status = "okay"; >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + >> + phys = <&p2u_0>; >> + phy-names = "p2u-0"; >> + }; >> + >> + pcie@14140000 { >> + status = "okay"; >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + >> + phys = <&p2u_7>; >> + phy-names = "p2u-0"; >> + }; >> + >> + pcie@141a0000 { >> + status = "disabled"; >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + >> + phys = <&p2u_12>, >> + <&p2u_13>, >> + <&p2u_14>, >> + <&p2u_15>, >> + <&p2u_16>, >> + <&p2u_17>, >> + <&p2u_18>, >> + <&p2u_19>; >> + >> + phy-names = "p2u-0", "p2u-1", "p2u-2", >> + "p2u-3", "p2u-4", "p2u-5", >> + "p2u-6", "p2u-7"; > > And here. I'll take care of all these in V3 series. > > Thierry > >> + }; >> }; >> -- >> 2.7.4 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel