linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
	mpm@selenic.com, herbert@gondor.apana.org.au, rjui@broadcom.com,
	sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	Julia.Lawall@inria.fr, f.fainelli@gmail.com,
	linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Nicolas Saenz Julienne" <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v2] hwrng: iproc: set quality to 1024
Date: Mon, 22 Feb 2021 19:51:56 +0100	[thread overview]
Message-ID: <d028a276-a7fe-9a05-124d-502f0e9ca75f@i2se.com> (raw)
In-Reply-To: <20210220200107.4833-1-noltari@gmail.com>

Hi,

Am 20.02.21 um 21:01 schrieb Álvaro Fernández Rojas:
> This allows khwrngd to make use of iproc-rng200.
>
> Justification:
> cat /dev/hwrng | rngtest -c 1000
> rngtest 6.10
> Copyright (c) 2004 by Henrique de Moraes Holschuh
> This is free software; see the source for copying conditions.  There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> rngtest: starting FIPS tests...
> rngtest: bits received from input: 20000032
> rngtest: FIPS 140-2 successes: 1000
> rngtest: FIPS 140-2 failures: 0
> rngtest: FIPS 140-2(2001-10-10) Monobit: 0
> rngtest: FIPS 140-2(2001-10-10) Poker: 0
> rngtest: FIPS 140-2(2001-10-10) Runs: 0
> rngtest: FIPS 140-2(2001-10-10) Long run: 0
> rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
> rngtest: input channel speed: (min=107.179; avg=200.770; max=9765625.000)Kibits/s
> rngtest: FIPS tests speed: (min=34.742; avg=39.905; max=66.458)Mibits/s
> rngtest: Program run time: 97829648 microseconds
>
> 1000 successes and 0 failures -> 100% success rate
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

i just want to mention that there were concerns about such changes in
the past [1]

Regards
Stefan

[1] - https://lkml.org/lkml/2020/5/14/1292


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2021-02-22 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-20 18:29 [PATCH] hwrng: iproc: set quality to 1000 Álvaro Fernández Rojas
2021-02-20 20:01 ` [PATCH v2] hwrng: iproc: set quality to 1024 Álvaro Fernández Rojas
2021-02-22 17:40   ` Scott Branden
2021-02-22 18:51   ` Stefan Wahren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d028a276-a7fe-9a05-124d-502f0e9ca75f@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=noltari@gmail.com \
    --cc=nsaenzjulienne@suse.de \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).