From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB897CF9C68 for ; Sun, 22 Sep 2024 23:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3QmeQYM479yzZexFRDFHjQcwG9TTAWkIzn56oUaf14U=; b=MGLH7Zo16sh1DOIrCcoYu8D11l pzfgmhsxHr8BQd/gnjPI9bCCIvfLvuxeOgLkVQG6cFzlTIdQoljeYxu/J0+cLcMBhYmQX8vw+9hP+ INeVXwyJVsc4uNnqSepQlHnHbKSqkUZO+UlxwYwaCQm7cTh8QREkk8NbAGx4qeLjmzHBmJRwfTbLB xk0pQH4T59KTvT5FuobY66DdwkB/KdcBsK+gdMuTpLTVgHin27rQkq21/Sw42K4/AfdXeKQD2aG+u JO2GeQ0Eky0SbJS22B+cvMcMrcHhNzEyVzL8vBfXqWdi6RbtpVEyTI1PqQ4HlDxnEIjr33MIjlWeK ei+JqBuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssVsW-0000000Fvjn-2GfY; Sun, 22 Sep 2024 23:20:32 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssVrP-0000000FvbU-0ofW for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2024 23:19:24 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42cd46f3a26so31487835e9.2 for ; Sun, 22 Sep 2024 16:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727047161; x=1727651961; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3QmeQYM479yzZexFRDFHjQcwG9TTAWkIzn56oUaf14U=; b=KIXrk61PxWjebVwku4cU71rBB0pi1npF2Hq/UJQBT25xK2lr3At6N5ghqxS+X6B1/i Tn29EeHlRjMuD6DEmmDpQFBAgDmk8Ntv90PY2nrmO3KsJov7FDeSqHUbqdSKXJ2NEqzV BfMFox457v7GjiblDnlKEMS9YVRAwAgz9ReqebtNwGhQOkFDjg2CUChwVoamyMJYCca0 jbH5OsVWzNg0En0xzEBlIeyHWs6+8xIuXMOucyyrNo6ic2tZ7KlmeniIEAdHtLemiP7w //xohUDiawp1zVF7LNqUkhza2OfMv4JhyX/06zHn4vHbiUFeFCXeR0BEWGk2FIqen85C 5WEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727047161; x=1727651961; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3QmeQYM479yzZexFRDFHjQcwG9TTAWkIzn56oUaf14U=; b=XYoAbiXX8QgcNzdqthguKDU545XntF7zQuAuRC72rio2iL00Laum/Wjl350zEWsoWs qlze3jP2mImbeEL+LBLF/J0fX3jMgMpeReR/7Ab5HVGBFQrSS0a2gq4+ZDu+B4ElEqIt BuqKwPd7hcEZhhH7pJcMMwzf4dwCrG13EC1vT+1sTLKBJgwKIKfAvdcMhc3W+TI8GToK IpYzgYQaQsD/mnB/Kp7q91hmJCfkfLT+px2AYU+YApINg5d8vI6gs+ccv5Nc/sJnWfBN tfzBMGUA6/G8vkUZiGbgpx9MOHwiqmtokVEFNksa+gFfSDjVfHItoiYIdHI6IfVdIky2 mfKQ== X-Forwarded-Encrypted: i=1; AJvYcCVRV2QCTCrOj2E4+LW66drT7L9T6xUDI0rzDnX4tjQXm7beEYOwEI4cLinVECJIdKJHtr08ACO6pSfV/yQLJ819@lists.infradead.org X-Gm-Message-State: AOJu0YzJGfWnYmqZCPav9ua35fUaFd2GnoPhmWVa5MgrvlaLWy6MQ17T ONTrGmo5dWN1LHa2dG2ZbWslKZdSJAZvAWjo0dVj0HDQVRoQ4Yx8 X-Google-Smtp-Source: AGHT+IGZZw5+3WxxKggocLFzJxwqoSd1f5PjjLcsXXYGL35zdx9oJLvHztzhdL/betnYcPItTEYQ7Q== X-Received: by 2002:a05:600c:4e92:b0:42c:bde5:9082 with SMTP id 5b1f17b1804b1-42e7ac225b4mr82073095e9.17.1727047161066; Sun, 22 Sep 2024 16:19:21 -0700 (PDT) Received: from [192.168.1.130] ([86.127.146.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7af895b8sm85431855e9.14.2024.09.22.16.19.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Sep 2024 16:19:20 -0700 (PDT) Message-ID: Date: Mon, 23 Sep 2024 02:19:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] arm64: dts: imx8qm: add node for VPU dsp Content-Language: en-US To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240918182117.86221-1-laurentiumihalcea111@gmail.com> <20240918182117.86221-5-laurentiumihalcea111@gmail.com> From: Laurentiu Mihalcea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240922_161923_273227_02EC0192 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/18/2024 9:57 PM, Frank Li wrote: > On Wed, Sep 18, 2024 at 02:21:16PM -0400, Laurentiu Mihalcea wrote: >> From: Laurentiu Mihalcea >> >> Add DT node for i.MX8QM's DSP, which is found in >> the VPU subsystem. >> >> Signed-off-by: Laurentiu Mihalcea >> --- >> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 27 +++++++++++++++++++++++ > why not add a file imx8qm-ss-vpu.dtsi to keep consistent with others. Don't see much value in doing so right now. It's just two extra nodes (should stay that way AFAICT). > > Frank > >> 1 file changed, 27 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi >> index f8b577ebdbef..ae0165a44dcd 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi >> @@ -581,6 +581,33 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll { >> clock-output-names = "mipi_pll_div2_clk"; >> }; >> >> + vpu_subsys_dsp: bus@55000000 { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x55000000 0x0 0x55000000 0x1000000>; >> + >> + vpu_dsp: dsp@556e8000 { >> + compatible = "fsl,imx8qm-hifi4"; >> + reg = <0x556e8000 0x88000>; >> + clocks = <&clk_dummy>, >> + <&clk_dummy>, >> + <&clk_dummy>; >> + clock-names = "ipg", "ocram", "core"; >> + power-domains = <&pd IMX_SC_R_MU_13B>, >> + <&pd IMX_SC_R_DSP>, >> + <&pd IMX_SC_R_DSP_RAM>, >> + <&pd IMX_SC_R_IRQSTR_DSP>, >> + <&pd IMX_SC_R_MU_2A>; >> + mbox-names = "tx", "rx", "rxdb"; >> + mboxes = <&lsio_mu13 0 0>, >> + <&lsio_mu13 1 0>, >> + <&lsio_mu13 3 0>; >> + firmware-name = "imx/dsp/hifi4.bin"; >> + status = "disabled"; >> + }; >> + }; >> + >> /* sorted in register address */ >> #include "imx8-ss-cm41.dtsi" >> #include "imx8-ss-audio.dtsi" >> -- >> 2.34.1 >>