Re: [PATCH 1/5] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings

[Josua Mayer <josua@solid-run.com>]

Am 24.12.23 um 11:52 schrieb Krzysztof Kozlowski:
> On 24/12/2023 11:16, Josua Mayer wrote:
>> Am 24.12.23 um 10:10 schrieb Krzysztof Kozlowski:
>>> On 23/12/2023 22:29, Josua Mayer wrote:
>>>> Most arm board have a board-specific compatible string that allows e.g.
>>>> userspace to match specific firmware variants or apply specific
>>>> policies.
>>>>
>>>> Add board-specific properties to both variants of the Clearfog GTR:
>>>> - solidrun,clearfog-gtr-l8
>>>> - solidrun,clearfog-gtr-s4
>>>>
>>>> Introduction of a common parent (e.g. "solidrun,clearfog-gtr") is
>>>> omitted for brevity.
>>>> Since announcement of the two products no additional variants were added
>>>> it is assumed that there will always be just two.
>>>>
>>>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>>>> ---
>>>>    arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts | 1 +
>>>>    arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-s4.dts | 1 +
>>>>    2 files changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts
>>>> index 1990f7d0cc79..ae921a674c93 100644
>>>> --- a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts
>>>> +++ b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts
>>>> @@ -4,6 +4,7 @@
>>>>    
>>>>    / {
>>>>    	model = "SolidRun Clearfog GTR L8";
>>>> +	compatible = "solidrun,clearfog-gtr-l8", "marvell,armada385", "marvell,armada380";
>>> Please run scripts/checkpatch.pl and fix reported warnings. Some
>>> warnings can be ignored, but the code here looks like it needs a fix.
>>> Feel free to get in touch if the warning is not clear.
>>>
>>> I don't see them being documented.
>> Yes, checkpatch warned about that specifially, but I am not sure how to
>> proceed.
>> The armada-38x dt bindings documentation is stil in text format, and
>> doesn't document any board:
>>
>> Documentation/devicetree/bindings/arm/marvell/armada-38x.txt
> There was some work in progress, AFAIR. This should be solved before
> bringing more undocumented compatibles.

Okay. Since armada-38x.txt is small enough,
I have drafted conversion to yaml and new bindings.
Will submit them as part of a v2 after validating other changes.

Thanks!

>
> Best regards,
> Krzysztof
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel