From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC669C3A59F for ; Tue, 27 Aug 2019 00:08:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DED32053B for ; Tue, 27 Aug 2019 00:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dxkuAlvT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RX9x+6Dt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DED32053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2T+XDCePPD2JRmlWO1eIgKXGH99qapcEVjI4E/qk5/s=; b=dxkuAlvTBBNF0dGVuxyZzRKtC lIBedTUuWLL4m/skplLrkVIdocg2noN+3RaTQyjkfEbVjiTOu8tmIfyI+8+G4CJLPBQ0Yb2XTOkpE mSKV0OMvSZcLkH0s2SICpWnHAgo4twtZ4BTmIZ0yb0cWB61vSZw/2tLke/z9jVbWUwecv2UGtj7Zq U1LZhDTr0U3vchc7MwgYYx3FooBHOYEgUV9tU7iPruurS/onD4jV9PgUgqljrmktJi+KJzMVKhZhB 2gL1txT0nvdc/ThLo317PD/E6xvhO4CVMh64YCap2jQFYGgJOfN8xFSeVT+brR6XMc7b8dKWf/dPc MeiJusZkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2P23-0007Ca-H3; Tue, 27 Aug 2019 00:08:19 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2P20-0007Bo-C3 for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2019 00:08:17 +0000 Received: by mail-pf1-x441.google.com with SMTP id i30so12853141pfk.9 for ; Mon, 26 Aug 2019 17:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=op+KI7TlBsB6S6sFewOJ0t706uisxtkweddZPva/XUs=; b=RX9x+6DtGafaHO1iuCX95LpTQasZh6Epfv1c1WbVTDYTdGMgc1MTuuAunpoIXNNQhd dyvTNYlk5n1nkTqY721ASC09AaF3Jd2PeyOINmfcUce/x/U0YrVO2OGxhy1eJkkIdVcy TrypAKXyYIZgYBYIgWvMufNafmydykIbS4ktkSRekVFf1BscbukfP/gaj1ctYHrHIdI/ W2Mu0iyEX6/umnjyUCn9Ad/wL0b0RAXM5UjjCAMWeg1lV/NxmqX4SSqS6TOZJnhVTtps aBxZY57njSC06peMlK8cO24ROLSbspHwy4OMMx2ogZIgS5YEKWUSUpoc/lhDEs5fUsfy oF8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=op+KI7TlBsB6S6sFewOJ0t706uisxtkweddZPva/XUs=; b=LcJuvz/kKjYYWrGUQmG8bSlgu5n+FRfdUR3uHH6XgxitAMAaCgENYysfJ4Qy736Zoo 2ouRshedxYQg96auQ5Y76Md2mL/QzSY2SpotrZ4yuQzCKUe/bpPih6HLPWvMTAn7wD1y tk4EU/cbewzLKvNtk917p6SL4LubQY0PKWA7kW0FZqi4R8L6E3sGcpGBcq6a1yXLXQqH Fk13pq4/QQn8mrXUvTReYdoc0yFB0MoNof4TUUvmJ6IjR6agZ+pARLNjiYndaDCKkrG5 yXa5VeAYyUpDMcFUExtFSZRgkH5u/Wd2eFG4iTN77V91sSI2pBt5tTnr/EjwQ4Vsbf32 21Fw== X-Gm-Message-State: APjAAAW/+dxoyU8wH37vso45quuSwS/12apTtuJ7zBj91iPa3BmBXIQN Xpc5F/6Oci+LOqT69p6RmrU= X-Google-Smtp-Source: APXvYqyCOpJkfY8Cd0SdDE6aYRxO1Pg9WhbY61Aef8FokG+LaTjhPfxqLF8Bp0gzFOPMpKEYS54c7Q== X-Received: by 2002:a62:7789:: with SMTP id s131mr23022125pfc.50.1566864493131; Mon, 26 Aug 2019 17:08:13 -0700 (PDT) Received: from server.roeck-us.net (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id b126sm17923109pfb.110.2019.08.26.17.08.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 17:08:12 -0700 (PDT) Subject: Re: [PATCH v2 4/4] dt-bindings/watchdog: Add access_cs0 option for alt-boot To: Andrew Jeffery , Ivan Mikhaylov , Wim Van Sebroeck References: <20190826104636.19324-1-i.mikhaylov@yadro.com> <20190826104636.19324-5-i.mikhaylov@yadro.com> From: Guenter Roeck Message-ID: Date: Mon, 26 Aug 2019 17:08:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_170816_439468_67409BFA X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Alexander Amelkin , linux-kernel@vger.kernel.org, Rob Herring , Joel Stanley , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/26/19 4:57 PM, Andrew Jeffery wrote: > > > On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: >> The option for the ast2400/2500 to get access to CS0 at runtime. >> >> Signed-off-by: Ivan Mikhaylov >> --- >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> index c5077a1f5cb3..023a9b578df6 100644 >> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> @@ -34,6 +34,13 @@ Optional properties: >> engine is responsible for this. >> >> - aspeed,alt-boot: If property is present then boot from alternate >> block. >> + At alternate side 'access_cs0' sysfs file >> provides: > > Why are we talking about sysfs in the devicetree binding? This patch > doesn't seem right to me. > Correct; this is the wrong document. The attribute also will need to be better explained. "At alternate side" does not explain (at least not at all clearly enough) that the attribute only exists if the system has booted from the alternate flash / block. > Also if we're not supporting the aspeed,alt-boot property we should > probably document it as deprecated rather than making it disappear, > unless you're going to fix the systems that are using it. > Sorry, you lost me here. Where is it made to disappear ? Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel